Change in ovirt-engine[master]: engine, webadmin: Allow creation of cluster of required version
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine, webadmin: Allow creation of cluster of required version
......................................................................
engine, webadmin: Allow creation of cluster of required version
This patch allows creation of required version cluster in gluster-only mode.
The approach taken is :
1. Show all avilable versions instead of only the latest
This is achieved by passing null(ONLY IN GLUSTER_ONLY MODE) as datacenter
id to the query that fetches the versions based on datacenter version.
And the query is intelligent to handle this.
2. By default the Default cluster is of highest supported version and in
gluster-only mode the data center is not editable or even for that matter
visible. This blocks the creation of a cluster with any version lower than
highest supported version.This patch hence relaxes,
ClusterValidator#dataCenterVersionMismatch for gluster-only mode
Change-Id: Idc81ec4e7e0cac9109cb21ab5b4a1bb8c1138ee5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1056936
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ClusterValidatorTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
5 files changed, 27 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
anmolbabu: Verified
Kanagaraj M: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc81ec4e7e0cac9109cb21ab5b4a1bb8c1138ee5
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine : Enable "cluster.enable-shared-storage"
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine : Enable "cluster.enable-shared-storage"
......................................................................
engine : Enable "cluster.enable-shared-storage"
This patch sets cluster option "cluster.enable-shared-storage"
to "enable" when user tries to set the geo-replication session option
use_meta_volume to true.
Setting the option "cluster.enable-shared-storage" to "enable" on gluster
side creates and mounts the meta volume.
Change-Id: Id769bcf1a5096079caebe4295f702f8980b625b2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234357
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
anmolbabu: Verified
Sahina Bose: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44224
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id769bcf1a5096079caebe4295f702f8980b625b2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: webadmin: Enable force start gluster volume
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: Enable force start gluster volume
......................................................................
webadmin: Enable force start gluster volume
This patch enables user to force start a degraded gluster
volume. The patch handles the following cases :
Case-1 : Start volumes selected from Volumes main tab
case-2 : Click on unknown status icon against each volume
It takes the following appraoach:
1. Enable user to start volume when some/all bricks of the
volume(s) is down.
2. Separate out the list of volumes as
2.1 Volumes that are down and don't need force start
2.2 Volumes with status up but some/all bricks down.
These volumes require force start as they are in
degraded state.
3. Simply attempt start on volumes in list obtained from 2.1
4. Show force warning for volumes staisfying 2.2 (if any).
On click of "OK" :
4.1 If user selects force check box force start the volumes in
the list.
4.2 If force check box is not selected, attempt normal start
with force = false.
Steps 3 and 4 are attempted with UI error-handling set to true.
This patch also relaxws a canDoAction to suit the requirement that
if the volume is "UP" but not all the bricks participating in the
volume are "UP", then force start needs to be permitted.
Change-Id: Ib421030714f190feea1737d8c97f2e6308e72199
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182373
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeStatusCell.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusColumn.java
8 files changed, 136 insertions(+), 14 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
anmolbabu: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43580
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib421030714f190feea1737d8c97f2e6308e72199
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-node-plugin-vdsm[master]: autoreg: replace execute_cmd for usermod/chage
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: autoreg: replace execute_cmd for usermod/chage
......................................................................
autoreg: replace execute_cmd for usermod/chage
Replace the execute_cmd for process.call.
Change-Id: I1a3fdeb68b461e9a04ed2a14705dea3dfd3b33f0
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44217
Continuous-Integration: Jenkins CI
---
M autoinstall/ovirt-node-plugin-vdsm-autoreg
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a3fdeb68b461e9a04ed2a14705dea3dfd3b33f0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Avoid calling CloneCinderDisks when no Cidner disks ex...
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Avoid calling CloneCinderDisks when no Cidner disks exists.
......................................................................
core: Avoid calling CloneCinderDisks when no Cidner disks exists.
Check if there are exists Cinder disks when creating a VM.
If there are not any, avoid calling CloneCinderDisks.
Change-Id: I54b883aa09d7c78180281082c7262a910b5a72f3
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
3 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44175
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54b883aa09d7c78180281082c7262a910b5a72f3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in jenkins[master]: ovirt-engine_upgrade_3.5_to_master: add missing fqdn
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine_upgrade_3.5_to_master: add missing fqdn
......................................................................
ovirt-engine_upgrade_3.5_to_master: add missing fqdn
Change-Id: If4f2faba83e650e1a84f0a4950be4d9de1c2750b
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/ovirt-engine_upgrade_3.5_to_master/setup.file.otopi
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/44202
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4f2faba83e650e1a84f0a4950be4d9de1c2750b
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Custom dropdown chrome
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal,webadmin: Custom dropdown chrome
......................................................................
userportal,webadmin: Custom dropdown chrome
- The height in the custom drop downs in chrome
was too small, this patches fixes that issue
Change-Id: I71b3cf9ef250647c18e08cccc8c83c21f7474477
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1247662
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44167
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71b3cf9ef250647c18e08cccc8c83c21f7474477
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in jenkins[master]: ovirt-engine_upgrade_3.5_to_master: updated answers
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine_upgrade_3.5_to_master: updated answers
......................................................................
ovirt-engine_upgrade_3.5_to_master: updated answers
updated answers files for 3.5 setup / cleanup
Change-Id: I2390c6be0798f5e134347684dff42045cec9b80a
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/ovirt-engine_upgrade_3.5_to_master/cleanup.file.otopi
M jobs/ovirt-engine_upgrade_3.5_to_master/setup.file.otopi
2 files changed, 51 insertions(+), 36 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/44200
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2390c6be0798f5e134347684dff42045cec9b80a
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
9 years, 4 months
Change in ovirt-engine[master]: engine : Add null check for cmd entity in CoCo
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : Add null check for cmd entity in CoCo
......................................................................
engine : Add null check for cmd entity in CoCo
CommandExecutor.invokeCallbackMethods should check if
command entity exists before setting initial and
remaining delay.
Change-Id: I583fed12c03bd2ecad6bf584a9e8eaaaa034a8fe
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I583fed12c03bd2ecad6bf584a9e8eaaaa034a8fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: sercon: send correct content-type from client
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: sercon: send correct content-type from client
......................................................................
sercon: send correct content-type from client
Declare the correct content-type for requests from client.
Roughly after the move to Wildfly, the ovirt-vmconsole-list.py helper
stopped working, because the server-side applet was not able anymore
to fetch the request body.
That happened because the ovirt-vmconsole-list.py helper was using
an incorrect content-type for its requests: it stated that the body
is encoded using MIME type 'application/x-www-form-urlencoded',
but that was false.
When we use the x-www-form-urlencoded content type the server tries
to interpret it as form, and thus it consumes all the body input stream
looking for "a=b&c=d&...".
This may have changed from jboss to wildfly, but the key point was that
the incorrect (and default) content-type sent by client may confuse a
well-behaving conformant server, leading into troubles.
This patch fixes the client using the correct content-type: 'text/plain'.
Change-Id: Iecd37a03d18aa720f00011c91d23a27738afacd2
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/44170
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecd37a03d18aa720f00011c91d23a27738afacd2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months