Change in ovirt-host-deploy[master]: common: initialize the incomplete variables
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: common: initialize the incomplete variables
......................................................................
common: initialize the incomplete variables
engine can use common method for both deploy and mgmt and acquire
partial setup messages always.
Change-Id: I3919a3435e49a8b072992182edf07c4d67c2b846
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M configure.ac
M po/POTFILES.in
M src/plugins/ovirt-host-common/Makefile.am
A src/plugins/ovirt-host-common/core/Makefile.am
A src/plugins/ovirt-host-common/core/__init__.py
A src/plugins/ovirt-host-common/core/misc.py
M src/plugins/ovirt-host-deploy/core/misc.py
7 files changed, 134 insertions(+), 6 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44150
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3919a3435e49a8b072992182edf07c4d67c2b846
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: Added null check to AREM
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Added null check to AREM
......................................................................
core: Added null check to AREM
Added a null check for affinity group entity ids on AREM methods in the
AffinityRulesUtils class, Because it failed the REST api tests.
Change-Id: I7c057290a8cb8a9a688a4c964b8120bf6436dcc8
Bug-Url: https://bugzilla.redhat.com/1245066
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/AddAffinityGroupCommandTest.java
2 files changed, 22 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Tomer Saban: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44001
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c057290a8cb8a9a688a4c964b8120bf6436dcc8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: webadmin: 'Next start configuration' dialog label changed
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: 'Next start configuration' dialog label changed
......................................................................
webadmin: 'Next start configuration' dialog label changed
'Next Restart Configuration' -> 'Next Start Configuration'. Dialog label
changed to avoid confusion that restart action might apply changes.
Change-Id: Id31702a1526d4202b74cf25e2dbeb0b2609628a6
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44135
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id31702a1526d4202b74cf25e2dbeb0b2609628a6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: AddBricksToGlusterVolumeCommand redundancy
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: AddBricksToGlusterVolumeCommand redundancy
......................................................................
core: AddBricksToGlusterVolumeCommand redundancy
AddBricksToGlusterVolumeCommand.canDoAction() checks that
getParameters().getBricks() is not null or empty. Therefore, it's
redundant to re-check it in the executeCommand() method.
This patch fixes Coverity defect CID 1311883.
Change-Id: Idff9d7d7c1ac04c23de64debac6ae652b2780dc7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
1 file changed, 11 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43800
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idff9d7d7c1ac04c23de64debac6ae652b2780dc7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: move containsUnregisteredEntities to StorageDomainDynamic
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: move containsUnregisteredEntities to StorageDomainDynamic
......................................................................
core: move containsUnregisteredEntities to StorageDomainDynamic
The field containsUnregisteredEntities is not determined by the user,
but is calculated according to its actions.
Thus, it should be in StorageDomainDynamic and not in
StorageDomainStatic.
Change-Id: Ic725b03b35de0388519e19768db426df868b0022
Bug-Url: https://bugzilla.redhat.com/1247144
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java
3 files changed, 14 insertions(+), 15 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/44140
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic725b03b35de0388519e19768db426df868b0022
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.3]: packaging: post ovirt-host-deploy-1.3.2
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post ovirt-host-deploy-1.3.2
......................................................................
packaging: post ovirt-host-deploy-1.3.2
Change-Id: Id038f02adc7c1f3b60f64890c3dffeec73dd8b29
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M configure.ac
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44143
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id038f02adc7c1f3b60f64890c3dffeec73dd8b29
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.3]: packaging: ovirt-host-deploy-1.3.2
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: ovirt-host-deploy-1.3.2
......................................................................
packaging: ovirt-host-deploy-1.3.2
Change-Id: Icf893889fc7338cfd0000d2bfe70a69d334d3e88
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M configure.ac
M ovirt-host-deploy-offline.spec.in
M ovirt-host-deploy.spec.in
4 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44142
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf893889fc7338cfd0000d2bfe70a69d334d3e88
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in jenkins[master]: publish-rpms-nightly-master: publish ovirt-live artifacts
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: publish-rpms-nightly-master: publish ovirt-live artifacts
......................................................................
publish-rpms-nightly-master: publish ovirt-live artifacts
Change-Id: Ic5630c0ff0815a58c019690ba3ba874f7a540bd1
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/yaml/jobs/ovirt/publish-rpms-nightly-master.yaml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44139
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5630c0ff0815a58c019690ba3ba874f7a540bd1
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
9 years, 2 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.3]: kdump: Display clear message when kdump fails to start
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: kdump: Display clear message when kdump fails to start
......................................................................
kdump: Display clear message when kdump fails to start
Displays clear error message when kdump service failed to start.
Change-Id: Ib23538998b39ed89b30dbc9637750ee6cc1c1daa
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248010
Signed-off-by: Martin Perina <mperina(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M src/plugins/ovirt-host-deploy/kdump/packages.py
2 files changed, 13 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44068
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib23538998b39ed89b30dbc9637750ee6cc1c1daa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.3
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-host-deploy[master]: doc: ChangeLog: update kdump entry
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: doc: ChangeLog: update kdump entry
......................................................................
doc: ChangeLog: update kdump entry
Change-Id: Ib8dad4fd761badd808687efe173603be36566f22
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44141
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8dad4fd761badd808687efe173603be36566f22
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months