Change in ovirt-engine[master]: checkstyle: Fix imports order to fit project standards in vd...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: checkstyle: Fix imports order to fit project standards in vdsbroker
......................................................................
checkstyle: Fix imports order to fit project standards in vdsbroker
Change-Id: Iab7d3bc5744440a7bf2910b8d1805f2d6cc1a4c8
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/common/qualifiers/MomPolicyUpdate.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostDevListByCapsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetAmountOfMemoryVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsStatisticsFetcher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/architecture/CreateAdditionalControllers.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationValue.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IRSGenericException.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStoragePoolVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainsListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ImageSizeReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ResizeStorageDomainPVMapReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetMOMPolicyParametersVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmSerialNumberBuilder.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmTestPairs.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsListFetcherTest.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmSerialNumberBuilderTest.java
33 files changed, 82 insertions(+), 76 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Vered Volansky: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43482
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab7d3bc5744440a7bf2910b8d1805f2d6cc1a4c8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: checkstyle: Fix imports order to fit project standards in sc...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: checkstyle: Fix imports order to fit project standards in scheduler
......................................................................
checkstyle: Fix imports order to fit project standards in scheduler
Change-Id: I559d40f4fd7189ad94259e314343e6e47fb3d7f7
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Vered Volansky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43481
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I559d40f4fd7189ad94259e314343e6e47fb3d7f7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: checkstyle: Fix imports order to fit project standards in dal
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: checkstyle: Fix imports order to fit project standards in dal
......................................................................
checkstyle: Fix imports order to fit project standards in dal
Change-Id: I66c4f9ab17e4d39ddd9b4c3283ce5326a0cd5d8e
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcCommandBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/utils/CacheManager.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BusinessEntitySnapshotDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineBackupLogDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LibvirtSecretDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LibvirtSecretDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UserProfileDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDefaultDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDefaultDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BusinessEntitySnapshotDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/CommandEntityDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EngineBackupLogDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EngineSessionDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/IscsiBondDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UniqueIdentifierType.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UserProfileDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmIconDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmIconDefaultDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmJobDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkQosDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VnicProfileDaoTest.java
34 files changed, 101 insertions(+), 100 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Vered Volansky: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43480
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66c4f9ab17e4d39ddd9b4c3283ce5326a0cd5d8e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: checkstyle: Fix imports order to fit project standards in utils
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: checkstyle: Fix imports order to fit project standards in utils
......................................................................
checkstyle: Fix imports order to fit project standards in utils
Change-Id: Ifa0d61d42893c983bca3a99d4cce06adb17590f9
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReflectionUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/CachedTar.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/Tar.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNode.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNodeList.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/VdcActionTypeDeserializer.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumUtilsTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/XmlUtilsTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtilsTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/db/StandaloneDataSourceTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/linq/NotPredicateTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/LocaleFilterTest.java
20 files changed, 43 insertions(+), 39 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Vered Volansky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43479
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa0d61d42893c983bca3a99d4cce06adb17590f9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: checkstyle: Fix imports order to fit project standards in co...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: checkstyle: Fix imports order to fit project standards in common
......................................................................
checkstyle: Fix imports order to fit project standards in common
Change-Id: Icebf3fb9d43636880532acab8f7d10d4b5ae6011
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddSANStorageDomainParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneCinderDisksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateCloneOfTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HasGraphicsDevices.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmImagesParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskSnapshotsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RngDeviceParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ShutdownVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StopVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StopVmParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmHostDevicesParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/WatchdogParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/EndedTaskInfo.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandAssociatedEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableDeviceOnVmStatusField.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLog.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDeviceView.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/InstanceType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SubjectEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsTemplateMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsTemplateMapId.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmHostDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmIcon.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmIconDefault.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInitNetwork.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderVolumeDriver.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderVolumeStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LibvirtSecret.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/DefaultValueAttribute.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/OptionBehaviourAttribute.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/TypeConverterAttribute.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VDSError.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllFromExportDomainQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmIconsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VmIconIdSizePair.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PerHostMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/CustomPropertiesUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/MaskConstraint.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/SerialNumberPolicyValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/TimeZoneValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/UriConstraint.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/MTU.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidI18NExtraName.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidSerialNumberPolicy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidTimeZone.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidUri.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStoragePoolVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExtendVmDiskSizeVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HotPlugDiskVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RegisterLibvirtSecretsVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmTicketVDSCommandParameters.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/AuditLogTypeTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/TimeZoneTypeTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/BootSequenceTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/StorageTypeTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VdsStaticTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmStatisticsTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/console/ConsoleOptionsTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IpAddressConverterTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ObjectUtilsTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtilsTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/MaskConstraintTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/MaskValidatorTest.java
88 files changed, 181 insertions(+), 146 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Vered Volansky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43478
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icebf3fb9d43636880532acab8f7d10d4b5ae6011
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: checkstyle: Fix imports order to fit project standards in co...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: checkstyle: Fix imports order to fit project standards in compat & uutils
......................................................................
checkstyle: Fix imports order to fit project standards in compat & uutils
Change-Id: I9cf788040c50dd8aab650dfc17f41a1851cfccf1
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/WindowsJavaTimezoneMapping.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/CertificateChain.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/EnvelopeEncryptDecrypt.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/EnvelopePBE.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/PropertiesTest.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java
10 files changed, 15 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Vered Volansky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43477
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cf788040c50dd8aab650dfc17f41a1851cfccf1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: checkstyle: upgrade to checkstyle 6.5
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: checkstyle: upgrade to checkstyle 6.5
......................................................................
checkstyle: upgrade to checkstyle 6.5
Upgrade checkstyle version to 6.5 which allows better sort validations
for imports
Change-Id: I95b7a14bdb6e6875e953b671d697696ef0928bcf
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M pom.xml
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Vered Volansky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43476
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95b7a14bdb6e6875e953b671d697696ef0928bcf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: checkstyle: Reformat one liner methods
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: checkstyle: Reformat one liner methods
......................................................................
checkstyle: Reformat one liner methods
Reformat one liner methods to fit the project standards
Change-Id: I189520de7cc5d5e07c6685443138d1d1354d4ee8
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanError.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanErrorWrapper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StopVmParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyVmVDSCommandParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java
M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/FenceConfigValueHelperTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingVmInstanceTypeManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
11 files changed, 88 insertions(+), 29 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Vered Volansky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43475
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I189520de7cc5d5e07c6685443138d1d1354d4ee8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: packaging: setup: move ADMIN_PASSWORD from global setup to e...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: move ADMIN_PASSWORD from global setup to engine specific
......................................................................
packaging: setup: move ADMIN_PASSWORD from global setup to engine specific
probably a left over.
Change-Id: I359378c6efaaa1330a0be10d999c56cfe9aedbba
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsmi.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py
4 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43584
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I359378c6efaaa1330a0be10d999c56cfe9aedbba
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: remove unused method signature from VdsServerConnector
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: remove unused method signature from VdsServerConnector
......................................................................
core: remove unused method signature from VdsServerConnector
Remove unused registerSecrets method signature from VdsServerConnector.
Change-Id: I22e6340f1e17412c19a54ff93b6c5d42999c0dc8
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43598
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22e6340f1e17412c19a54ff93b6c5d42999c0dc8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months