August 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: remove unused field

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: remove unused field ...................................................................... webadmin: remove unused field Remove unused field. Change-Id: Ic30d597569c461cf86196c6ec5fd0ba602eec06d Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic30d597569c461cf86196c6ec5fd0ba602eec06d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: backend: Small refactoring of VM status-based canDoActions

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Small refactoring of VM status-based canDoActions ...................................................................... backend: Small refactoring of VM status-based canDoActions Extracted common pattern of failing canDoAction with localized current VM status into small helper method of VmCommand base class. Change-Id: I69d4edbf844c9eb83b6a553933b418c3b8030cf7 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FreezeVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetAmountOfMemoryCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetNumberOfCpusCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PauseVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RebootVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ThawVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AbstractVmHostDevicesCommand.java 15 files changed, 20 insertions(+), 35 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69d4edbf844c9eb83b6a553933b418c3b8030cf7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Disable "Manage Networks" on a detached cluster

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disable "Manage Networks" on a detached cluster ...................................................................... webadmin: Disable "Manage Networks" on a detached cluster Disable "Manage Networks" on a detached cluster Change-Id: If85991f22709793128a867a9c9c3952cbd68b3e9 Bug-Url: https://bugzilla.redhat.com/1206891 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45099 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If85991f22709793128a867a9c9c3952cbd68b3e9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: add missing null check for balloon info

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: add missing null check for balloon info ...................................................................... core: add missing null check for balloon info add null check for balloon info as it might be missing on the vm status event. Change-Id: I2dc6100cc2e23b8462212d3df6410837c9c8a4bf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252012 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> (cherry picked from commit 8498db134775904dc00ca4955adc390c41217ddc) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Omer Frenkel: Verified -- To view, visit https://gerrit.ovirt.org/45125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dc6100cc2e23b8462212d3df6410837c9c8a4bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-live[ovirt-live-3.6]: ovirt-live-3.6.0_beta3

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-live-3.6.0_beta3 ...................................................................... ovirt-live-3.6.0_beta3 Change-Id: I1b7b8a7cc90c5a492db6ac989065d8114f02f74f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b7b8a7cc90c5a492db6ac989065d8114f02f74f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: add missing null check for balloon info

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: add missing null check for balloon info ...................................................................... core: add missing null check for balloon info add null check for balloon info as it might be missing on the vm status event. Change-Id: I2dc6100cc2e23b8462212d3df6410837c9c8a4bf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252012 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Omer Frenkel: Verified -- To view, visit https://gerrit.ovirt.org/45109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dc6100cc2e23b8462212d3df6410837c9c8a4bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: incorrect tooltip of pooled VMs

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: incorrect tooltip of pooled VMs ...................................................................... webadmin: incorrect tooltip of pooled VMs Fixed by handling the pooled VMs separately from the non pooled ones (same as for icons). Change-Id: I55c47ec8105651d4614c6dfedd0f3af3b0127680 Bug-Url: https://bugzilla.redhat.com/1193144 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmTypeColumn.java 2 files changed, 28 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55c47ec8105651d4614c6dfedd0f3af3b0127680 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal, webadmin: enter handler not always removed

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: enter handler not always removed ...................................................................... userportal,webadmin: enter handler not always removed In some cases the onFocus has been called more than once causing that the onBlur have unregistered only one. Change-Id: I9f5b07cf15c657cc3cc9ee9036d378e9c479eac2 Bug-Url: https://bugzilla.redhat.com/1242852 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f5b07cf15c657cc3cc9ee9036d378e9c479eac2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: edit pool dialog not load when the DC is not up

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: edit pool dialog not load when the DC is not up ...................................................................... webadmin: edit pool dialog not load when the DC is not up The problem was that the PoolListModel started the progress by directly calling startProgress() wich is not good - it has to be handled by the infrastructure (e.g. AbstractModelBoundPopupPresenterWidget is handling the start/stop progress according to the AsyncOperation[Started/Completed]Event. Other fix needed was a null check on the spiceProxyEnabled since the model is not inited completely when the DC is not active. Change-Id: I8177155885dfb4c64785b905db614bc6b4ffe44a Bug-Url: https://bugzilla.redhat.com/1245599 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45090 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8177155885dfb4c64785b905db614bc6b4ffe44a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: frontend: check the num of IO Threads

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: frontend: check the num of IO Threads ...................................................................... frontend: check the num of IO Threads Make sure the num of IO Threads configured per VM will not exceed the configured value (127) Change-Id: I9fde31bb94e11ff496e1177775caed1346899b44 Bug-Url: https://bugzilla.redhat.com/1251899 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fde31bb94e11ff496e1177775caed1346899b44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits August 2015