August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: Allow ':' in VmInit network name
by tjelinek＠redhat.com 19 Aug '15

19 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Allow ':' in VmInit network name ...................................................................... frontend: Allow ':' in VmInit network name Created new VmInitNetworkNameValidation that adds support for ':' character in addition to those supported by AsciiNameValidation. Also fixed issue regarding highlighting the first run tab on invalid data. Problem was in usage of the old name for the tab (FIRST_RUN) and incorrectly using the new one (INITIAL_RUN_TAB). Change-Id: I8691dec2d9cc5ff645e2b18a73f0f1a8cd118bf3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248975 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TabName.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/VmInitNetworkNameValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 5 files changed, 22 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/45037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8691dec2d9cc5ff645e2b18a73f0f1a8cd118bf3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: build: ovirt-live-3.5.4_rc2
by sbonazzo＠redhat.com 19 Aug '15

19 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.5.4_rc2 ...................................................................... build: ovirt-live-3.5.4_rc2 Change-Id: Ibc10eebf34688e89960f676eb57dc6c285630207 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc10eebf34688e89960f676eb57dc6c285630207 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[sdk_3.6]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 19 Aug '15

19 Aug '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 872da4c. Change-Id: Iecfb26aceadf7e2159fd3f0f910f991315e89d4c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/resources/api.xsd M generator/src/main/resources/rsdl.xml M sdk/Makefile M sdk/src/main/java/org/ovirt/engine/sdk/decorators/Host.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostHostNICNetworkAttachment.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostHostNICNetworkAttachments.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostNIC.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostNetworkAttachment.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostNetworkAttachments.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostStorageConnectionExtension.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostStorageConnectionExtensions.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostUnmanagedNetwork.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostUnmanagedNetworks.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/InstanceType.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/InstanceTypeGraphicsConsole.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/InstanceTypeGraphicsConsoles.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomain.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/Template.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/TemplateGraphicsConsole.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/TemplateGraphicsConsoles.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/VM.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/VMGraphicsConsole.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/VMGraphicsConsoles.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/Action.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/BaseResource.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/BaseResources.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/GraphicsConsole.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/Host.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/IpAddressAssignment.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/IpAddressAssignments.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/NetworkAttachment.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/NetworkAttachments.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/ProxyTicket.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/ReportedConfiguration.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/ReportedConfigurations.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/StorageConnectionExtension.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/StorageConnectionExtensions.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/UnmanagedNetwork.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/UnmanagedNetworks.java 40 files changed, 7,076 insertions(+), 122 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecfb26aceadf7e2159fd3f0f910f991315e89d4c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.6]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 19 Aug '15

19 Aug '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 872da4c. Change-Id: Id76b985c37a7d8a74ab92a7b7fed6e119bca6647 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M generator/src/main/resources/api.xsd M generator/src/main/resources/rsdl.xml M setup.py M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 7 files changed, 3,999 insertions(+), 30 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id76b985c37a7d8a74ab92a7b7fed6e119bca6647 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: check the num of IO Threads
by tjelinek＠redhat.com 19 Aug '15

19 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: check the num of IO Threads ...................................................................... frontend: check the num of IO Threads Make sure the num of IO Threads configured per VM will not exceed the configured value (127) Change-Id: I9fde31bb94e11ff496e1177775caed1346899b44 Bug-Url: https://bugzilla.redhat.com/1251899 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fde31bb94e11ff496e1177775caed1346899b44 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Faster JAXB element creation
by tnisan＠redhat.com 19 Aug '15

19 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Faster JAXB element creation ...................................................................... restapi: Faster JAXB element creation Currently when we need to create a JAXB element we always iterate the object factory looking for the appropiate method. To improve the performance of this lookup this patch introduces an index that is created during startup so that the iteration is done only once. Change-Id: Ie6f2cc91701ff45a443d3b8b37e8225d7b26c4fa Bug-Url: https://bugzilla.redhat.com/1250140 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit d078c564be5e1a620850259571052a76052aaed8) --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/xml/JAXBProvider.java 1 file changed, 19 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Passed CI tests Ori Liel: Looks good to me, approved Juan Hernandez: Verified -- To view, visit https://gerrit.ovirt.org/44933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6f2cc91701ff45a443d3b8b37e8225d7b26c4fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: JAXB provider
by tnisan＠redhat.com 19 Aug '15

19 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: JAXB provider ...................................................................... restapi: JAXB provider Currently we use a custom message body reader to parse XML input documents, and we use the default message body writer to generate XML documents. This patch converts the custom message body reader into a provider that acts as both reader and writer. This reduces the number of JAXB contexts created and will simplify removing some dependencies on Resteasy. Change-Id: I5208c9d41ab892f55c85ef095f25648f1a95d8df Bug-Url: https://bugzilla.redhat.com/1250140 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 8c488a8195e797f55fad7bce9fb8bcbd7818ab12) --- R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/xml/JAXBProvider.java M backend/manager/modules/restapi/interface/definition/src/main/modules/org/ovirt/engine/api/restapi-definition/main/module.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/META-INF/services/javax.ws.rs.ext.Providers 3 files changed, 79 insertions(+), 8 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44932 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5208c9d41ab892f55c85ef095f25648f1a95d8df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Add @Provides to watchdogs resource
by tnisan＠redhat.com 19 Aug '15

19 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add @Provides to watchdogs resource ...................................................................... restapi: Add @Provides to watchdogs resource Currently the watchdogs resource doesn't have a @Provides annotation. In theory this shouldn't be required as the annotation is in the base class. But in practice the application server reacts differently, in particular if the annotation isn't present the server won't use use the JAXB or JSON providers when the "Accept" header doesn't have a value. This means that requests like this: DELETE /vms/{vm:id}/watchdogs/{watchdog:id} Will fail with the following error message: Could not find MessageBodyWriter for response object of type: org.ovirt.engine.api.model.Action of media type: application/octet-stream This specific problem can be resolved adding the "Accept" header to the request, and that is good practice. For backwards compatibility sake this patch adds the annotation. Change-Id: I1bcb6263450be603b21e398196c6713ad599ce25 Bug-Url: https://bugzilla.redhat.com/1250046 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e494a557b00d6a4028fed172fb3ad1d8e276733a) --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/WatchdogResource.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bcb6263450be603b21e398196c6713ad599ce25 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: check the num of IO Threads
by tjelinek＠redhat.com 19 Aug '15

19 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: check the num of IO Threads ...................................................................... core: check the num of IO Threads Make sure the num of IO Threads configured per VM will not exceed the configured value (127) Change-Id: Ia84563f170c080cbdf2078505df14eab8b80e3aa Bug-Url: https://bugzilla.redhat.com/1251899 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/SizeFromConfigValueValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/SizeFromConfigValue.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 14 files changed, 104 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia84563f170c080cbdf2078505df14eab8b80e3aa Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: ha: removing wrong _self attribute access on gluster code
by sbonazzo＠redhat.com 19 Aug '15

19 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ha: removing wrong _self attribute access on gluster code ...................................................................... ha: removing wrong _self attribute access on gluster code removing a wrong access to a not existing _self attribute on gluster specific code. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254745 Change-Id: I4820b2664def8c329e3ced31c929d9fa6e41bc6b Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_server.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4820b2664def8c329e3ced31c929d9fa6e41bc6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0