August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: check the num of IO Threads
by tnisan＠redhat.com 20 Aug '15

20 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: check the num of IO Threads ...................................................................... core: check the num of IO Threads Make sure the num of IO Threads configured per VM will not exceed the configured value (127) Change-Id: Ia84563f170c080cbdf2078505df14eab8b80e3aa Bug-Url: https://bugzilla.redhat.com/1251899 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/SizeFromConfigValueValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/SizeFromConfigValue.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 14 files changed, 104 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Tal Nisan: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia84563f170c080cbdf2078505df14eab8b80e3aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: NPE if memory size is not set
by tnisan＠redhat.com 20 Aug '15

20 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: NPE if memory size is not set ...................................................................... webadmin: NPE if memory size is not set Problem was that even the MemorySizeParser have handled the situation correctly and returned 0, the ValueBoxBase.getValueOrThrow have overridden it to null. Fixed by creating a custom MemorySizeEntityModelTextBox which always returns the value from the parser. Change-Id: I0a5113a42614572e1f3f10855610b8a5ff1756b4 Bug-Url: https://bugzilla.redhat.com/1252857 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/MemorySizeEntityModelTextBox.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/MemorySizeEntityModelTextBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 3 files changed, 46 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a5113a42614572e1f3f10855610b8a5ff1756b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: NPE on edit pool dialog
by tnisan＠redhat.com 20 Aug '15

20 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: NPE on edit pool dialog ...................................................................... webadmin: NPE on edit pool dialog It has to be only in the templateWithVersion_SelectedItemChanged since the rest of the code is dependant on the selected template Change-Id: Ib16f40490ad7256e7f2e25c63283425eb2c2ae06 Bug-Url: https://bugzilla.redhat.com/1253258 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib16f40490ad7256e7f2e25c63283425eb2c2ae06 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fixes breakage of master
by awels＠redhat.com 19 Aug '15

19 Aug '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixes breakage of master ...................................................................... webadmin: fixes breakage of master - Fixes broken method call due to now obsolete parameter. Change-Id: I5af219b919e7830d14969d9a0a96aeef25748d7e Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ErrataListWithDetailsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ErrataTableView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Alexander Wels: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45110 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5af219b919e7830d14969d9a0a96aeef25748d7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: reports-tool: Tell to restart the service
by ydary＠redhat.com 19 Aug '15

19 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: reports-tool: Tell to restart the service ...................................................................... packaging: reports-tool: Tell to restart the service Admin password change requires restarting the reports service to make the change effective. Change-Id: I02482f933b52236b2f5d80718b124a952b570483 Bug-Url: https://bugzilla.redhat.com/1232822 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/jasper/change_admin_password.py 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02482f933b52236b2f5d80718b124a952b570483 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: proposing socat instead of virsh
by sbonazzo＠redhat.com 19 Aug '15

19 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: proposing socat instead of virsh ...................................................................... packaging: setup: proposing socat instead of virsh In the past we proposed to connect to the VM via remote-viewer or virsh for who just want to use a text only client. virsh requires authentication as vdsm@ovirt user, but the console is also available over a unix domain socket. Proposing the user to use socat to connect to that. Bug-Url: https://bugzilla.redhat.com/1215436 Change-Id: I5abc8ce5ff048b96a456fdecdb300848e063383c Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44702 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5abc8ce5ff048b96a456fdecdb300848e063383c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: added permissions needed to change cluster only when c...
by tnisan＠redhat.com 19 Aug '15

19 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: added permissions needed to change cluster only when changing the cluster ...................................................................... core: added permissions needed to change cluster only when changing the cluster Since the backend can not trust that the TargetVdsGroupId is sent only when actually needed, added a check which makes sure to expect the permissions only when really needed. Change-Id: I3d4b78b271ea58fceed6a15228d7b5f98c14508c Bug-Url: https://bugzilla.redhat.com/1255061 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d4b78b271ea58fceed6a15228d7b5f98c14508c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: proposing socat instead of virsh
by sbonazzo＠redhat.com 19 Aug '15

19 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: proposing socat instead of virsh ...................................................................... packaging: setup: proposing socat instead of virsh In the past we proposed to connect to the VM via remote-viewer or virsh for who just want to use a text only client. virsh requires authentication as vdsm@ovirt user, but the console is also available over a unix domain socket. Proposing the user to use socat to connect to that. Bug-Url: https://bugzilla.redhat.com/1215436 Change-Id: I5abc8ce5ff048b96a456fdecdb300848e063383c Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5abc8ce5ff048b96a456fdecdb300848e063383c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: display unreinstallable packages
by tnisan＠redhat.com 19 Aug '15

19 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: display unreinstallable packages ...................................................................... packaging: setup: display unreinstallable packages When prompting about whether to upgrade even if some packages cannot be reinstalled if upgrade fails and we need to rollback, show the list of these packages. Change-Id: Ia9b3885f0919f96706cc2ec85979889f5cecb784 Related-To: https://bugzilla.redhat.com/1100201 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Lev Veyde <lveyde(a)redhat.com> (cherry picked from commit 225ebd4d5529fba40d95dc6074971cf07d487283) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 1 file changed, 15 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9b3885f0919f96706cc2ec85979889f5cecb784 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix LUN ID checkbox in new iscsi domain window
by derez＠redhat.com 19 Aug '15

19 Aug '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix LUN ID checkbox in new iscsi domain window ...................................................................... webadmin: fix LUN ID checkbox in new iscsi domain window This patch fixes a regression in the Luns to Targets view in the New iscsi Domain window. The regression was caused by the addition of an else statement in lunModelSelectedItemListener which raised an event that canceled the user's selection when clicking on the LUN ID checkbox. Change-Id: I9a43be0d9e33149666408cfcd92f625fe5ff9838 Bug-Url: https://bugzilla.redhat.com/1215416 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java 1 file changed, 10 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/45011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a43be0d9e33149666408cfcd92f625fe5ff9838 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0