Change in ovirt-live[ovirt-live-3.6]: nit: fix pep8
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: nit: fix pep8
......................................................................
nit: fix pep8
Change-Id: I5f21dd20496de6a039f95bff707a8911b1c3a352
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 50a6b4eefc86da7f70f130687842842e826e56c0)
---
M centos-7/oVirtLiveFiles/root/usr/libexec/vdsm/hooks/before_vdsm_start/20-setupBridge.py
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45060
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f21dd20496de6a039f95bff707a8911b1c3a352
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-live[master]: nit: fix pep8
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: nit: fix pep8
......................................................................
nit: fix pep8
Change-Id: I5f21dd20496de6a039f95bff707a8911b1c3a352
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/oVirtLiveFiles/root/usr/libexec/vdsm/hooks/before_vdsm_start/20-setupBridge.py
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45059
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f21dd20496de6a039f95bff707a8911b1c3a352
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-live[ovirt-live-3.6]: centos7: Fix the code for AAA
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos7: Fix the code for AAA
......................................................................
centos7: Fix the code for AAA
Modify the ovirt-live plugin to reflect the AAA related code
changes in ovirt-engine.
Change-Id: I67740bbe37be7ba856d62e5b2c1901967f46b5c3
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1222566
(cherry picked from commit b9a9d7085d2bd6e58ee8ffcdef5eea90bd9b7f67)
---
M centos-7/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Lev Veyde: Verified
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45043
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67740bbe37be7ba856d62e5b2c1901967f46b5c3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-live[ovirt-live-3.6]: centos7: add new bridge setup script
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos7: add new bridge setup script
......................................................................
centos7: add new bridge setup script
A new script was added to properly setup the bridge
Change-Id: I8dc802a93b7ec871969e89a5ee96fc199014db30
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1222566
---
A centos-7/oVirtLiveFiles/root/usr/libexec/vdsm/hooks/before_vdsm_start/20-setupBridge.py
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Lev Veyde: Verified
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45044
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dc802a93b7ec871969e89a5ee96fc199014db30
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: added missing constructor to RetrieveImageDataCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: added missing constructor to RetrieveImageDataCommand
......................................................................
core: added missing constructor to RetrieveImageDataCommand
Change-Id: I32f3342c6ddda38d404179abd677bbb8c1083e4a
Bug-Url: https://bugzilla.redhat.com/1254629
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45032
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32f3342c6ddda38d404179abd677bbb8c1083e4a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: added missing constructor to RetrieveImageDataCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: added missing constructor to RetrieveImageDataCommand
......................................................................
core: added missing constructor to RetrieveImageDataCommand
Change-Id: I32f3342c6ddda38d404179abd677bbb8c1083e4a
Bug-Url: https://bugzilla.redhat.com/1213850
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45031
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32f3342c6ddda38d404179abd677bbb8c1083e4a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: ignore dash in locale name
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: ignore dash in locale name
......................................................................
packaging: setup: ignore dash in locale name
newer fedora has no dashes and older has... a mess.
add debug statement for future ease of support.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254533
Change-Id: I4b69dea0c86fab1a0104ed49ba9caca58513d23b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/database.py
1 file changed, 16 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45015
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b69dea0c86fab1a0104ed49ba9caca58513d23b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: frontend: Fix typo in BaseEntityModelDetachableWidget
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Fix typo in BaseEntityModelDetachableWidget
......................................................................
frontend: Fix typo in BaseEntityModelDetachableWidget
s/Fields is/Field is/
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1244085
Change-Id: Icda0c8860cb7550392e0c3b74bf08ace6ee06385
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/45014
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icda0c8860cb7550392e0c3b74bf08ace6ee06385
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix the cardinality storage connection extensions
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Fix the cardinality storage connection extensions
......................................................................
restapi: Fix the cardinality storage connection extensions
Currently the storage connection extensions element of the host entity
is declared in the XML schema with an unbounded upper limit. This means
that the corresponding Java method generated by the XJC compiler will
return a list of elements:
List<StorageConnectionExtensions> getStorageConnectionExtensions() {
...
}
This is incorrect and it causes an issue in the generator of the Java
SDK, as the code generator assumes that this kind of attribute will have
a getter that returns only one element:
HostStorageConnectionExtensions getStorageConnectionExtensions() {
...
}
The net result is a compilation problem in the generated SDK.
To avoid this issue this patch fixes the XML schema for this element so
that the upper limit is 1 instead of unbounded.
Change-Id: I7f64d74ddc31d5f2634855e31548fa0342e7a281
Bug-Url: https://bugzilla.redhat.com/1254295
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit f41f2b1608bd095d27a2ec71f1479cdd4d71e4c6)
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45024
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f64d74ddc31d5f2634855e31548fa0342e7a281
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: VM network selection dropdown
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: VM network selection dropdown
......................................................................
webadmin: VM network selection dropdown
- My attempt to fix the selection dropdown before broke
a bunch of other subtabs, so this patch reverts that
change.
- Changed the width of the container so that the dropdown
doesn't wrap to the next line and half disappears.
Change-Id: Ibb68606ee99fc0fd8920f3e4b2fa469c88daedca
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254179
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/instanceimages/InstanceImageLineEditor.ui.xml
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Alexander Wels: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb68606ee99fc0fd8920f3e4b2fa469c88daedca
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month