August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: packaging: Require version 3.6 of the CLI
by tnisan＠redhat.com 18 Aug '15

18 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: Require version 3.6 of the CLI ...................................................................... packaging: Require version 3.6 of the CLI Currently the engine .spec file requires the CLI package, but it doesn't require a explicit version. As a result the CLI won't be updated when the engine is updated. This isn't a big issue, but may be an inconvenience for users that expect the latest version of the CLI. This patch updates the .spec of the engine so that it requires version 3.6.0.0 or newer of the CLI. Change-Id: Iebdc684e9ad33faa6fdf89984eef4dc6f693e5e1 Bug-Url: https://bugzilla.redhat.com/1252073 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 798118e811bc72e80ef0b84187ca5405763116e1) --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebdc684e9ad33faa6fdf89984eef4dc6f693e5e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: centos7: add new bridge setup script
by sbonazzo＠redhat.com 18 Aug '15

18 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: centos7: add new bridge setup script ...................................................................... centos7: add new bridge setup script A new script was added to properly setup the bridge Change-Id: I8dc802a93b7ec871969e89a5ee96fc199014db30 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1222566 --- A centos-7/oVirtLiveFiles/root/usr/libexec/vdsm/hooks/before_vdsm_start/20-setupBridge.py 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dc802a93b7ec871969e89a5ee96fc199014db30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: centos7: Fix the code for AAA
by sbonazzo＠redhat.com 18 Aug '15

18 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: centos7: Fix the code for AAA ...................................................................... centos7: Fix the code for AAA Modify the ovirt-live plugin to reflect the AAA related code changes in ovirt-engine. Change-Id: I67740bbe37be7ba856d62e5b2c1901967f46b5c3 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1222566 --- M centos-7/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67740bbe37be7ba856d62e5b2c1901967f46b5c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: added missing constructor to RetrieveImageDataCommand
by tnisan＠redhat.com 18 Aug '15

18 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: added missing constructor to RetrieveImageDataCommand ...................................................................... core: added missing constructor to RetrieveImageDataCommand Change-Id: I32f3342c6ddda38d404179abd677bbb8c1083e4a Bug-Url: https://bugzilla.redhat.com/1213850 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/45030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32f3342c6ddda38d404179abd677bbb8c1083e4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: incorrect tooltip of pooled VMs
by tjelinek＠redhat.com 18 Aug '15

18 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: incorrect tooltip of pooled VMs ...................................................................... webadmin: incorrect tooltip of pooled VMs Fixed by handling the pooled VMs separately from the non pooled ones (same as for icons). Change-Id: I55c47ec8105651d4614c6dfedd0f3af3b0127680 Bug-Url: https://bugzilla.redhat.com/1193144 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmTypeColumn.java 2 files changed, 28 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55c47ec8105651d4614c6dfedd0f3af3b0127680 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Adding ovirt-guest-agent build-artifacts
by sbonazzo＠redhat.com 18 Aug '15

18 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Adding ovirt-guest-agent build-artifacts ...................................................................... Adding ovirt-guest-agent build-artifacts * Creating the jobs * Added to publisher Change-Id: I6d56b3df67c0dbcf9c199715d4f7996264723d4b Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/ovirt-guest-agent/ovirt-guest-agent_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 2 files changed, 22 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/45029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d56b3df67c0dbcf9c199715d4f7996264723d4b Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in jenkins[master]: ioprocess: Add python3-devel to extra packages
by dcaroest＠redhat.com 18 Aug '15

18 Aug '15

David Caro has submitted this change and it was merged. Change subject: ioprocess: Add python3-devel to extra packages ...................................................................... ioprocess: Add python3-devel to extra packages Change-Id: Iaa6afd9041b1b754a0bf2113bfacf902ccb5350c Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com> --- M jobs/confs/projects/ioprocess/ioprocess_create-rpms.yaml 1 file changed, 27 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/44485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa6afd9041b1b754a0bf2113bfacf902ccb5350c Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Test added for Template's disk removal in RemoveDiskCo...
by amureini＠redhat.com 18 Aug '15

18 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Test added for Template's disk removal in RemoveDiskCommandTest. ...................................................................... core: Test added for Template's disk removal in RemoveDiskCommandTest. A missing test added to verify correctness in removing a template's disk. Change-Id: Ib6fe61061f7e1e0dc0c46ad889743dd3a1fdd43d Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java 2 files changed, 34 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6fe61061f7e1e0dc0c46ad889743dd3a1fdd43d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix the cardinality storage connection extensions
by juan.hernandez＠redhat.com 18 Aug '15

18 Aug '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix the cardinality storage connection extensions ...................................................................... restapi: Fix the cardinality storage connection extensions Currently the storage connection extensions element of the host entity is declared in the XML schema with an unbounded upper limit. This means that the corresponding Java method generated by the XJC compiler will return a list of elements: List<StorageConnectionExtensions> getStorageConnectionExtensions() { ... } This is incorrect and it causes an issue in the generator of the Java SDK, as the code generator assumes that this kind of attribute will have a getter that returns only one element: HostStorageConnectionExtensions getStorageConnectionExtensions() { ... } The net result is a compilation problem in the generated SDK. To avoid this issue this patch fixes the XML schema for this element so that the upper limit is 1 instead of unbounded. Change-Id: I7f64d74ddc31d5f2634855e31548fa0342e7a281 Bug-Url: https://bugzilla.redhat.com/1254295 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified; Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f64d74ddc31d5f2634855e31548fa0342e7a281 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: VM network selection dropdown
by awels＠redhat.com 18 Aug '15

18 Aug '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: VM network selection dropdown ...................................................................... webadmin: VM network selection dropdown - My attempt to fix the selection dropdown before broke a bunch of other subtabs, so this patch reverts that change. - Changed the width of the container so that the dropdown doesn't wrap to the next line and half disappears. Change-Id: Ibb68606ee99fc0fd8920f3e4b2fa469c88daedca Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/instanceimages/InstanceImageLineEditor.ui.xml 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Alexander Wels: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb68606ee99fc0fd8920f3e4b2fa469c88daedca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0