Change in ovirt-engine[ovirt-engine-3.5.4]: build: ovirt-engine-3.5.4.2
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: build: ovirt-engine-3.5.4.2
......................................................................
build: ovirt-engine-3.5.4.2
Change-Id: Ie40641c291100b81e38c6d442225e51e9ad7fef7
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine.spec.in
M version.mak
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45004
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie40641c291100b81e38c6d442225e51e9ad7fef7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5.4]: packaging: setup: pki fix breakage introduced by Idca016
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: pki fix breakage introduced by Idca016
......................................................................
packaging: setup: pki fix breakage introduced by Idca016
conditional renew should be only for RENEW!
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1214860
Change-Id: Ica6680f5d8feae3cc9a2b4782c2adbd993f77d17
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 22 insertions(+), 22 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Tal Nisan: Passed CI tests
Sandro Bonazzola: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45002
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica6680f5d8feae3cc9a2b4782c2adbd993f77d17
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5.4]: pki: ca: enforce utf-8 subject
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: pki: ca: enforce utf-8 subject
......................................................................
pki: ca: enforce utf-8 subject
Yet another legacy issue. By default openssl ca use ANSI and not UTF-8
to encode subject name.
The result is UTF8STRING in both cases, but the actual character
encoding differs.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1246494
Change-Id: I3ea89735e0bdb3c61faa91ed813a3b8b8a25028c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/pki-create-ca.sh
M packaging/bin/pki-enroll-request.sh
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Tal Nisan: Passed CI tests
Sandro Bonazzola: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ea89735e0bdb3c61faa91ed813a3b8b8a25028c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: NPE if memory size is not set
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: NPE if memory size is not set
......................................................................
webadmin: NPE if memory size is not set
Problem was that even the MemorySizeParser have handled the situation correctly
and returned 0, the ValueBoxBase.getValueOrThrow have overridden it to null.
Fixed by creating a custom MemorySizeEntityModelTextBox which always returns
the value from the parser.
Change-Id: I0a5113a42614572e1f3f10855610b8a5ff1756b4
Bug-Url: https://bugzilla.redhat.com/1252857
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/MemorySizeEntityModelTextBox.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/MemorySizeEntityModelTextBoxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
3 files changed, 46 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5113a42614572e1f3f10855610b8a5ff1756b4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: scroll bars are not shown in dialogs
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: scroll bars are not shown in dialogs
......................................................................
webadmin: scroll bars are not shown in dialogs
This regression has been introduced in 93e0adc
Change-Id: Ia40e2021afd685c4f434533e8eeef6f19c8727d2
Bug-Url: https://bugzilla.redhat.com/1254179
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44912
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia40e2021afd685c4f434533e8eeef6f19c8727d2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: packaging: setup: ignore dash in locale name
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: ignore dash in locale name
......................................................................
packaging: setup: ignore dash in locale name
newer fedora has no dashes and older has... a mess.
add debug statement for future ease of support.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254533
Change-Id: I4b69dea0c86fab1a0104ed49ba9caca58513d23b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/database.py
1 file changed, 16 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/45009
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b69dea0c86fab1a0104ed49ba9caca58513d23b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: frontend: Fix typo in BaseEntityModelDetachableWidget
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Fix typo in BaseEntityModelDetachableWidget
......................................................................
frontend: Fix typo in BaseEntityModelDetachableWidget
s/Fields is/Field is/
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1244085
Change-Id: Icda0c8860cb7550392e0c3b74bf08ace6ee06385
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/45012
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icda0c8860cb7550392e0c3b74bf08ace6ee06385
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: userportal, webadmin: enter handler not always removed
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: enter handler not always removed
......................................................................
userportal,webadmin: enter handler not always removed
In some cases the onFocus has been called more than once causing that the
onBlur have unregistered only one.
Change-Id: I9f5b07cf15c657cc3cc9ee9036d378e9c479eac2
Bug-Url: https://bugzilla.redhat.com/1242852
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44899
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f5b07cf15c657cc3cc9ee9036d378e9c479eac2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: restapi: missing validation for cloneVmFromSnapshot
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: missing validation for cloneVmFromSnapshot
......................................................................
restapi: missing validation for cloneVmFromSnapshot
snapshot.id was not validated to be present.
Change-Id: I6276794a0566e376c14f5d21c9634dfb37f95bf6
Bug-Url: https://bugzilla.redhat.com/1238273
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Jenkins CI: Passed CI tests
Vered Volansky: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44315
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6276794a0566e376c14f5d21c9634dfb37f95bf6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernández
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-guest-agent[master]: automation: add automated rpm build
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: automation: add automated rpm build
......................................................................
automation: add automated rpm build
Also fixed spec file causing build failures.
Skipping rpmbuild for el7
Change-Id: I79a23c5add645dfccc386406d9ee0126596f5b63
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
A automation/README.md
A automation/build-artifacts.packages
A automation/build-artifacts.repos
A automation/build-artifacts.sh
M ovirt-guest-agent-windows.spec
M ovirt-guest-agent.rhel6.spec
M ovirt-guest-agent.spec
7 files changed, 68 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Looks good to me, approved
David Caro: Verified
--
To view, visit https://gerrit.ovirt.org/44376
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79a23c5add645dfccc386406d9ee0126596f5b63
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months