August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix of NPE in DedicatedVmForVdsUnitToVmBaseBuilder
by tjelinek＠redhat.com 17 Aug '15

17 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix of NPE in DedicatedVmForVdsUnitToVmBaseBuilder ...................................................................... webadmin: Fix of NPE in DedicatedVmForVdsUnitToVmBaseBuilder UnitVmModel#defaultHost was (not completely) refactored to allow selection of multiple hosts to pin to. VmModelBehaviorBase#updateDefaultHost() still worked with ListModel#selectedItem instead of #selectedItems. This caused NPE in DedicatedVmForVdsUnitToVmBaseBuilder. Change-Id: I36d73f5b301e71b0baf09c4bcef1d20a7379fed8 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1247932 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/TakesConstrainedValueListEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 17 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d73f5b301e71b0baf09c4bcef1d20a7379fed8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: sync storage devices as part of installing host
by sabose＠redhat.com 17 Aug '15

17 Aug '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: sync storage devices as part of installing host ...................................................................... gluster: sync storage devices as part of installing host Sync all the storage devices in the gluster host while installing/adding the host to engine. Change-Id: I236b4fb1cb325f83e428db0bbd372e32e485e0d0 Bug-Url: https://bugzilla.redhat.com/1230348 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/SyncGlusterStorageDevicesParameter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java 4 files changed, 55 insertions(+), 6 deletions(-) Approvals: Sahina Bose: Looks good to me, approved; Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/44897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I236b4fb1cb325f83e428db0bbd372e32e485e0d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: cleanup: removed unused code
by tnisan＠redhat.com 17 Aug '15

17 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: cleanup: removed unused code ...................................................................... cleanup: removed unused code Removed unused code from StorageModel and StorageListModel Change-Id: I8f26225c9615d66dfff92b02aefbc6a694687668 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 2 files changed, 2 insertions(+), 20 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/44192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f26225c9615d66dfff92b02aefbc6a694687668 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: cleanup: removed accessor from data members names in some cl...
by tnisan＠redhat.com 17 Aug '15

17 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: cleanup: removed accessor from data members names in some classes ...................................................................... cleanup: removed accessor from data members names in some classes Change-Id: I5f82bd8e5935ed662b6884cf6789e8add6b7d2ec Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 2 files changed, 33 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/44188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f82bd8e5935ed662b6884cf6789e8add6b7d2ec Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: avoid cleaning up SP if was not created by me
by sbonazzo＠redhat.com 17 Aug '15

17 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid cleaning up SP if was not created by me ...................................................................... packaging: setup: avoid cleaning up SP if was not created by me Avoid trying to clening up the SP if was not created by me. Change-Id: Ia06320a9904c52021d6f7c81916600faeaa77226 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia06320a9904c52021d6f7c81916600faeaa77226 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: remove obsoleted restapi URI
by sbonazzo＠redhat.com 17 Aug '15

17 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: remove obsoleted restapi URI ...................................................................... packaging: remove obsoleted restapi URI Change-Id: Iea6aa360bb13e45a0f7e4124c191873649e47fe1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in M packaging/conf/ovirt-engine-proxy.conf.v2.in M packaging/services/ovirt-engine/ovirt-engine.conf.in 4 files changed, 3 insertions(+), 14 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea6aa360bb13e45a0f7e4124c191873649e47fe1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: sync storage devices as part of installing host
by sabose＠redhat.com 17 Aug '15

17 Aug '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: sync storage devices as part of installing host ...................................................................... gluster: sync storage devices as part of installing host Sync all the storage devices in the gluster host while installing/adding the host to engine. Change-Id: I236b4fb1cb325f83e428db0bbd372e32e485e0d0 Bug-Url: https://bugzilla.redhat.com/1230348 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/SyncGlusterStorageDevicesParameter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java 4 files changed, 55 insertions(+), 6 deletions(-) Approvals: Sahina Bose: Looks good to me, approved; Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/44222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I236b4fb1cb325f83e428db0bbd372e32e485e0d0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix the response-key of changeFloppy
by ahadas＠redhat.com 16 Aug '15

16 Aug '15

Arik Hadas has submitted this change and it was merged. Change subject: core: fix the response-key of changeFloppy ...................................................................... core: fix the response-key of changeFloppy VDSM uses 'vmList' as a key for the response it sends to the engine. However, the engine uses 'status' as a key instead. Currently, there is no way to change floppy so this bug is unnoticed, but it is still better to fix it. Change-Id: I6369c551805614741863fc145cc7cce34ad6856d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6369c551805614741863fc145cc7cce34ad6856d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: translate vm graphic settings in specParams
by tnisan＠redhat.com 16 Aug '15

16 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: translate vm graphic settings in specParams ...................................................................... core: translate vm graphic settings in specParams When Engine is sending the new-style graphic devices, VDSM expects the parameters 'fileTransferEnable' and 'copyPasteEnable' to be sent into the device specParams. The backward compatibility on VDSM side works when graphics devices aren't specified, and in this case and in this case only the vm-level parameters are considered. Until the UI settings will change directly the per-device specParams, the best way forward is to translate the per-vm settings into per-device specParams (format and naming is the same). Bug-Url: https://bugzilla.redhat.com/983019 Change-Id: I960bdee2f0828bd3e34f2e2ba8c169b8b83c8d9a Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 2 files changed, 48 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44815 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I960bdee2f0828bd3e34f2e2ba8c169b8b83c8d9a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: host-deploy: remove timestamp cache check for tarball
by tnisan＠redhat.com 16 Aug '15

16 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: host-deploy: remove timestamp cache check for tarball ...................................................................... host-deploy: remove timestamp cache check for tarball when multiple packages manage the directory tree, the last file timestamp cannot be used as reference to cache integrity as an older package may be applied after newer one. we could have used hash mechanism, but then we had to read files once per hash and once per creation, so better to just create the tarball at designated interval. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252364 Change-Id: I97fa20e0f5205ebddb6aff1cbfebf3f2879fa34e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/CachedTar.java 1 file changed, 4 insertions(+), 49 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97fa20e0f5205ebddb6aff1cbfebf3f2879fa34e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0