August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: "doesn't not" -> "does not"
by ecohen＠redhat.com 13 Aug '15

13 Aug '15

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: "doesn't not" -> "does not" ...................................................................... webadmin: "doesn't not" -> "does not" Change-Id: If7ef35fccafd182e36d45804b9c8282ca0c2d057 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1253099 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Einav Cohen: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7ef35fccafd182e36d45804b9c8282ca0c2d057 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove legacy ldap tests
by amureini＠redhat.com 13 Aug '15

13 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove legacy ldap tests ...................................................................... core: Remove legacy ldap tests Patch b39cd0f2f9af4adbfe7baeef25c6930d0bc2d4d1 commented out DirectoryGroupSearchQueryTest and DirectoryUserSearchQueryTest over a year ago. By now it's clear that these tests will never be revisited, and keeping them as commented out code has no value. This patch finishes the job and removes them. Change-Id: Ic825f80e6bbc276e641cd6c3832ffba1c66b073f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DirectoryGroupSearchQueryTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DirectoryUserSearchQueryTest.java 2 files changed, 0 insertions(+), 72 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic825f80e6bbc276e641cd6c3832ffba1c66b073f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Allow VM disks editing after enabling quota on data ce...
by rgolan＠redhat.com 13 Aug '15

13 Aug '15

Roy Golan has submitted this change and it was merged. Change subject: core: Allow VM disks editing after enabling quota on data center ...................................................................... core: Allow VM disks editing after enabling quota on data center Diagnostics: ------------ After enabling quota on data center. The recent quota id for a disk (in the database) is null. And the current quota id from GUI has value (current quota id = the selected quota in the list box). CanDoAction in UpdateVmDiskCommand prevent change to quota id while vm is running (rightfully). Therefore detects quota id change: for existing disks (of type IMAGE or CINDER) after quota is enabled in data center. Short term solution: ------------------- If recent quota id on disk is null always assume there is no change to quota id. Change-Id: I55b571349a366d127a7fc3206888efd59419ad0f Bug-Url: https://bugzilla.redhat.com/1193643 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Dudi Maroshi: Verified Roy Golan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55b571349a366d127a7fc3206888efd59419ad0f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2.5.z]: build: ovirt-hosted-engine-setup-1.2.5.3
by sbonazzo＠redhat.com 13 Aug '15

13 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.2.5.3 ...................................................................... build: ovirt-hosted-engine-setup-1.2.5.3 Change-Id: Iaaf483ed01948a78b46ca9254d8a2628e28fbedc Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaf483ed01948a78b46ca9254d8a2628e28fbedc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2.5.z Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2.5.z]: Add missing call to prepareImage
by sbonazzo＠redhat.com 13 Aug '15

13 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add missing call to prepareImage ...................................................................... Add missing call to prepareImage adding the missing call to prepareImage for allowing to write the image imported from the OVA to an iSCSI or FC storage. On NFS storage it worked also without this call but it's required on iSCSI. Change-Id: If42529e6f02b5803e0c2e1fd8d0ab7550b1402dd Bug-Url: https://bugzilla.redhat.com/1247888 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/image.py 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If42529e6f02b5803e0c2e1fd8d0ab7550b1402dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2.5.z Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: translate vm graphic settings in specParams
by ofrenkel＠redhat.com 13 Aug '15

13 Aug '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: translate vm graphic settings in specParams ...................................................................... core: translate vm graphic settings in specParams When Engine is sending the new-style graphic devices, VDSM expects the parameters 'fileTransferEnable' and 'copyPasteEnable' to be sent into the device specParams. The backward compatibility on VDSM side works when graphics devices aren't specified, and in this case and in this case only the vm-level parameters are considered. Until the UI settings will change directly the per-device specParams, the best way forward is to translate the per-vm settings into per-device specParams (format and naming is the same). Related-To: https://bugzilla.redhat.com/983019 Change-Id: I960bdee2f0828bd3e34f2e2ba8c169b8b83c8d9a Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 2 files changed, 48 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I960bdee2f0828bd3e34f2e2ba8c169b8b83c8d9a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Revert "engine: Activate vm pinning at request time"
by rgolan＠redhat.com 13 Aug '15

13 Aug '15

Roy Golan has submitted this change and it was merged. Change subject: Revert "engine: Activate vm pinning at request time" ...................................................................... Revert "engine: Activate vm pinning at request time" Following discussion with rgolan(a)redhat.com and dfediuk(a)redhat.com It was decided to revert the patch. This reverts commit a6bb19ec293b93ca7df80740b6362fecb071a8d5. Bug-Url: https://bugzilla.redhat.com/1058384 Change-Id: I648079f3e91716685c32e529de1349694708c226 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dudi Maroshi: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I648079f3e91716685c32e529de1349694708c226 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix network interfaces for imported vm using v2v
by ahadas＠redhat.com 12 Aug '15

12 Aug '15

Arik Hadas has submitted this change and it was merged. Change subject: core: fix network interfaces for imported vm using v2v ...................................................................... core: fix network interfaces for imported vm using v2v Add an optional field for network interface of VM that contains the name of the network in the remote environment on which the interface is declared. It is relevant for VMs that exist in some external environment of course. In addition, setting the name of network interface according to the standard in oVirt, i.e nic1, nic2 and so on. Change-Id: Icba912e15afd2f90799fac0c92b331740a05eb73 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterface.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 21 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icba912e15afd2f90799fac0c92b331740a05eb73 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: packaging: remove autogenerated INSTALL
by vfeenstr＠redhat.com 12 Aug '15

12 Aug '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: packaging: remove autogenerated INSTALL ...................................................................... packaging: remove autogenerated INSTALL Change-Id: Ib499cdcf7d0ad5bdc77fe1992307c2477f9fc649 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- D INSTALL 1 file changed, 0 insertions(+), 370 deletions(-) Approvals: Sandro Bonazzola: Verified Vinzenz Feenstra: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib499cdcf7d0ad5bdc77fe1992307c2477f9fc649 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: packaging: added windows agent spec file
by vfeenstr＠redhat.com 12 Aug '15

12 Aug '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: packaging: added windows agent spec file ...................................................................... packaging: added windows agent spec file Change-Id: Ic1ecb0c9009c70bdafb5a22f78a85de1a32bb09a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A ovirt-guest-agent-windows.spec 1 file changed, 76 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1ecb0c9009c70bdafb5a22f78a85de1a32bb09a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0