August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: sercon: minor ovirt-vmconsole-list.py cleanups
by piotr.kliczewski＠gmail.com 14 Aug '15

14 Aug '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: sercon: minor ovirt-vmconsole-list.py cleanups ...................................................................... sercon: minor ovirt-vmconsole-list.py cleanups - add debug command line option - leverage ovirt-configured logging - use specific logger: was using top level logger (logging.something()) because of a typo. - make sure we close the file-like returned by urllib2. - make sure to logs exceptions on syslog Bug-Url: https://bugzilla.redhat.com/1223671 Change-Id: Ie5323da99c2709b51fe043b492860140aad5af5a Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py 1 file changed, 37 insertions(+), 18 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Sandro Bonazzola: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/44814 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5323da99c2709b51fe043b492860140aad5af5a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: display unreinstallable packages
by sbonazzo＠redhat.com 14 Aug '15

14 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: display unreinstallable packages ...................................................................... packaging: setup: display unreinstallable packages When prompting about whether to upgrade even if some packages cannot be reinstalled if upgrade fails and we need to rollback, show the list of these packages. Change-Id: Ia9b3885f0919f96706cc2ec85979889f5cecb784 Related-To: https://bugzilla.redhat.com/1100201 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 1 file changed, 15 insertions(+), 11 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9b3885f0919f96706cc2ec85979889f5cecb784 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: aaa: set random admin password if unknown
by sbonazzo＠redhat.com 14 Aug '15

14 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: aaa: set random admin password if unknown ...................................................................... packaging: setup: aaa: set random admin password if unknown if admin password cannot be decrypted due to usage of old database and fresh installation generate random password. state is detected if p12 key is missing. Change-Id: I9a313d657447f24e2e294ac80087736c660fd293 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaa.py 1 file changed, 31 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Ondra Machacek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a313d657447f24e2e294ac80087736c660fd293 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix network interfaces of imported vm using v2v
by ahadas＠redhat.com 13 Aug '15

13 Aug '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: fix network interfaces of imported vm using v2v ...................................................................... webadmin: fix network interfaces of imported vm using v2v The network interfaces for a VM that is imported using virt-v2v were not defined correctly. This patch fixes it by setting the network name and profile properly. In addition, a new column is added the the network interfaces sub-tab of the import VM dialog in order to show the name of the network that the interface is declared on in the remote environment. Change-Id: I804e988c97cf72924c82d8bb1ca4c6cab4caeebb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportNetworkData.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromOvaModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromVmwareModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java 6 files changed, 145 insertions(+), 46 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I804e988c97cf72924c82d8bb1ca4c6cab4caeebb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: added permissions needed to change cluster only when c...
by tnisan＠redhat.com 13 Aug '15

13 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: added permissions needed to change cluster only when changing the cluster ...................................................................... core: added permissions needed to change cluster only when changing the cluster Since the backend can not trust that the TargetVdsGroupId is sent only when actually needed, added a check which makes sure to expect the permissions only when really needed. Change-Id: I3d4b78b271ea58fceed6a15228d7b5f98c14508c Bug-Url: https://bugzilla.redhat.com/1251893 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d4b78b271ea58fceed6a15228d7b5f98c14508c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix of IndexOutOfBoundsE in Host tab
by tnisan＠redhat.com 13 Aug '15

13 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix of IndexOutOfBoundsE in Host tab ...................................................................... webadmin: Fix of IndexOutOfBoundsE in Host tab If the Host tab is re-entered, SubTabHostGeneralHostErrataPresenter#onHostSelectionChange handler is notified two times: once with empty selection and once with previous selcetion. The empty selection was cause of the exception. Change-Id: If83687ac48a075d175981a57f58830849127ed49 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1252847 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralHostErrataPresenter.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If83687ac48a075d175981a57f58830849127ed49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fix of IndexOutOfBoundsE in Host tab
by tjelinek＠redhat.com 13 Aug '15

13 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix of IndexOutOfBoundsE in Host tab ...................................................................... webadmin: Fix of IndexOutOfBoundsE in Host tab If the Host tab is re-entered, SubTabHostGeneralHostErrataPresenter#onHostSelectionChange handler is notified two times: once with empty selection and once with previous selcetion. The empty selection was cause of the exception. Change-Id: If83687ac48a075d175981a57f58830849127ed49 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1252847 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralHostErrataPresenter.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If83687ac48a075d175981a57f58830849127ed49 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: added permissions needed to change cluster only when c...
by tjelinek＠redhat.com 13 Aug '15

13 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: added permissions needed to change cluster only when changing the cluster ...................................................................... core: added permissions needed to change cluster only when changing the cluster Since the backend can not trust that the TargetVdsGroupId is sent only when actually needed, added a check which makes sure to expect the permissions only when really needed. Change-Id: I3d4b78b271ea58fceed6a15228d7b5f98c14508c Bug-Url: https://bugzilla.redhat.com/1251893 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44791 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d4b78b271ea58fceed6a15228d7b5f98c14508c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Allow VM disks editing after enabling quota on data ce...
by tnisan＠redhat.com 13 Aug '15

13 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Allow VM disks editing after enabling quota on data center ...................................................................... core: Allow VM disks editing after enabling quota on data center Diagnostics: ------------ After enabling quota on data center. The recent quota id for a disk (in the database) is null. And the current quota id from GUI has value (current quota id = the selected quota in the list box). CanDoAction in UpdateVmDiskCommand prevent change to quota id while vm is running (rightfully). Therefore detects quota id change: for existing disks (of type IMAGE or CINDER) after quota is enabled in data center. Short term solution: ------------------- If recent quota id on disk is null always assume there is no change to quota id. Change-Id: Ib615cc1daa81a5b5d89d848bb88adb297fcf3473 Bug-Url: https://bugzilla.redhat.com/1193643 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Dudi Maroshi: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib615cc1daa81a5b5d89d848bb88adb297fcf3473 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: "doesn't not" -> "does not"
by tnisan＠redhat.com 13 Aug '15

13 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: "doesn't not" -> "does not" ...................................................................... webadmin: "doesn't not" -> "does not" Change-Id: If7ef35fccafd182e36d45804b9c8282ca0c2d057 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1253099 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Einav Cohen: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7ef35fccafd182e36d45804b9c8282ca0c2d057 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0