Change in ovirt-engine[master]: core: formatted ImportVm command+test
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: formatted ImportVm command+test
......................................................................
core: formatted ImportVm command+test
Change-Id: Iddc81dc0bbaf878e0659561a8d6ba5032235915e
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
2 files changed, 47 insertions(+), 32 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/44187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddc81dc0bbaf878e0659561a8d6ba5032235915e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: cleaup - removed unsused method.
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: cleaup - removed unsused method.
......................................................................
core: cleaup - removed unsused method.
Change-Id: Ia32f557f36272a352eb9f85d9f56dc7435c0c30f
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
1 file changed, 0 insertions(+), 15 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/44183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia32f557f36272a352eb9f85d9f56dc7435c0c30f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Added comment to ImportVmCommand CDA
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Added comment to ImportVmCommand CDA
......................................................................
core: Added comment to ImportVmCommand CDA
Change-Id: I04f87ade440afc3591f7bd4f9eaf6bf6b860df4a
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/44182
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04f87ade440afc3591f7bd4f9eaf6bf6b860df4a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: cleanup unused methods
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: cleanup unused methods
......................................................................
core: cleanup unused methods
Change-Id: I7855a61f563ad7c3146e0b4756387cca8d77d714
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37691
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7855a61f563ad7c3146e0b4756387cca8d77d714
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: events: request for more messages when error message arrives
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: events: request for more messages when error message arrives
......................................................................
events: request for more messages when error message arrives
When we have issues with connectivity there are error messages delivered
to a subscriber. In order process further messages we need to request
for more.
Change-Id: Iccd0952e6653ea20cc97361fe0ba3bc582fd55ef
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1245668
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVmStatsRefresher.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Omer Frenkel: Verified; Looks good to me, approved
Moti Asayag: Looks good to me, but someone else must approve; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/43959
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccd0952e6653ea20cc97361fe0ba3bc582fd55ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Enabled to disable CLI volume snapshot schedule again
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Enabled to disable CLI volume snapshot schedule again
......................................................................
gluster: Enabled to disable CLI volume snapshot schedule again
If gluster meta volume gets deleted and re-created from gluster
CLI the disabling of CLI schedule needs to happen again while
syncing the meta volume back to engine again.
Change-Id: I6e00a14ebcd87141edd941d7752350cc2af64fa8
Bug-Url: https://bugzilla.redhat.com/1240231
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java
2 files changed, 29 insertions(+), 18 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e00a14ebcd87141edd941d7752350cc2af64fa8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Corrected an issue with time conversion logic
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Corrected an issue with time conversion logic
......................................................................
gluster: Corrected an issue with time conversion logic
In the API convertTime() while getting input time value as
no of millis, Calendar.HOUR was used which is problematic
and there used to be 12 Hrs difference after converting the
time to other time zone.
Corrected the same to use Calendar.HOUR_OF_DAY.
Change-Id: I795d53e2a7a333864087bfe3a0b85fb6eb9375d0
Bug-Url: https://bugzilla.redhat.com/1244714
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44300
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I795d53e2a7a333864087bfe3a0b85fb6eb9375d0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: Introduce Arquillian (And test SchedulingManager)
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: Introduce Arquillian (And test SchedulingManager)
......................................................................
Introduce Arquillian (And test SchedulingManager)
This test will check the SchedulingManager can be loaded as a Singleton
bean. This is a simple test(rather than real integration test) and it's merely
to make sure all the CDI wirings for this class works.
Using Arquillian[1], tests grow easily to be integration-tests.
Every dependancy injection could be satisfied by the internal bean
manager and with that we can ensemble tests which span several
components.
Except from testing locally, arquillian lets you deploy your tests on
different containers, making testing for EAP/Wilfly compatibility easy
to achieve.
[1] www.arquillian.org
Change-Id: I7d52c2b0800b5bbc9e63e51277de0a46d4dda866
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/CommonTestMocks.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SchedulingManagerTest.java
M backend/manager/modules/pom.xml
M pom.xml
4 files changed, 158 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40341
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d52c2b0800b5bbc9e63e51277de0a46d4dda866
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: use ThreadPoolUtil for external scheduler discovery
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: use ThreadPoolUtil for external scheduler discovery
......................................................................
core: use ThreadPoolUtil for external scheduler discovery
Use Runnable instead of new Thread. Only our ThreadPoolUtil should
supply that resources and we should keep it.
Also SchedulingManager dependency has been dropped the responsibility of
reloading moved into SchedulingManager
Change-Id: If377e0241190d55b6d0960ff456717b3707edb34
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java
2 files changed, 41 insertions(+), 30 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40912
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If377e0241190d55b6d0960ff456717b3707edb34
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: SchedulingManager as CDI Singleton
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: SchedulingManager as CDI Singleton
......................................................................
core: SchedulingManager as CDI Singleton
- Singleton bean
- care for proper init during Backend load
- inject dependencies
- replace all getInstnace in commands with injection
Change-Id: I8adc52a3084f9bb539d808e0d8a066ef6fd6b92a
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/BasicMigrationHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcementPerCluster.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddClusterPolicyCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/EditClusterPolicyCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveClusterPolicyCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveExternalPolicyUnitCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/queries/GetAllPolicyUnitsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/queries/GetAttachedClustersByClusterPolicyIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/queries/GetClusterPoliciesQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/queries/GetClusterPolicyByIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/queries/GetPolicyUnitByIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommandTest.java
23 files changed, 214 insertions(+), 139 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40560
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8adc52a3084f9bb539d808e0d8a066ef6fd6b92a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months