August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: list virtual appliance - vdsbroker
by ahadas＠redhat.com 02 Aug '15

02 Aug '15

Arik Hadas has submitted this change and it was merged. Change subject: core: list virtual appliance - vdsbroker ...................................................................... core: list virtual appliance - vdsbroker Introduce GetOvaInfoVDSCommand that invokes getOvaInfo in VDSM to retrieve the VM configuration from OVA file. Change-Id: Ib798f8f4febfb89437a4bd14e0cb898707e7aa06 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetOvaInfoParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetOvaInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 7 files changed, 98 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib798f8f4febfb89437a4bd14e0cb898707e7aa06 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix isUserApplicationContainerManager to IsUserApplica...
by rgolan＠redhat.com 02 Aug '15

02 Aug '15

Roy Golan has submitted this change and it was merged. Change subject: core: Fix isUserApplicationContainerManager to IsUserApplicationContainerManager ...................................................................... core: Fix isUserApplicationContainerManager to IsUserApplicationContainerManager Change-Id: I618959fdf8abbf551e7cd8586414c5f3897d1a72 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/auth-plugin/src/main/java/org/ovirt/engine/core/jboss_auth_plugin/OvirtAuthPlugIn.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsUserApplicationContainerManagerQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44279 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I618959fdf8abbf551e7cd8586414c5f3897d1a72 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: db: sync dbfunc-base.sh with engine
by ydary＠redhat.com 02 Aug '15

02 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: db: sync dbfunc-base.sh with engine ...................................................................... db: sync dbfunc-base.sh with engine Change-Id: I9bc9d25e9d0e704241beced0540c6ced5756e25b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/dbfunc-base.sh 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved Yaniv Dary: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/43990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bc9d25e9d0e704241beced0540c6ced5756e25b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: setup: Recreate dwh data source on upgrade
by ydary＠redhat.com 02 Aug '15

02 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Recreate dwh data source on upgrade ...................................................................... packaging: setup: Recreate dwh data source on upgrade Do not export/import dwh data source on upgrade. Instead, always create it as on a clean setup. This fixes the flow in the linked bug, where a user tries to restore a backup that includes dwh and reports to a dwh database with different credentials. In principle it might break manual changes done to the datasource after running setup. Change-Id: I1fff0f30991dd839921a9e2af7f6b3e5290370c7 Bug-Url: https://bugzilla.redhat.com/1229398 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 42 insertions(+), 90 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yaniv Dary: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/43810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fff0f30991dd839921a9e2af7f6b3e5290370c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: host-deploy: support various fingerprint algorithms
by masayag＠redhat.com 02 Aug '15

02 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: host-deploy: support various fingerprint algorithms ...................................................................... host-deploy: support various fingerprint algorithms support the old format of MD5 digest. support the new format of algo:base64(hash) convert old format to new format before using. fetch digest from remote based on existing fingerprint algo if available. Change-Id: I2a2191ebdfd6e6ea466eb788d62fc8f14b445bac Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java A packaging/dbscripts/upgrade/03_06_1760_host_sshfingerprint.sql 4 files changed, 65 insertions(+), 24 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/44256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a2191ebdfd6e6ea466eb788d62fc8f14b445bac Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: replace Collection.emptyList with new ArrayList()
by alkaplan＠redhat.com 02 Aug '15

02 Aug '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: replace Collection.emptyList with new ArrayList() ...................................................................... engine: replace Collection.emptyList with new ArrayList() When adding element to 'Collection.emptyList' an 'UnsupportedOperationException' is thrown. Change-Id: I679c0662c34de34c1817896090a563abaf47ddb8 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/NetworkCommonUtils.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I679c0662c34de34c1817896090a563abaf47ddb8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: doc: README.developer: various of cleanups
by masayag＠redhat.com 02 Aug '15

02 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: doc: README.developer: various of cleanups ...................................................................... doc: README.developer: various of cleanups Change-Id: Ie9ab9abfd9724e24ea7ace87a38ab77e02504b49 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer 1 file changed, 65 insertions(+), 26 deletions(-) Approvals: Alon Bar-Lev: Verified Moti Asayag: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9ab9abfd9724e24ea7ace87a38ab77e02504b49 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Some network code cleanup
by masayag＠redhat.com 02 Aug '15

02 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Some network code cleanup ...................................................................... engine: Some network code cleanup Some network code cleanup: * remove redundant code / variables * some warnings treatment Change-Id: I25dd0bc1bf475ef80e00ed643af497d7f5dd111d Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java 5 files changed, 59 insertions(+), 75 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/44213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25dd0bc1bf475ef80e00ed643af497d7f5dd111d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: remove redundant restriction on VM network update
by masayag＠redhat.com 02 Aug '15

02 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: remove redundant restriction on VM network update ...................................................................... engine: remove redundant restriction on VM network update Now VDSM allows changing a properties of a VM network that is being used by VMs, so the restriction in the engine isn't relevant any more (since 3.6). VmDao in NetworkValidator is obtained through the constructor rather than DbFacade. Change-Id: Iaaae73a98f3cacc2b797055f9e24821569585ccc Bug-Url: https://bugzilla.redhat.com/1055454 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkFromClusterInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/LabelNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UnlabelNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVnicProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVnicProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVnicProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddNetworkOnProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/AddNetworkValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/RemoveProviderValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 27 files changed, 357 insertions(+), 82 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/43721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaae73a98f3cacc2b797055f9e24821569585ccc Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Support enroll certificate action
by masayag＠redhat.com 02 Aug '15

02 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Support enroll certificate action ...................................................................... webadmin: Support enroll certificate action The 'enroll certificate' action will be added to the host's menu bar and to the host's context menu. Change-Id: I45202223ca65fc0fed5a3952c7476a6b3a912f3f Bug-Url: https://bugzilla.redhat.com/1188759 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 3 files changed, 30 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/44267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45202223ca65fc0fed5a3952c7476a6b3a912f3f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0