September 2015 - Engine-commits - oVirt List Archives

Change in jenkins[master]: ovirt-optimizer: new standard builder job
by sbonazzo＠redhat.com 24 Sep '15

24 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-optimizer: new standard builder job ...................................................................... ovirt-optimizer: new standard builder job Change-Id: Idbc50dd69ae747c4422fbef084b5b6afb10ce251 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/confs/projects/ovirt-optimizer/ovirt-optimizer_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml A jobs/confs/yaml/scms/ovirt-optimizer.yaml 4 files changed, 30 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc50dd69ae747c4422fbef084b5b6afb10ce251 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove duplicated entry from AuditLogMessages
by oourfali＠redhat.com 24 Sep '15

24 Sep '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Remove duplicated entry from AuditLogMessages ...................................................................... core: Remove duplicated entry from AuditLogMessages Change-Id: Ia3a01712432b112a17293baf488e6a7add34099b Bug-Url: https://bugzilla.redhat.com/1238594 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3a01712432b112a17293baf488e6a7add34099b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename complex type "KSM" to "Ksm"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename complex type "KSM" to "Ksm" ...................................................................... restapi: Rename complex type "KSM" to "Ksm" This is required to make sure that there is only one rule for the names of complex types: all words, including acronyms, start with one upper case character and all the rest are lower case. Change-Id: Id4ee7ab172b6772cac0f82b082724f46fc17a957 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 4 files changed, 10 insertions(+), 9 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4ee7ab172b6772cac0f82b082724f46fc17a957 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename complex type "IP" to "Ip"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename complex type "IP" to "Ip" ...................................................................... restapi: Rename complex type "IP" to "Ip" This is required to make sure that there is only one rule for the names of complex types: all words, including acronyms, start with one upper case character and all the rest are lower case. Change-Id: I46a8b33968093b6d88fae25b3c63192287fda774 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmReportedDevicesResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/InitializationMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ReportedDeviceMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ReportedDeviceMapperTest.java 11 files changed, 37 insertions(+), 36 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46a8b33968093b6d88fae25b3c63192287fda774 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Remove usless call to "getDefaultConfigurationVers...
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Remove usless call to "getDefaultConfigurationVersion" ...................................................................... webadmin: Remove usless call to "getDefaultConfigurationVersion" This is needed in order to avoid the following find bugs warning: Return value of method without side effect is ignored This code calls a method and ignores the return value. However our analysis shows that the method (including its implementations in subclasses if any) does not produce any effect other than return value. Thus this call can be removed. We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. Common false-positive cases include: - The method is designed to be overridden and produce a side effect in other projects which are out of the scope of the analysis. - The method is called to trigger the class loading which may have a side effect. - The method is called just to get some exception. If you feel that our assumption is incorrect, you can use a @CheckReturnValue annotation to instruct FindBugs that ignoring the return value of this method is acceptable. Bug kind and pattern: RV - RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT Change-Id: Ibe01b712da764cd1b93caa8aef0c415c098ee2f3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Passed CI tests Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe01b712da764cd1b93caa8aef0c415c098ee2f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Use Integer.valueOf instead of new
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Use Integer.valueOf instead of new ...................................................................... webadmin: Use Integer.valueOf instead of new This is needed in order to avoid the following findbugs warning: Method invokes inefficient Number constructor; use static valueOf instead Using new Integer(int) is guaranteed to always result in a new object whereas Integer.valueOf(int) allows caching of values to be done by the compiler, class library, or JVM. Using of cached values avoids object allocation and the code will be faster. Values between -128 and 127 are guaranteed to have corresponding cached instances and using valueOf is approximately 3.5 times faster than using constructor. For values outside the constant range the performance of both styles is the same. Unless the class must be compatible with JVMs predating Java 1.5, use either autoboxing or the valueOf() method when creating instances of Long, Integer, Short, Character, and Byte. Bug kind and pattern: Bx - DM_NUMBER_CTOR Change-Id: I7c5d961e05cc6e85972559cf039169440cd92041 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Passed CI tests Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c5d961e05cc6e85972559cf039169440cd92041 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Use Long.parseLong instead of boxing
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Use Long.parseLong instead of boxing ...................................................................... webadmin: Use Long.parseLong instead of boxing This is needed to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: I3eefebbca97be35e78794131ca3697d4b40059a3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Passed CI tests Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eefebbca97be35e78794131ca3697d4b40059a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Use Long.compare instead of boxing
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Use Long.compare instead of boxing ...................................................................... webadmin: Use Long.compare instead of boxing This is necessary to avoid the following findbugs error: Boxing a primitive to compare A boxed primitive is created just to call compareTo method. It's more efficient to use static compare method (for double and float since Java 1.4, for other primitive types since Java 1.7) which works on primitives directly. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_COMPARE Change-Id: I373b33659ad517525f1b1056469262772cdfbbcb Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Passed CI tests Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I373b33659ad517525f1b1056469262772cdfbbcb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Make ConsolesBase.modelTypeMapping private
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Make ConsolesBase.modelTypeMapping private ...................................................................... webadmin: Make ConsolesBase.modelTypeMapping private This is a way to avoid the following findbugs warning: Field is a mutable collection which should be package protected A mutable collection instance is assigned to a final static field, thus can be changed by malicious code or by accident from another package. The field could be made package protected to avoid this vulnerability. Alternatively you may wrap this field into Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability. Bug kind and pattern: MS - MS_MUTABLE_COLLECTION_PKGPROTECT Change-Id: I68f8bc4aa3f99f6f504a5845ebbe5d0574291ace Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsolesBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Passed CI tests Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68f8bc4aa3f99f6f504a5845ebbe5d0574291ace Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename complex type "IO" to "Io"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename complex type "IO" to "Io" ...................................................................... restapi: Rename complex type "IO" to "Io" This is required to make sure that there is only one rule for the names of complex types: all words, including acronyms, start with one upper case character and all the rest are lower case. Change-Id: I1bc394a6a9b39b8fe77fbbba35b4092994a3fab0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46117 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bc394a6a9b39b8fe77fbbba35b4092994a3fab0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0