Change in ovirt-engine[master]: webadmin: Hotfix of icon validation for IE
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Hotfix of icon validation for IE
......................................................................
webadmin: Hotfix of icon validation for IE
It disables part of client side icon validation on IE browsers. The
disabled part relies on parsing of images using <img> tag. IE parses
images asynchronously as opposed to Chrome or Firefox (after caching).
Current frontend validation assumes synchronous behavior.
There are still backend icon validations.
Change-Id: I2766e993c3e03b5a040a178e26b8b71c93ac585c
Bug-Url: https://bugzilla.redhat.com/1263994
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IconValidation.java
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46532
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2766e993c3e03b5a040a178e26b8b71c93ac585c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-hosted-engine-setup[master]: setup: add default state transition notifications
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: setup: add default state transition notifications
......................................................................
setup: add default state transition notifications
Add a default value for state transition notifications.
Change-Id: I08816776a4b345300e8d022a0336d4a3a0584b97
Bug-Url: https://bugzilla.redhat.com/1260757
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Sivák: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46543
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08816776a4b345300e8d022a0336d4a3a0584b97
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-hosted-engine-ha[master]: sharedconf: moving initial broker.conf to engine_ha_statedir
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: sharedconf: moving initial broker.conf to engine_ha_statedir
......................................................................
sharedconf: moving initial broker.conf to engine_ha_statedir
On oVirt 3.6 the notification system config is on the shared
storage. A local copy is keep under engine_ha_statedir
to being able to notify failures also if the storage is not
available. It periodically got refreshed.
Moving there also the initial broker.conf from the rpm.
Change-Id: I7a1efcbf346be3ce403175bbe450ff8f0e8b2993
Bug-Url: https://bugzilla.redhat.com/1260757
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt-hosted-engine-ha.spec.in
M ovirt_hosted_engine_ha/broker/Makefile.am
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46544
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a1efcbf346be3ce403175bbe450ff8f0e8b2993
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-guest-agent[ovirt-3.6]: PEP8 1.62 compliance fixes
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: PEP8 1.62 compliance fixes
......................................................................
PEP8 1.62 compliance fixes
Change-Id: I50b6fedea4a9691b44fd527f1c9bb9cf0ddbde77
Bug-Url: https://bugzilla.redhat.com/1265164
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
(cherry picked from commit c7d34e391a3ca8b78e7e024e6f6919fa03f46898)
---
M ovirt-guest-agent/CredServer.py
M ovirt-guest-agent/GuestAgentWin32.py
M ovirt-guest-agent/OVirtAgentLogic.py
M ovirt-guest-agent/ovirt-guest-agent.py
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46576
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50b6fedea4a9691b44fd527f1c9bb9cf0ddbde77
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-guest-agent[master]: Imports reorder
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Imports reorder
......................................................................
Imports reorder
Change-Id: Iab4245af990f35ab2fd3eb34531c59089f33b957
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/CredServer.py
M ovirt-guest-agent/GuestAgentLinux2.py
M ovirt-guest-agent/GuestAgentWin32.py
M ovirt-guest-agent/LockActiveSession.py
M ovirt-guest-agent/OVirtAgentLogic.py
M ovirt-guest-agent/OVirtGuestService.py
M ovirt-guest-agent/VirtIoChannel.py
M ovirt-guest-agent/WinFile.py
M ovirt-guest-agent/ovirt-guest-agent.py
M ovirt-guest-agent/setup.py
10 files changed, 70 insertions(+), 55 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Verified; Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/46547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab4245af990f35ab2fd3eb34531c59089f33b957
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-guest-agent[master]: PEP8 1.62 compliance fixes
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: PEP8 1.62 compliance fixes
......................................................................
PEP8 1.62 compliance fixes
Change-Id: I50b6fedea4a9691b44fd527f1c9bb9cf0ddbde77
Bug-Url: https://bugzilla.redhat.com/1265164
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/CredServer.py
M ovirt-guest-agent/GuestAgentWin32.py
M ovirt-guest-agent/OVirtAgentLogic.py
M ovirt-guest-agent/ovirt-guest-agent.py
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Verified; Looks good to me, approved
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/46513
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50b6fedea4a9691b44fd527f1c9bb9cf0ddbde77
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: Engine: Hide bad 'Done' message for PM test
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: Engine: Hide bad 'Done' message for PM test
......................................................................
Engine: Hide bad 'Done' message for PM test
VSDM returns 'Done' by default for fencing operations. This is not useful and appending
it to log messages results in a confusing message. So if the message is 'Done', it's
better to ignore it. This patch does that.
Bug-Url: https://bugzilla.redhat.com/1203741
Change-Id: Icd4a0a788fba25c491f693747f00f4c64f4413d4
Signed-off-by: Ori Liel <oliel(a)redhat.com>
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceOperationResult.java
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46541
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd4a0a788fba25c491f693747f00f4c64f4413d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in jenkins[master]: aaa-jdbc: Add jobs for oVirt 3.6
by dcaroest@redhat.com
David Caro has submitted this change and it was merged.
Change subject: aaa-jdbc: Add jobs for oVirt 3.6
......................................................................
aaa-jdbc: Add jobs for oVirt 3.6
Adds branch ovirt-engine-extension-aaa-jdbc-1.0 which will be used for
oVirt 3.6 builds
Change-Id: I1b642238ff2a7a19c2e37d82550e56267e39da37
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-extension-aaa-jdbc/ovirt-engine-extension-aaa-jdbc_create-rpms.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml
2 files changed, 11 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Ready for review
Jenkins CI: Passed CI tests
David Caro: Verified; Ready for merge
--
To view, visit https://gerrit.ovirt.org/46445
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b642238ff2a7a19c2e37d82550e56267e39da37
Gerrit-PatchSet: 6
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
9 years, 1 month
Change in jenkins[master]: ovirt-engine_standard: add missing job
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine_standard: add missing job
......................................................................
ovirt-engine_standard: add missing job
add missing check-patch for 3.6 on el6
Change-Id: I8b25ce1dac4f6d8452e3b09a16d6eee24378e443
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46357
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b25ce1dac4f6d8452e3b09a16d6eee24378e443
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
9 years, 1 month
Change in jenkins[master]: Restored renew_certificate in 3.5 upgrade answer file
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Restored renew_certificate in 3.5 upgrade answer file
......................................................................
Restored renew_certificate in 3.5 upgrade answer file
The line was removed from the file because it was failing 3.5->3.5
upgrade job, but after removing it 3.4->3.5 upgrades started failing.
Restoring the line, with boolean False instead of True.
Change-Id: I03172acafda0b2ccf81cd075fdebd8d9237a6a96
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/ovirt-engine_upgrade_to_3.5/setup.file.otopi
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Passed CI tests; Ready for merge
Sharon Naftaly: Verified
--
To view, visit https://gerrit.ovirt.org/46439
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03172acafda0b2ccf81cd075fdebd8d9237a6a96
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
9 years, 1 month