September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Remove useless object in "PackageExplorer"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove useless object in "PackageExplorer" ...................................................................... restapi: Remove useless object in "PackageExplorer" This is needed in order to avoid the following findbugs warning: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed. This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT Change-Id: I0351a5f951e94eb7582ebd1a10d8c7ca2b887f19 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/PackageExplorer.java 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0351a5f951e94eb7582ebd1a10d8c7ca2b887f19 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Check result of "listFiles" in "PackageExplore"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Check result of "listFiles" in "PackageExplore" ...................................................................... restapi: Check result of "listFiles" in "PackageExplore" This is needed in order to avoid the following findbugs warning: Possible null pointer dereference due to return value of called method The return value from a method is dereferenced without a null check, and the return value of that method is one that should generally be checked for null. This may lead to a NullPointerException when the code is executed. Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE Change-Id: I0c8f25ce6e248dd32ccbc52e510f79cab809e90d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/PackageExplorer.java 1 file changed, 14 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46591 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c8f25ce6e248dd32ccbc52e510f79cab809e90d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add missed features
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add missed features ...................................................................... restapi: Add missed features This is needed in order to avoid the following findbugs warning, and it is a real bug as well: Useless non-empty void method Our analysis shows that this non-empty void method does not actually perform any useful work. Please check it: probably there's a mistake in its code or its body can be fully removed. We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. Common false-positive cases include: - The method is intended to trigger loading of some class which may have a side effect. - The method is intended to implicitly throw some obscure exception. Bug kind and pattern: UC - UC_USELESS_VOID_METHOD Change-Id: I28386f1cbee0298ec1142d5c63b6d732de67937a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28386f1cbee0298ec1142d5c63b6d732de67937a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove useless object in "BackendGraphicsConsoleRes...
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove useless object in "BackendGraphicsConsoleResource" ...................................................................... restapi: Remove useless object in "BackendGraphicsConsoleResource" This is needed in order to avoid the following findbugs warning: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed. This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT Change-Id: I2a42dec0128c3d5a0178dc92e96b219cf284efef Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleResource.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a42dec0128c3d5a0178dc92e96b219cf284efef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use "Integer.parseInt" in "BackendResource"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use "Integer.parseInt" in "BackendResource" ...................................................................... restapi: Use "Integer.parseInt" in "BackendResource" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Ie3bb154661495b1f1fb10d46ec08447e920dbcb6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46588 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3bb154661495b1f1fb10d46ec08447e920dbcb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix condition in "IconHelper"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix condition in "IconHelper" ...................................................................... restapi: Fix condition in "IconHelper" This is needed in order to avoid the following findbugs warning, but it also looks like a real bug: Repeated conditional tests The code contains a conditional test is performed twice, one right after the other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to be something else (e.g., x == 0 || y == 0). Bug kind and pattern: RpC - RpC_REPEATED_CONDITIONAL_TEST Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/IconHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Avoid useless condition in "VersionMapper"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Avoid useless condition in "VersionMapper" ...................................................................... restapi: Avoid useless condition in "VersionMapper" This is needed in order to avoid the following findbugs warning: Condition has no effect This condition always produces the same result as the value of the involved variable was narrowed before. Probably something else was meant or condition can be removed. Bug kind and pattern: UC - UC_USELESS_CONDITION Change-Id: Id1df506d4f924d120e50f4058b2518bee7bd9901 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VersionMapper.java 1 file changed, 6 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1df506d4f924d120e50f4058b2518bee7bd9901 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use "Integer.parseInt" in "PermitMapper"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use "Integer.parseInt" in "PermitMapper" ...................................................................... restapi: Use "Integer.parseInt" in "PermitMapper" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: I2e23d4f8fbabd7db188e0b817b5e21cbd8375f6e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e23d4f8fbabd7db188e0b817b5e21cbd8375f6e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: setup: add default state transition notifications
by sbonazzo＠redhat.com 23 Sep '15

23 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: add default state transition notifications ...................................................................... setup: add default state transition notifications Add a default value for state transition notifications. Change-Id: I08816776a4b345300e8d022a0336d4a3a0584b97 Bug-Url: https://bugzilla.redhat.com/1260757 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 3c46e495c15e6c2c8e92a35ffdf0009aa712042d) --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08816776a4b345300e8d022a0336d4a3a0584b97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: ovirt-hosted-engine-ha: support branched 3.6
by sbonazzo＠redhat.com 23 Sep '15

23 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-hosted-engine-ha: support branched 3.6 ...................................................................... ovirt-hosted-engine-ha: support branched 3.6 support the new branch for 3.6 Change-Id: I3a9606726617a7be4c1671e6cd24fc15b8c8d7be Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a9606726617a7be4c1671e6cd24fc15b8c8d7be Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0