September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Use elements instead of attributes in VIRTIO SCSI
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use elements instead of attributes in VIRTIO SCSI ...................................................................... restapi: Use elements instead of attributes in VIRTIO SCSI Currently the VIRTIO ISCSI element uses attributes for its properties: <virtio_scsi enabled="true"/> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <virtio_scsi> <enabled>true</enabled> </virtio_scsi> Change-Id: Ia72fdeab1670a285d76d6df24c1ab909341b1730 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia72fdeab1670a285d76d6df24c1ab909341b1730 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use elements instead of attributes in "console"
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use elements instead of attributes in "console" ...................................................................... restapi: Use elements instead of attributes in "console" Currently "console" element uses attributes for its properties: <console enabled="true"/> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <console> <enabled>true</enabled> </console> Change-Id: Ib805ad6858771d651c30439fb0b3177337ca6ebb Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib805ad6858771d651c30439fb0b3177337ca6ebb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fence agent duplicate agents
by awels＠redhat.com 22 Sep '15

22 Sep '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fence agent duplicate agents ...................................................................... webadmin: fence agent duplicate agents - Fence agents should allow the same IP but with different management types. It should NOT allow duplicate ip/type combinations. Change-Id: Ic3c947a782997482e20a166a99bbbf8f785c1323 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257575 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 12 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3c947a782997482e20a166a99bbbf8f785c1323 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: repo_closure_check: add openstack to master el7
by sbonazzo＠redhat.com 22 Sep '15

22 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: repo_closure_check: add openstack to master el7 ...................................................................... repo_closure_check: add openstack to master el7 add openstack repo to ovirt-master-snapshot check on EL7 Change-Id: Icf75645d8026fb0a4bd17273d9390e4f4014c3e5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/packaging/repo_closure_check.sh 1 file changed, 40 insertions(+), 18 deletions(-) Approvals: Sandro Bonazzola: Verified; Passed CI tests; Ready for merge Barak Korren: Looks good to me -- To view, visit https://gerrit.ovirt.org/46354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf75645d8026fb0a4bd17273d9390e4f4014c3e5 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Force use of Java 8 for building
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Force use of Java 8 for building ...................................................................... core: Force use of Java 8 for building This patch changes the automation scripts and the RPM .spec file so that they explicitly set the JAVA_HOME environment variable pointing to the installation of Java 1.8.0, as otherwise when there are multiple versions of Java installed it isn't possible to determine which one will be used for the Maven build. Change-Id: I84562308dca9c8fdfcf4087d7a8f966ebba5a8ef Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M automation/build-artifacts.packages M automation/build-artifacts.sh M automation/check-merged.packages M automation/check-merged.sh M automation/check-patch.packages M automation/check-patch.sh M ovirt-engine.spec.in 7 files changed, 16 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests David Caro: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84562308dca9c8fdfcf4087d7a8f966ebba5a8ef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Don't use empty findbugs filter files
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Don't use empty findbugs filter files ...................................................................... core: Don't use empty findbugs filter files Empty filter files cause errors in newer versions of findbugs, as they aren't valid XML documents. Change-Id: I32744268c48abaac90d7e0d6c6b280ce4e9d2152 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/welcome/exclude-filters.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32744268c48abaac90d7e0d6c6b280ce4e9d2152 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix adding cluster quota limit through REST
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix adding cluster quota limit through REST ...................................................................... restapi: Fix adding cluster quota limit through REST Now it is possible to add cluster quota limit with unlimmited memory or vcpu through REST. Change-Id: Idd0748a529055cabea6e63c4df62a06da532a6a3 Bug-Url: https://bugzilla.redhat.com/1244519 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QuotaMapper.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/46236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd0748a529055cabea6e63c4df62a06da532a6a3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: sercon: backend: always use serial console type
by tjelinek＠redhat.com 22 Sep '15

22 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: sercon: backend: always use serial console type ...................................................................... sercon: backend: always use serial console type VirtIO console device type is still unsafe to use as default. There even was reports of Guests crashing at boot. We should use 'serial' type as default. Change-Id: Ida22d08ddf7115b431bb477c7e34c19c2271e3da Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java A packaging/dbscripts/upgrade/03_06_1870_add_type_spec_param_to_console_devices.sql 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/46096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida22d08ddf7115b431bb477c7e34c19c2271e3da Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: there are no such things as ghost in MacRangeWidget
by tjelinek＠redhat.com 22 Sep '15

22 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: there are no such things as ghost in MacRangeWidget ...................................................................... webadmin: there are no such things as ghost in MacRangeWidget 'isGhost' mechanism is faulty. Correct behavior is, acording to colleges and code notes, that there's at most one ghost and it has to be the last record. Currently implementation allows existence of multiple ghosts, which needs not to be trailing records. For simplicity, in this dialog we assume that there cannot exist ghosts, until ghost problem is solved generally Change-Id: I8091cedfd3cf51dfcb93bb7c7de45234088bfdd8 Bug-Url: https://bugzilla.redhat.com/1217940 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/MacRangeWidget.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46017 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8091cedfd3cf51dfcb93bb7c7de45234088bfdd8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Replace memory overcommit attributes with elements
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Replace memory overcommit attributes with elements ...................................................................... restapi: Replace memory overcommit attributes with elements Currently the "overcommit" element uses attributes for its properties: <memory_policy> <overcommit percent="100"/> ... </memory_policy> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <memory_policy> <overcommit> <percent>100</percent> </overcommit> ... </memory_policy> Change-Id: Ica1587917d31633531ac6ab9bf16a748eb74f761 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 22 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica1587917d31633531ac6ab9bf16a748eb74f761 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0