September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core, webadmin: remove validation for multicasts MAC addresses
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core,webadmin: remove validation for multicasts MAC addresses ...................................................................... core,webadmin: remove validation for multicasts MAC addresses after modification of MAC pools, ranges definition boundaries can be non-unicast addresses. Change-Id: Ifad61210f6f04c71dd9da15a6664f6b3075b3fc2 Bug-Url: https://bugzilla.redhat.com/1188294 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacRange.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/MacAddressValidation.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UnicastMacAddressValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 5 files changed, 22 insertions(+), 16 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifad61210f6f04c71dd9da15a6664f6b3075b3fc2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, webadmin: remove validation for multicasts MAC addresses
by alkaplan＠redhat.com 17 Sep '15

17 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: core,webadmin: remove validation for multicasts MAC addresses ...................................................................... core,webadmin: remove validation for multicasts MAC addresses after modification of MAC pools, ranges definition boundaries can be non-unicast addresses. Change-Id: Ifad61210f6f04c71dd9da15a6664f6b3075b3fc2 Bug-Url: https://bugzilla.redhat.com/1188294 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacRange.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/MacAddressValidation.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UnicastMacAddressValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 5 files changed, 22 insertions(+), 16 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/37499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifad61210f6f04c71dd9da15a6664f6b3075b3fc2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Use only public schema in engine db infra
by tnisan＠redhat.com 16 Sep '15

16 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Use only public schema in engine db infra ...................................................................... core: Use only public schema in engine db infra Uses only public schema in engine database infrastructure to prevent name collisions with objects in custom schemas. Change-Id: I63960963615b5b8d9d435c84bf8cde8e84f0b5e0 Bug-Url: https://bugzilla.redhat.com/1262831 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/common_sp.sql M packaging/dbscripts/create_functions.sql M packaging/dbscripts/upgrade/03_04_0090_move_quota_id.sql M packaging/dbscripts/upgrade/03_04_0540_remove_storage_pool_type.sql M packaging/dbscripts/upgrade/03_06_1780_create_storage_server_connection_extension_table.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/upgrade/pre_upgrade/0020_add_materialized_views_table.sql 7 files changed, 14 insertions(+), 12 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63960963615b5b8d9d435c84bf8cde8e84f0b5e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: sercon: servlet: make sure '\n' in key are handled
by tnisan＠redhat.com 16 Sep '15

16 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: sercon: servlet: make sure '\n' in key are handled ...................................................................... sercon: servlet: make sure '\n' in key are handled The SSH Public key should not include any newline. They are harmless when stored into Engine, but the should not be passed around to vmconsole. This patch enforces this constraint in two way: - split the strings by '\n', producing one entry per item. This way, the user can piggyback more than one key in the same field. - trim each key item to make sure no '\n' is emitted. Change-Id: I80caba7749337a48c060fd5afad5c30b2e46a65f Bug-Url: https://bugzilla.redhat.com/1223671 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/VMConsoleProxyServlet.java 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80caba7749337a48c060fd5afad5c30b2e46a65f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Added el7 distro to ovirt-engine check_patch job
by sbonazzo＠redhat.com 16 Sep '15

16 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Added el7 distro to ovirt-engine check_patch job ...................................................................... Added el7 distro to ovirt-engine check_patch job Change-Id: Id33b202ae02285c3e657759cc1b71c4275e1e742 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id33b202ae02285c3e657759cc1b71c4275e1e742 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: sercon: frontned: add 'serial' term in vm dialog
by ofrenkel＠redhat.com 16 Sep '15

16 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: sercon: frontned: add 'serial' term in vm dialog ...................................................................... sercon: frontned: add 'serial' term in vm dialog The term VirtIO Console says nothing for the common user. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1223671 Change-Id: Ief128c93c65a447699f25469fdf295a670932c66 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief128c93c65a447699f25469fdf295a670932c66 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Added check_patch.sh script with ovirt_build_quick option
by sbonazzo＠redhat.com 16 Sep '15

16 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Added check_patch.sh script with ovirt_build_quick option ...................................................................... Added check_patch.sh script with ovirt_build_quick option Copied build_artifacts.sh script to check_patch.sh script and added -D "ovirt_build_quick 1" to rpmbuild command. Change-Id: I51f36d15710793b968cb1da578e29bcd94fe343d Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A automation/check-patch.packages A automation/check-patch.repos M automation/check-patch.sh 3 files changed, 94 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51f36d15710793b968cb1da578e29bcd94fe343d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: build: ovirt-live-3.5.5_rc1
by sbonazzo＠redhat.com 16 Sep '15

16 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.5.5_rc1 ...................................................................... build: ovirt-live-3.5.5_rc1 Change-Id: If13a64381c8164624328d3f89c1dcd22da62c29b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If13a64381c8164624328d3f89c1dcd22da62c29b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: do not log destination host on error on source
by ahadas＠redhat.com 16 Sep '15

16 Sep '15

Arik Hadas has submitted this change and it was merged. Change subject: core: do not log destination host on error on source ...................................................................... core: do not log destination host on error on source If VM crashes on the source host while being migrated, the audit log showed "Destination: <UNKNOWN>" since the destination host is not initialized by the monitoring for such a migration error. The destination host is irrelevant for such an error which is on the source, therefore it is removed. Change-Id: I627431e6237ebe2b7685a4b84d9df21a590dc72a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/46235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I627431e6237ebe2b7685a4b84d9df21a590dc72a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: VmPoolType enum refactoring
by ofrenkel＠redhat.com 16 Sep '15

16 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: VmPoolType enum refactoring ...................................................................... core: VmPoolType enum refactoring * Converted VmPoolType constant names to uppercase. * Added values to the constants to be uses instead of ordinals. Change-Id: I530fba98012bc0fd59be479ca72d14e221e0c836 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPoolType.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 11 files changed, 35 insertions(+), 23 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Ori Liel: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I530fba98012bc0fd59be479ca72d14e221e0c836 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0