Change in ovirt-engine[ovirt-engine-3.5]: aaa: attach_user_to_role: rename parameters to match product...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: attach_user_to_role: rename parameters to match product conventions
......................................................................
aaa: attach_user_to_role: rename parameters to match product conventions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1262604
Change-Id: I7e39a760f8d4dda9ceb28eeb584009486cb0f997
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/ovirt-engine-role.sh
1 file changed, 18 insertions(+), 18 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46205
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e39a760f8d4dda9ceb28eeb584009486cb0f997
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: aaa: attach_user_to_role: add missing namespace attribute
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: attach_user_to_role: add missing namespace attribute
......................................................................
aaa: attach_user_to_role: add missing namespace attribute
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1262604
Change-Id: I04e9c6fdb6723cd369908d40bb8a4a19f74d10f3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/ovirt-engine-role.sh
M packaging/dbscripts/common_sp.sql
2 files changed, 11 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04e9c6fdb6723cd369908d40bb8a4a19f74d10f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: aaa: attach_user_to_role: user id may be unique within provider
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: attach_user_to_role: user id may be unique within provider
......................................................................
aaa: attach_user_to_role: user id may be unique within provider
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1262604
Change-Id: I2255c53f9947e89a036e5e7875430b9e7367ec35
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/dbscripts/common_sp.sql
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46203
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2255c53f9947e89a036e5e7875430b9e7367ec35
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: restapi: Added pool type to VmPool model
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: restapi: Added pool type to VmPool model
......................................................................
restapi: Added pool type to VmPool model
Added 'type' field to VmPool model that allows to specify type of the
pool when creating it in the form:
<type>automatic</type>
or
<type>manual</type>
For backward compatibility, if type of the pool is not specified,
VmPoolType.Automatic is used by default.
Change-Id: If3922af13a19374d93c8bfc54457cbfbff8341a6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1244841
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/VmPoolType.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java
6 files changed, 87 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Melamud: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43991
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3922af13a19374d93c8bfc54457cbfbff8341a6
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: aaa: attach_user_to_role: rename parameters to match product...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: attach_user_to_role: rename parameters to match product conventions
......................................................................
aaa: attach_user_to_role: rename parameters to match product conventions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1262604
Change-Id: I7e39a760f8d4dda9ceb28eeb584009486cb0f997
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/ovirt-engine-role.sh
1 file changed, 18 insertions(+), 18 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Tal Nisan: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46202
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e39a760f8d4dda9ceb28eeb584009486cb0f997
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: aaa: attach_user_to_role: add missing namespace attribute
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: attach_user_to_role: add missing namespace attribute
......................................................................
aaa: attach_user_to_role: add missing namespace attribute
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1262604
Change-Id: I04e9c6fdb6723cd369908d40bb8a4a19f74d10f3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/ovirt-engine-role.sh
M packaging/dbscripts/common_sp.sql
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaa.py
4 files changed, 29 insertions(+), 7 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Tal Nisan: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46201
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04e9c6fdb6723cd369908d40bb8a4a19f74d10f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: aaa: attach_user_to_role: user id may be unique within provider
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: attach_user_to_role: user id may be unique within provider
......................................................................
aaa: attach_user_to_role: user id may be unique within provider
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1262604
Change-Id: I2255c53f9947e89a036e5e7875430b9e7367ec35
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/dbscripts/common_sp.sql
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46200
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2255c53f9947e89a036e5e7875430b9e7367ec35
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: sercon: servlet: report correct host name
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: sercon: servlet: report correct host name
......................................................................
sercon: servlet: report correct host name
the serial console servlet needs to report the VDS name, not
the IP of the console.
Otherwise, the certificate validation will be broken.
Change-Id: Iac0fa9b79e31e3016edb3f3797f8495b4fa503c2
Bug-Url: https://bugzilla.redhat.com/1223671
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/VMConsoleProxyServlet.java
1 file changed, 13 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46215
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac0fa9b79e31e3016edb3f3797f8495b4fa503c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: engine: Fix typo: sanpshots->snapshots
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Fix typo: sanpshots->snapshots
......................................................................
engine: Fix typo: sanpshots->snapshots
Change-Id: Iebf91622e553843bad82324ed91f995bd80f5ea1
Bug-Url: https://bugzilla.redhat.com/1261258
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/46220
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebf91622e553843bad82324ed91f995bd80f5ea1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: Fix order of DB operations in RefreshHostDevicesCommand
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix order of DB operations in RefreshHostDevicesCommand
......................................................................
core: Fix order of DB operations in RefreshHostDevicesCommand
We need to first
* Add new devices
* Update existing (with new parent)
* Remove disappeared devices safely (since no one points its parent on it)
To prevent foreign key violation on parent column.
Change-Id: Ie85680d02632e2ff45fbabee654ba7cfb66d6e99
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261877
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46227
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie85680d02632e2ff45fbabee654ba7cfb66d6e99
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month