September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Initial task handlers in CommandBase c'tor
by masayag＠redhat.com 08 Sep '15

08 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Initial task handlers in CommandBase c'tor ...................................................................... engine: Initial task handlers in CommandBase c'tor The commands relies on tasks handlers to be initialized at c'tor execution, hence it is being shifted from the postConstruct() back to the c'tor. Change-Id: I475c737d7d2b912799556dc239578542a1900fa9 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/45841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I475c737d7d2b912799556dc239578542a1900fa9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Avoid NPE when validating non-LUN disks
by derez＠redhat.com 08 Sep '15

08 Sep '15

Daniel Erez has submitted this change and it was merged. Change subject: core: Avoid NPE when validating non-LUN disks ...................................................................... core: Avoid NPE when validating non-LUN disks In some scenarios, such as import a non-existing VM, a validation may be applied to a non-existing disk. These cases are legal and don't need the verification. The validation is sometimes needed in an internal command, hence the best way is to ignore it when it's not needed. Change-Id: I0024da114c56e0520421a5e138c6c9e49cf278b9 Bug-Url: https://bugzilla.redhat.com/1147860 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/45854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0024da114c56e0520421a5e138c6c9e49cf278b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: packaging: Distribution specific RPM spec files
by juan.hernandez＠redhat.com 08 Sep '15

08 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Distribution specific RPM spec files ...................................................................... packaging: Distribution specific RPM spec files Currently we use a single .spec file template for all the supported distributions. To support all the distributions it should contain many "%if" statements that change behaviour, for example to build or not the Python 3 support packages. This would make it convoluted and difficult to maintain. To avoid this issue this patch introduces different spec file templates, one for each supported distribution. Change-Id: Id9d733bdfcafab4e07325695ff395a40a9b27bd2 Bug-Url: https://bugzilla.redhat.com/1260865 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M .gitignore M Makefile C spec.el6.in A spec.el7.centos.in C spec.el7.in R spec.fc21.in C spec.fc22.in 7 files changed, 21 insertions(+), 83 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Juan Hernandez: Verified; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9d733bdfcafab4e07325695ff395a40a9b27bd2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix checking compatibility of proxy host and fencing p...
by oourfali＠redhat.com 08 Sep '15

08 Sep '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix checking compatibility of proxy host and fencing policy ...................................................................... core: Fix checking compatibility of proxy host and fencing policy Fixes the issue when checking compatibility of fence proxy host with fencing policy caused by BZ1229177. It changes the comparison using following rule: If at least one version contained in host supported cluster levels is higher or equals to minimal required version for the fencing policy of the cluster, then host can be used as a proxy. Change-Id: I94cc1419186dfd3ab557143e41b3d3f3772f614a Bug-Url: https://bugzilla.redhat.com/1260619 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45840 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94cc1419186dfd3ab557143e41b3d3f3772f614a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: Show all pinned hosts in general model forms
by tjelinek＠redhat.com 08 Sep '15

08 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Show all pinned hosts in general model forms ...................................................................... frontend: Show all pinned hosts in general model forms A vm can be pinned to multiple VMs. Only one of them was shown. Show them as a comma separated list of all host names, including a tooltip. Affected locations are: * General overview tab for VMs (AdminPortal) * General overview tab for VMs (UserPortal) * General overview tab for Pools (AdminPortal) * General overview tab for Pools (UserPortal) Change-Id: I4e9b8e5288efb5ea5f612e93e6361685b7f32999 Bug-Url: https://bugzilla.redhat.com/1256683 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java 6 files changed, 29 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e9b8e5288efb5ea5f612e93e6361685b7f32999 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: utils: allow spaces within encrypted fields
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: utils: allow spaces within encrypted fields ...................................................................... utils: allow spaces within encrypted fields Ever since 3.0 (probably even before) the encryption of database fields that was used is invalid, it uses RSA to encrypt blobs instead of using ciphers within envelope. It also stores null and empty strings as plain, and to make it even better it trims spaces out of the input for some reason. To conclude security... if decryption fails it falls back to use the blob as plain text. This logic was untouched, under the hope that we slowly remove usages of it. AAA does not use it any more, we should remove all. For now, we remove the trim() as if the password of trim() actually works so far it will keep working, new passwords with leading/trailing spaces will be rejected. The risk is if for some reason we have " "* in database field it will be rejected as valid password, fixing it will be re-set password by user to empty one. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258867 Change-Id: I2ca15519ec245efd82e71f2ec39abd4ca1fe81c2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45818 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ca15519ec245efd82e71f2ec39abd4ca1fe81c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: utils: allow spaces within encrypted fields
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: utils: allow spaces within encrypted fields ...................................................................... utils: allow spaces within encrypted fields Ever since 3.0 (probably even before) the encryption of database fields that was used is invalid, it uses RSA to encrypt blobs instead of using ciphers within envelope. It also stores null and empty strings as plain, and to make it even better it trims spaces out of the input for some reason. To conclude security... if decryption fails it falls back to use the blob as plain text. This logic was untouched, under the hope that we slowly remove usages of it. AAA does not use it any more, we should remove all. For now, we remove the trim() as if the password of trim() actually works so far it will keep working, new passwords with leading/trailing spaces will be rejected. The risk is if for some reason we have " "* in database field it will be rejected as valid password, fixing it will be re-set password by user to empty one. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258867 Change-Id: I2ca15519ec245efd82e71f2ec39abd4ca1fe81c2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ca15519ec245efd82e71f2ec39abd4ca1fe81c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: fix VM dialog for German translation
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix VM dialog for German translation ...................................................................... webadmin: fix VM dialog for German translation - Changed the the SerialNumberPolicy to use the standard way of showing the question mark - made the width of the dialog bigger Change-Id: I311377b5befc4ca4bbe89381bb9ce4472f19de2d Bug-Url: https://bugzilla.redhat.com/1255678 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml 3 files changed, 21 insertions(+), 45 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I311377b5befc4ca4bbe89381bb9ce4472f19de2d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: chain icon moves the rest of the widgets
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: chain icon moves the rest of the widgets ...................................................................... webadmin: chain icon moves the rest of the widgets Made some amendments making the right side of the widgets consistently sized across VM based dialogs Change-Id: I903e6bf99d42cadc88cd89680953acba6fe9a2d5 Bug-Url: https://bugzilla.redhat.com/1166059 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelDetachableWidgetWithInfo.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidgetWithLabel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 6 files changed, 29 insertions(+), 26 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I903e6bf99d42cadc88cd89680953acba6fe9a2d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: add audit log for vm that recovered from paused
by tnisan＠redhat.com 08 Sep '15

08 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: add audit log for vm that recovered from paused ...................................................................... core: add audit log for vm that recovered from paused when vm moves to pause because of error, there is an audit log for it. added an audit log for the case vm moves to up from paused (because of error). Change-Id: I342925c97fadb56999b32c45c321b161459b587e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1171459 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPauseStatus.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 4 files changed, 22 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I342925c97fadb56999b32c45c321b161459b587e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0