September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: encoding issue in vv file
by tjelinek＠redhat.com 07 Sep '15

07 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: encoding issue in vv file ...................................................................... webadmin: encoding issue in vv file If some part of the .vv file contains some national chars, it will be incorrectly encoded. Fixed by sending them as URL encoded and decode them on server. Change-Id: I178249bbd779787b02545e40c1c0d0d4137a75df Bug-Url: https://bugzilla.redhat.com/1258759 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetAttachmentServlet.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45718 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I178249bbd779787b02545e40c1c0d0d4137a75df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6_beta4
by sbonazzo＠redhat.com 07 Sep '15

07 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6_beta4 ...................................................................... build: ovirt-live-3.6_beta4 Change-Id: Ic63b94dcc0559d920986fedc6b0bab02a67aea5f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic63b94dcc0559d920986fedc6b0bab02a67aea5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: utils: allow spaces within encrypted fields
by masayag＠redhat.com 07 Sep '15

07 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: utils: allow spaces within encrypted fields ...................................................................... utils: allow spaces within encrypted fields Ever since 3.0 (probably even before) the encryption of database fields that was used is invalid, it uses RSA to encrypt blobs instead of using ciphers within envelope. It also stores null and empty strings as plain, and to make it even better it trims spaces out of the input for some reason. To conclude security... if decryption fails it falls back to use the blob as plain text. This logic was untouched, under the hope that we slowly remove usages of it. AAA does not use it any more, we should remove all. For now, we remove the trim() as if the password of trim() actually works so far it will keep working, new passwords with leading/trailing spaces will be rejected. The risk is if for some reason we have " "* in database field it will be rejected as valid password, fixing it will be re-set password by user to empty one. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258867 Change-Id: I2ca15519ec245efd82e71f2ec39abd4ca1fe81c2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ca15519ec245efd82e71f2ec39abd4ca1fe81c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Engine: Hide bad 'Done' message for PM test
by oliel＠redhat.com 07 Sep '15

07 Sep '15

Ori Liel has submitted this change and it was merged. Change subject: Engine: Hide bad 'Done' message for PM test ...................................................................... Engine: Hide bad 'Done' message for PM test VSDM returns 'Done' by default for fencing operations. This is not useful and appending it to log messages results in a confusing message. So if the message is 'Done', it's better to ignore it. This patch does that. Bug-Url: https://bugzilla.redhat.com/1203741 Change-Id: Icd4a0a788fba25c491f693747f00f4c64f4413d4 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceOperationResult.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved; Passed CI tests Martin Peřina: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd4a0a788fba25c491f693747f00f4c64f4413d4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Moved getDiskDao to AuditLogBase
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Moved getDiskDao to AuditLogBase ...................................................................... core: Moved getDiskDao to AuditLogBase Change-Id: Ie4efb14e019294a06f5ac63016dd0200551b299e Bug-Url: https://bugzilla.redhat.com/1147860 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 6 files changed, 5 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/45775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4efb14e019294a06f5ac63016dd0200551b299e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: setup: During cleanup drop only engine schemas
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: setup: During cleanup drop only engine schemas ...................................................................... setup: During cleanup drop only engine schemas During engine-cleanup execution drop only schemas owned by engine database user. Change-Id: I07698c5f23fd7ebda09d348c5dfdbf3acfda5509 Bug-Url: https://bugzilla.redhat.com/1259345 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07698c5f23fd7ebda09d348c5dfdbf3acfda5509 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Engine: Improve PM Message when No Proxy Found
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: Engine: Improve PM Message when No Proxy Found ...................................................................... Engine: Improve PM Message when No Proxy Found Bug-Url: http://bugzilla.redhat.com/1251971 Change-Id: I0fcb20d0404948bb6d286929f94e7261077831fb Signed-off-by: Ori Liel <oliel(a)redhat.com> (cherry picked from commit 94e9bf1a6c7c5ddec721b3aab8b119b41e41d0f7) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Ori Liel: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fcb20d0404948bb6d286929f94e7261077831fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Populate correctly host.spm
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Populate correctly host.spm ...................................................................... restapi: Populate correctly host.spm The "host.spm" element isn't correctly populated when a host representation is generated. This patch fixes that. Change-Id: Iacb694abdc709b0a166b23cdbc95e12799ea91dd Bug-Url: https://bugzilla.redhat.com/1136061 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 77383cac5ecadf45911259a1d90cbb67c943fc7e) --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45790 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacb694abdc709b0a166b23cdbc95e12799ea91dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: scheduler: Prevent passthrough of network-used devices
by tnisan＠redhat.com 07 Sep '15

07 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: scheduler: Prevent passthrough of network-used devices ...................................................................... scheduler: Prevent passthrough of network-used devices Renamed HostNicVfsConfigHelper -> NetworkDeviceHelper and added the isDeviceNetworkFree method. The HostDeviceManager now utilizes this method in its check if VM can be run on a given host. The check is being made in HostDeviceFilterPolicyUnit and also in canDoAction of RunVmCommand in case the user disables this policy unit. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230775 Change-Id: I870ac5bdbcbdffc5eacc2e2051219b60ea888b97 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateHostNicVfsConfigCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HostDeviceFilterPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VfsConfigValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImplTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/UpdateHostNicVfsConfigCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImplTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VfsConfigValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 22 files changed, 182 insertions(+), 93 deletions(-) Approvals: Alona Kaplan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I870ac5bdbcbdffc5eacc2e2051219b60ea888b97 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: Localize ArchitectureType.undefined
by tjelinek＠redhat.com 07 Sep '15

07 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Localize ArchitectureType.undefined ...................................................................... frontend: Localize ArchitectureType.undefined Change-Id: Ib0ab3ed150e4a09f8f96e204e7ea43c4a418a124 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1089607 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 3 files changed, 14 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/45791 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0ab3ed150e4a09f8f96e204e7ea43c4a418a124 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0