September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Enable ConfigureConsoleOptionsQuery for paused VMs
by ofrenkel＠redhat.com 06 Sep '15

06 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Enable ConfigureConsoleOptionsQuery for paused VMs ...................................................................... core: Enable ConfigureConsoleOptionsQuery for paused VMs ConfigureConsoleOptionsQuery had too strict VM status requirements that allowed to open console only for VMs in Running state. Added VMStatus.isQualifiedForConsoleConnect() method that returns true for any VM status that is qualified for opening console connection. This method is used in both frontend and backend. Change-Id: I56e0c0e1230fa7dc7fdb1722299672dbb8ab5eaa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234932 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java 4 files changed, 16 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56e0c0e1230fa7dc7fdb1722299672dbb8ab5eaa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Move instance initialization into @PostConstruct
by masayag＠redhat.com 06 Sep '15

06 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Move instance initialization into @PostConstruct ...................................................................... core: Move instance initialization into @PostConstruct Moves instance initialization which uses instances of external classes outside constructor into @PostConstruct method so those external instances can be made CDI beans and injected into CommandBase in later patches. Change-Id: Ia8ed25364e0fcef82d01465b91eba243cbbe610c Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQueryTest.java 6 files changed, 41 insertions(+), 21 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8ed25364e0fcef82d01465b91eba243cbbe610c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: acting on cluster specific management network
by sbonazzo＠redhat.com 04 Sep '15

04 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: acting on cluster specific management network ...................................................................... packaging: setup: acting on cluster specific management network Network are datacenter specific. If more than one dacenter is in the engine, the same name could be used for more than one network so trying to fetch the managemnt network via its name only could result in ovirtsdk.infrastructure.errors.AmbiguousQueryError Acting just on the selected cluster avoids it Change-Id: Ib8b6d2f121fb383f97e293b678aa8791a7115ed5 Bug-Url: https://bugzilla.redhat.com/1260143 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 22 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8b6d2f121fb383f97e293b678aa8791a7115ed5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: acting on cluster specific management network
by sbonazzo＠redhat.com 04 Sep '15

04 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: acting on cluster specific management network ...................................................................... packaging: setup: acting on cluster specific management network Network are datacenter specific. If more than one dacenter is in the engine, the same name could be used for more than one network so trying to fetch the managemnt network via its name only could result in ovirtsdk.infrastructure.errors.AmbiguousQueryError Acting just on the selected cluster avoids it Change-Id: Ib8b6d2f121fb383f97e293b678aa8791a7115ed5 Bug-Url: https://bugzilla.redhat.com/1251912 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 23 insertions(+), 22 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44801 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8b6d2f121fb383f97e293b678aa8791a7115ed5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: Code improvements
by vszocs＠redhat.com 04 Sep '15

04 Sep '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Code improvements ...................................................................... webadmin,userportal: Code improvements 1. [GwtDynamicHostPageServlet] - minor JavaDoc updates, ATTR_ENGINE_SESSION_TIMEOUT moved into MD5Attributes, added MD5Attributes.ATTR_ENGINE_RPM_VERSION to inject ProductRPMVersion config value into the host page 2. [AsyncDataProvider] - removed getRpmVersion method since the corresponding config value is now injected into the host page (avoiding further async requests) 3. [EngineRpmVersionData] - overlays JS object containing the corresponding config value 4. [JsSingleValueStringObject] - base class to overlay JS objects containing single value property, for example: { value: "anything" } 5. [EngineRpmVersionData, BaseContextPathData, UiModeData, SSOTokenData, VisibleLocalesInfoData] - all of these now extend JsSingleValueStringObject 6. [HeaderPresenterWidget] - removed dead code Change-Id: I18628254aa7810a763fcedc76c76446d961ae3c1 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/BaseContextPathData.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/JsSingleValueStringObject.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/SSOTokenData.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/restapi/EngineSessionTimeoutData.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/restapi/RestApiSessionManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/EngineRpmVersionData.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/VisibleLocalesInfoData.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AboutPopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AboutPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uimode/UiModeData.java 26 files changed, 185 insertions(+), 190 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/43869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18628254aa7810a763fcedc76c76446d961ae3c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Vdsm check-patch needs >fc21 slaves
by dcaroest＠redhat.com 04 Sep '15

04 Sep '15

David Caro has submitted this change and it was merged. Change subject: Vdsm check-patch needs >fc21 slaves ...................................................................... Vdsm check-patch needs >fc21 slaves Change-Id: Ic4eeef5e9b719a31df0d4f45dddfa3e9fcfff63e Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/45716 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4eeef5e9b719a31df0d4f45dddfa3e9fcfff63e Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-guest-agent[ovirt-3.6]: 1.0.11 version bump
by vfeenstr＠redhat.com 04 Sep '15

04 Sep '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: 1.0.11 version bump ...................................................................... 1.0.11 version bump Change-Id: I971363830f76f1022562ca6ed2801e515e62da2c Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit 9d75015dc6119800198f8321198faf75c633261d) --- M ChangeLog M configure.ac M debian/changelog M debian/copyright M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec 6 files changed, 357 insertions(+), 6 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I971363830f76f1022562ca6ed2801e515e62da2c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[ovirt-3.6]: Exclude mount targets which are files
by vfeenstr＠redhat.com 04 Sep '15

04 Sep '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Exclude mount targets which are files ...................................................................... Exclude mount targets which are files Bug-Url: https://bugzilla.redhat.com/1252467 Change-Id: I819bd8d86bbab8657aeaea745319145e39133ce3 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit a683d840bb795942df164de11516532f7f83d294) --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I819bd8d86bbab8657aeaea745319145e39133ce3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Exclude mount targets which are files
by vfeenstr＠redhat.com 04 Sep '15

04 Sep '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Exclude mount targets which are files ...................................................................... Exclude mount targets which are files Bug-Url: https://bugzilla.redhat.com/1252467 Change-Id: I819bd8d86bbab8657aeaea745319145e39133ce3 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I819bd8d86bbab8657aeaea745319145e39133ce3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix checking compatibility of proxy host and fencing p...
by oourfali＠redhat.com 04 Sep '15

04 Sep '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix checking compatibility of proxy host and fencing policy ...................................................................... core: Fix checking compatibility of proxy host and fencing policy Fixes the issue when checking compatibility of fence proxy host with fencing policy caused by BZ1229177. It changes the comparison using following rule: If at least one version contained in host supported cluster levels is higher or equals to minimal required version for the fencing policy of the cluster, then host can be used as a proxy. Change-Id: I94cc1419186dfd3ab557143e41b3d3f3772f614a Bug-Url: https://bugzilla.redhat.com/1257610 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceProxyLocator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceProxyLocatorTest.java 2 files changed, 25 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45744 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94cc1419186dfd3ab557143e41b3d3f3772f614a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0