September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix checking compatibility of proxy host and fencing p...
by oourfali＠redhat.com 03 Sep '15

03 Sep '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix checking compatibility of proxy host and fencing policy ...................................................................... core: Fix checking compatibility of proxy host and fencing policy Fixes the issue when checking compatibility of fence proxy host with fencing policy caused by BZ1229177. It changes the comparison using following rule: If at least one version contained in host supported cluster levels is higher or equals to minimal required version for the fencing policy of the cluster, then host can be used as a proxy. Change-Id: I94cc1419186dfd3ab557143e41b3d3f3772f614a Bug-Url: https://bugzilla.redhat.com/1257610 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceProxyLocator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceProxyLocatorTest.java 2 files changed, 25 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94cc1419186dfd3ab557143e41b3d3f3772f614a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: acting on cluster specific management network
by sbonazzo＠redhat.com 03 Sep '15

03 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: acting on cluster specific management network ...................................................................... packaging: setup: acting on cluster specific management network Network are datacenter specific. If more than one dacenter is in the engine, the same name could be used for more than one network so trying to fetch the managemnt network via its name only could result in ovirtsdk.infrastructure.errors.AmbiguousQueryError Acting just on the selected cluster avoids it Change-Id: Ib8b6d2f121fb383f97e293b678aa8791a7115ed5 Bug-Url: https://bugzilla.redhat.com/1251912 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 23 insertions(+), 22 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44798 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8b6d2f121fb383f97e293b678aa8791a7115ed5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: build: oVirt Live 3.5.4
by sbonazzo＠redhat.com 03 Sep '15

03 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 3.5.4 ...................................................................... build: oVirt Live 3.5.4 Change-Id: I046d5fbce1352bcf6497976dabbd769beac59b0f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I046d5fbce1352bcf6497976dabbd769beac59b0f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: RandomUtils line breaks
by amureini＠redhat.com 03 Sep '15

03 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RandomUtils line breaks ...................................................................... core: RandomUtils line breaks Remove redundant line breaks that only hinder readability instead of improving it. Change-Id: I4cd18b94cb602b933143a79dda7f31931586ca26 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 7 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/45679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cd18b94cb602b933143a79dda7f31931586ca26 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: RandomUtils super calls
by amureini＠redhat.com 03 Sep '15

03 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RandomUtils super calls ...................................................................... core: RandomUtils super calls Removed redundant calls to super. Using this modifier has no meaning in the context that was removed, as these method are polymorphic anyway. Change-Id: Idec45495f52865451b70e65f7379f20d6c1bf99d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/45678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idec45495f52865451b70e65f7379f20d6c1bf99d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: RandomUtils main javadoc
by amureini＠redhat.com 03 Sep '15

03 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RandomUtils main javadoc ...................................................................... core: RandomUtils main javadoc Fixed comment regarding pickRandom's functionality. Change-Id: Id4056fafc8ab70c2ae458fca1e63a14dc57ee12e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/45677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4056fafc8ab70c2ae458fca1e63a14dc57ee12e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: RandomUtils {@code}
by amureini＠redhat.com 03 Sep '15

03 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RandomUtils {@code} ...................................................................... core: RandomUtils {@code} Clean up the javadoc by using proper javadoc {@code} annotations instead of inlining HTML <code> tags. Change-Id: Ie60eeae26f1cfdad24b527b0882ad7206a15a175 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 26 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/45676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie60eeae26f1cfdad24b527b0882ad7206a15a175 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix RandomUtils#nextPropertyString
by amureini＠redhat.com 03 Sep '15

03 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix RandomUtils#nextPropertyString ...................................................................... core: Fix RandomUtils#nextPropertyString nextPropertyString was implemented incorrectly, with a misunderstanding of how RandomStringUtils works, in a way that may have returned illegal characters such as '[', ']' and ' '. This patch fixes it so it really returns strings that only contain alpha-numeric characters, underscores ('_') and periods ('.'). Change-Id: Ia98c6b78e3ca958779d413e06ced650f9740589d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 1 file changed, 18 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/45675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia98c6b78e3ca958779d413e06ced650f9740589d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: chain icon moves the rest of the widgets
by tjelinek＠redhat.com 03 Sep '15

03 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: chain icon moves the rest of the widgets ...................................................................... webadmin: chain icon moves the rest of the widgets Made some amendments making the right side of the widgets consistently sized across VM based dialogs Change-Id: I903e6bf99d42cadc88cd89680953acba6fe9a2d5 Bug-Url: https://bugzilla.redhat.com/1166059 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelDetachableWidgetWithInfo.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidgetWithLabel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 6 files changed, 29 insertions(+), 26 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I903e6bf99d42cadc88cd89680953acba6fe9a2d5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: remove power8e cpu type
by tnisan＠redhat.com 03 Sep '15

03 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: remove power8e cpu type ...................................................................... core: remove power8e cpu type Change-Id: Ic0571268a139afd4b99620b9ec4a0427dfcd9b78 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254098 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1800_remove_power8e_cpu_type.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0571268a139afd4b99620b9ec4a0427dfcd9b78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0