January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Add "unless" as a reserved word that starts a block
by juan.hernandez＠redhat.com 15 Jan '16

15 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add "unless" as a reserved word that starts a block ...................................................................... Add "unless" as a reserved word that starts a block Currently the class used to generate Ruby source code doesn't take into account that "unless" can be used to begin a block. As a result when this construct is used the generated source code isn't formatted correctly. This patch fixes that issue. Change-Id: I9f6daa6ef9e3dcebf31131153cbcad5fc1780a5f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/RubyBuffer.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f6daa6ef9e3dcebf31131153cbcad5fc1780a5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add suport for "Add" and action methods
by juan.hernandez＠redhat.com 15 Jan '16

15 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add suport for "Add" and action methods ...................................................................... Add suport for "Add" and action methods This patch adds support for the "Add" and action methods, as both use the HTTP POST method. It also adds examples that show how to use these operations. Change-Id: I8abda64733bde19b6cef7907e32044fda4c61a5f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java A sdk/examples/add_cluster.rb A sdk/examples/add_data_center.rb A sdk/examples/add_host.rb A sdk/examples/add_nfs_data_storage_domain.rb A sdk/examples/add_nfs_iso_storage_domain.rb A sdk/examples/add_vm.rb A sdk/examples/add_vm_disk.rb A sdk/examples/add_vm_nic.rb A sdk/examples/attach_nfs_data_storage_domain.rb A sdk/examples/attach_nfs_iso_storage_domain.rb M sdk/examples/list_vms.rb M sdk/examples/remove_vm.rb M sdk/examples/search_vms.rb A sdk/examples/start_vm.rb A sdk/examples/stop_vm.rb M sdk/lib/ovirt/sdk/v4/connection.rb 17 files changed, 789 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8abda64733bde19b6cef7907e32044fda4c61a5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add initial tests for relevant services
by juan.hernandez＠redhat.com 15 Jan '16

15 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add initial tests for relevant services ...................................................................... Add initial tests for relevant services This patch adds some simple tests for the services that are more relevant, like the data centers service, the clusters service and the storage domains service. Change-Id: I867045e7df814e6108fc610d757cb67a3b46b88f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/spec/clusters_service_spec.rb A sdk/spec/data_centers_service_spec.rb A sdk/spec/storage_domains_service_spec.rb 3 files changed, 192 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I867045e7df814e6108fc610d757cb67a3b46b88f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add the method to write integers
by juan.hernandez＠redhat.com 15 Jan '16

15 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add the method to write integers ...................................................................... Add the method to write integers This patch adds the "XmlWriter.write_integer" method and a couple of simple unit tests, just to verify that it exists. Change-Id: I64a8e8d8721708a3655b3f5c3cef6b7836720378 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirt/sdk/v4/xml_writer.rb M sdk/spec/xml_writer_spec.rb 2 files changed, 35 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64a8e8d8721708a3655b3f5c3cef6b7836720378 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Hiding spurious misleading message
by dcaro＠redhat.com 15 Jan '16

15 Jan '16

David Caro has submitted this change and it was merged. Change subject: Hiding spurious misleading message ...................................................................... Hiding spurious misleading message We don't really care what's the output of the touch, but usually adds an ugly error message that's not meaningful Change-Id: I1938c2ed31c8bc6ada47721531ffd5feafdf586e Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/mock_setup.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Barak Korren: Looks good to me Eyal Edri: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/51815 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1938c2ed31c8bc6ada47721531ffd5feafdf586e Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: imgbased: Only build el7 artifacts
by dcaro＠redhat.com 15 Jan '16

15 Jan '16

David Caro has submitted this change and it was merged. Change subject: imgbased: Only build el7 artifacts ...................................................................... imgbased: Only build el7 artifacts Currently imgbased is used on el7 only, thus only build those artifacts. Change-Id: I2df258170198513ab4304e14adb33bbb955f2ba8 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M jobs/confs/projects/imgbased/imgbased.yaml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge Ryan Barry: Looks good to me -- To view, visit https://gerrit.ovirt.org/51896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2df258170198513ab4304e14adb33bbb955f2ba8 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unnecessary ternary operator
by amureini＠redhat.com 15 Jan '16

15 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unnecessary ternary operator ...................................................................... core: Remove unnecessary ternary operator DestroyImageCheckCommand is part of the Live Merge flow and has no other callers besides RemoveSnapshotSingleDiskLiveCommand; as such we can see that the list used in getParameters().getImageList() was created in the caller's buildDestroyImageParameters and cannot be null. Change-Id: I785e71c277ee76e9fde358fd80e1cfd034279cbe Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I785e71c277ee76e9fde358fd80e1cfd034279cbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add rubygems-devel to the list of packages used to build art...
by juan.hernandez＠redhat.com 15 Jan '16

15 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add rubygems-devel to the list of packages used to build artifacts ...................................................................... Add rubygems-devel to the list of packages used to build artifacts This patch adds the "rubygems-devel" package to the list of packages required to run the "build-artifacts.sh" script, as it is a requirement to build the RPMs. Change-Id: I2d409529af69df10f73e8dbc0bf1cf36fe40a925 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M automation/build-artifacts.packages 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d409529af69df10f73e8dbc0bf1cf36fe40a925 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add the RPM tools to the packages used to build artifacts
by juan.hernandez＠redhat.com 15 Jan '16

15 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add the RPM tools to the packages used to build artifacts ...................................................................... Add the RPM tools to the packages used to build artifacts This patch adds the packages "rpmdevtools" and "rpm-build" to the list of packages required to run the "build-artifacts.sh" script, as they are needed in order to build RPMs. Change-Id: I80172a9fd396cf36c722006a01b330f51cc32b9a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M automation/build-artifacts.packages 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80172a9fd396cf36c722006a01b330f51cc32b9a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Change automation to build RPM packages
by juan.hernandez＠redhat.com 15 Jan '16

15 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Change automation to build RPM packages ...................................................................... Change automation to build RPM packages This patch changes the automation scripts so that in addition to the .gem files they also build the .rpm files. Change-Id: I518c146876d5238faacbd46b2933de789defc418 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M automation/build-artifacts.sh 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I518c146876d5238faacbd46b2933de789defc418 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0