January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddDiskCommand's singletonList usage
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommand's singletonList usage ...................................................................... core: AddDiskCommand's singletonList usage Use Collections.singletonList instead of Arrays.asList for the (ever so slight) performance improvement. Change-Id: I1ec162998b91ad2d42e2567dc1005395f534dc7e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ec162998b91ad2d42e2567dc1005395f534dc7e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: AbstractBackendCollectionResource#asString
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: AbstractBackendCollectionResource#asString ...................................................................... restapi: AbstractBackendCollectionResource#asString Remove method unused AbstractBackendCollectionResource#asString(VdcReturnValueBase). Change-Id: Icb188ab8a8035bc9d2d6088948a79250695f5e28 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb188ab8a8035bc9d2d6088948a79250695f5e28 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: BaseBackednResource modifiers
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: BaseBackednResource modifiers ...................................................................... restapi: BaseBackednResource modifiers Made USER_FILTER_HEADER final as per Java's best practices for constants. Change-Id: Ic6a9b0ad516612e1cb824f688436a4339fd6a12d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6a9b0ad516612e1cb824f688436a4339fd6a12d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AbstractSubTabTree methods
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AbstractSubTabTree methods ...................................................................... webadmin: AbstractSubTabTree methods Removed unused methods isRootSelectionEnabled() and isNodeSelectionEnabled(). Change-Id: I487fedf0df8dbe886368598796ef8cd47bec7ae3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabTree.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Tal Nisan: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/52240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I487fedf0df8dbe886368598796ef8cd47bec7ae3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: BaseBackendResource commented out code
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: BaseBackendResource commented out code ...................................................................... restapi: BaseBackendResource commented out code Removed commented out code. History should be tracked by the SCM, not by commenting out old code. Change-Id: Id89af65807e86966cba4a6fd4e839a7e7177e1ae Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id89af65807e86966cba4a6fd4e839a7e7177e1ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Remove BaseBackendResource#combine
by amureini＠redhat.com 18 Jan '16

18 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Remove BaseBackendResource#combine ...................................................................... restapi: Remove BaseBackendResource#combine Removed unused method. Change-Id: Ic1322d17a8314fddc93a211b6b2d687a98d6fb7c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1322d17a8314fddc93a211b6b2d687a98d6fb7c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Fix NPE in Glance import image as template
by tnisan＠redhat.com 18 Jan '16

18 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Fix NPE in Glance import image as template ...................................................................... engine: Fix NPE in Glance import image as template In AddVmTemplateCommand, the vm variable is not available in the flow of importing image as template from Glance. Using it will cause a NullPointerException. Instead of using the vm for getting the compatibility version, we use the master VM from the parameters or the cluster. Change-Id: I066e33fc1414675799fe3ffb655bfe4204e1ba3d Bug-Url: https://bugzilla.redhat.com/1299233 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I066e33fc1414675799fe3ffb655bfe4204e1ba3d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core, webadmin: Not validating HostNetworkQos values
by tnisan＠redhat.com 18 Jan '16

18 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core,webadmin: Not validating HostNetworkQos values ...................................................................... core,webadmin: Not validating HostNetworkQos values • Missing @Valid • added code so that HostSetupNetworksCommand validates NetworkAttachment and Bonds instances passed in its parameters class. Change-Id: I50cf6787bdc43d2dba6e726d62d13f08d3a5ab47 Bug-Url: https://bugzilla.redhat.com/1271220 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/businessentities/SeparateNewAndModifiedInstances.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 71 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50cf6787bdc43d2dba6e726d62d13f08d3a5ab47 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add "connection" attribute to structs and lists
by juan.hernandez＠redhat.com 18 Jan '16

18 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add "connection" attribute to structs and lists ...................................................................... Add "connection" attribute to structs and lists This patch adds a "connection" attribute to struct and list types. It will contain a reference to the connection that created the object, and will be used by later patches to implement support for following links. Change-Id: Ic6d7c1768c232dac3159d560a1bb5852c550d107 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/lib/ovirt/sdk/v4/types/list.rb M sdk/lib/ovirt/sdk/v4/types/struct.rb M sdk/spec/vm_reader_spec.rb 5 files changed, 89 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6d7c1768c232dac3159d560a1bb5852c550d107 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add "href" attribute to structs and lists
by juan.hernandez＠redhat.com 18 Jan '16

18 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add "href" attribute to structs and lists ...................................................................... Add "href" attribute to structs and lists This patch adds the "href" attribute to struct and list types, and mofies the generator of the XML readers and writers so that they handle this attribute. Change-Id: I926d32c97a0eff2da624622e522118115f0d947b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java M sdk/lib/ovirt/sdk/v4/types/list.rb M sdk/lib/ovirt/sdk/v4/types/struct.rb M sdk/spec/vm_reader_spec.rb M sdk/spec/vm_writer_spec.rb 6 files changed, 141 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51914 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I926d32c97a0eff2da624622e522118115f0d947b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0