Change in ovirt-engine-sdk-ruby[master]: Use "List" instead of "Array"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Use "List" instead of "Array"
......................................................................
Use "List" instead of "Array"
Currently when a list of objects is received from the server it is
converted to an instance of the Ruby "Array" class. This patch
introduces a new "List" class, that extends the Ruby "Array" class,
currently with no methods. List of objects returned from the SDK will be
of this type. Later patches will take advantage of this "List" class,
for example to add methods to support following links.
The patch also renames the base "Type" class to "Struct", as that better
reflects the difference between struct and list types.
Change-Id: I1cbcd1eab8bd8b95d7d4a0e0537ccd8a47e81f64
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/RubyNames.java
M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java
C sdk/lib/ovirt/sdk/v4/types/list.rb
R sdk/lib/ovirt/sdk/v4/types/struct.rb
M sdk/spec/vm_reader_spec.rb
A sdk/spec/vm_spec.rb
7 files changed, 79 insertions(+), 33 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51913
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cbcd1eab8bd8b95d7d4a0e0537ccd8a47e81f64
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-setup[master]: storage: resetting spUUID to a random value only if really n...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: resetting spUUID to a random value only if really needed
......................................................................
storage: resetting spUUID to a random value only if really needed
hosted-engine-setup generates answer file with a blank SP UUID
for additional hosts cause it correctly disconnected its SD
from the boostrap storage pool.
If we want to use the answerfile for not-interactively replaing
the scenario we need a valid spUUID value otherwise we are not
able to create the bootstrap storage pool.
On the other side, passing an answerfile via CLI is a valid
alternative instead of download it from another host via scp.
And in that case we should honour the BLANK UUID.
So resetting spUUID to blank only if really needed to create
a new boostrap storage pool.
Change-Id: I67569bc6902a176565269f2bcbec569b51549181
Bug-Url: https://bugzilla.redhat.com/1277010
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 11 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51853
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67569bc6902a176565269f2bcbec569b51549181
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.2]: core: hosted-engine: set the os type to linux on import
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: hosted-engine: set the os type to linux on import
......................................................................
core: hosted-engine: set the os type to linux on import
The imported VM is obviously linux so setting the type the the most
basic linux os instead of "other"
This fixes a bug when editing the VM because the values of the console
are in the limits of linux and not valid for "other" os.
Change-Id: I3520d6d0501e82aa135bdc896f8d994e02e30d74
Bug-Url: https://bugzilla.redhat.com/1158096
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Roy Golan: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51932
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3520d6d0501e82aa135bdc896f8d994e02e30d74
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.2]: core: make OsRepository injectable using @Inject
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: make OsRepository injectable using @Inject
......................................................................
core: make OsRepository injectable using @Inject
Created a producer method to retun the sole enum member implementing the
interface.
This is to reduce usage and stream line tests of OsRepository
dependents and limit the use of SimpleDependencyInjector
Change-Id: I707349d9db85f9ff5d1d77af89f2b2ff50ee5579
Bug-Url: https://bugzilla.redhat.com/1158096
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryProducer.java
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51931
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I707349d9db85f9ff5d1d77af89f2b2ff50ee5579
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix update of virtio_scsi.enabled
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Fix update of virtio_scsi.enabled
......................................................................
restapi: Fix update of virtio_scsi.enabled
Currently the "virtio_scsi.enabled" property is ignored by the update
operations of virtual machines, templates and instance types. This patch
fixes that.
Change-Id: Id016e1006c5e07aacf80e6661e30b61d0c20a128
Bug-Url: https://bugzilla.redhat.com/1298489
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
3 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51934
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id016e1006c5e07aacf80e6661e30b61d0c20a128
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: Upgrade to CDI 1.2
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Upgrade to CDI 1.2
......................................................................
core: Upgrade to CDI 1.2
Removes hacks needed to support both CDI 1.0 (EAP6) and CDI 1.1+
(WildFly 8+). From now on we support only CDI 1.2.
Change-Id: I3fec8f22a633dcf1fe866fab29cd26c2fa5a9e3d
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml
M backend/manager/modules/dal/src/main/resources/META-INF/beans.xml
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/CdiIntegration.java
M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
M backend/manager/modules/utils/src/main/resources/META-INF/beans.xml
M pom.xml
6 files changed, 23 insertions(+), 42 deletions(-)
Approvals:
Martin Peřina: Verified; Passed CI tests
Juan Hernandez: Looks good to me, but someone else must approve
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48305
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fec8f22a633dcf1fe866fab29cd26c2fa5a9e3d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: Upgrade to WildFly 10
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Upgrade to WildFly 10
......................................................................
core: Upgrade to WildFly 10
1. Adds a requirement for WildFly 10 and corresponding WildFly overlay
package.
2. Updates oVirt WildFly service configuration file to match latest
updates in WildFly 10
3. Updates developer docs
Change-Id: Ic230dcd4d9f138f9a125f7ed97b5fbaa358fe8a3
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M README.developer
M ovirt-engine.spec.in
M packaging/services/ovirt-engine/ovirt-engine.xml.in
3 files changed, 78 insertions(+), 51 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48209
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic230dcd4d9f138f9a125f7ed97b5fbaa358fe8a3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: Drop EAP6 support
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Drop EAP6 support
......................................................................
core: Drop EAP6 support
Drops EAP6 support from ovirt-engine.xml.in
Change-Id: Ia2a46bd58106afed634c9ea059e8aefc5f7ccc25
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.xml.in
1 file changed, 0 insertions(+), 145 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2a46bd58106afed634c9ea059e8aefc5f7ccc25
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: webadmin: Added CPU Profiles Roles to the RoleTree
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: webadmin: Added CPU Profiles Roles to the RoleTree
......................................................................
webadmin: Added CPU Profiles Roles to the RoleTree
CPU profile roles were added to the Role Tree in the UI. The roles are:
CpuProfileCreator and CpuProfileOperator.
Change-Id: Ib5e8b2b11a882fadadd1e6261fb574f871d4ec4c
Bug-Url: https://bugzilla.redhat.com/1143869
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
4 files changed, 49 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Tomer Saban: Verified
--
To view, visit https://gerrit.ovirt.org/51141
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5e8b2b11a882fadadd1e6261fb574f871d4ec4c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: fixing search engine queries
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: fixing search engine queries
......................................................................
core: fixing search engine queries
Search engine queries related to a view named clusters_storage_domain
while the name should be cluster_storage_domain
Change-Id: I6eaf6b8141d08df26a1815ecb4c9768baaa76a61
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
3 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51929
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6eaf6b8141d08df26a1815ecb4c9768baaa76a61
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months