January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: Fixed New Template dialog size
by derez＠redhat.com 17 Jan '16

17 Jan '16

Daniel Erez has submitted this change and it was merged. Change subject: userportal,webadmin: Fixed New Template dialog size ...................................................................... userportal,webadmin: Fixed New Template dialog size Changed the size of the New Template dialog in the user portal so elements won't slide off it. Change-Id: I28758fce935c6057d328f387e0838a035d6faa0f Bug-Url: https://bugzilla.redhat.com/1190142 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/51225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28758fce935c6057d328f387e0838a035d6faa0f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add VM compatibility version to ChangeVmClusterValidator
by ahadas＠redhat.com 17 Jan '16

17 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Add VM compatibility version to ChangeVmClusterValidator ...................................................................... core: Add VM compatibility version to ChangeVmClusterValidator This patch is part of the series introducing VM compatibility version feature. This feature allows to customize a VM to its own compatibility version unrelated to one of the cluster. VM compatibility version is limited by Data Center and capabilities of the host the VM will be able to run on. This patch adds VM compatibility version support to ChangeVmClusterValidator. Change-Id: Ic5e35963ba47aefd17a69495ed4f4187abbc34ad Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeVMClusterParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 7 files changed, 51 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5e35963ba47aefd17a69495ed4f4187abbc34ad Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: hosted-engine: missing config from engine-config
by tnisan＠redhat.com 17 Jan '16

17 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: hosted-engine: missing config from engine-config ...................................................................... core: hosted-engine: missing config from engine-config The HostedEngineStorageDomainName was missing from the DB and the engine-config properties. Change-Id: I99d39f73ebcf4eca3a3891c371c246660dda5611 Bug-Url: https://bugzilla.redhat.com/1290478 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Eli Mesika: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/51342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d39f73ebcf4eca3a3891c371c246660dda5611 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: hosted-engine: set the os type to linux on import
by tnisan＠redhat.com 17 Jan '16

17 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: hosted-engine: set the os type to linux on import ...................................................................... core: hosted-engine: set the os type to linux on import The imported VM is obviously linux so setting the type the the most basic linux os instead of "other" This fixes a bug when editing the VM because the values of the console are in the limits of linux and not valid for "other" os. Change-Id: I3520d6d0501e82aa135bdc896f8d994e02e30d74 Bug-Url: https://bugzilla.redhat.com/1158096 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Roy Golan: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3520d6d0501e82aa135bdc896f8d994e02e30d74 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: make OsRepository injectable using @Inject
by tnisan＠redhat.com 17 Jan '16

17 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: make OsRepository injectable using @Inject ...................................................................... core: make OsRepository injectable using @Inject Created a producer method to retun the sole enum member implementing the interface. This is to reduce usage and stream line tests of OsRepository dependents and limit the use of SimpleDependencyInjector Change-Id: I707349d9db85f9ff5d1d77af89f2b2ff50ee5579 Bug-Url: https://bugzilla.redhat.com/1158096 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryProducer.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I707349d9db85f9ff5d1d77af89f2b2ff50ee5579 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactoring vm-analyzer
by ahadas＠redhat.com 17 Jan '16

17 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refactoring vm-analyzer ...................................................................... core: refactoring vm-analyzer Refactoring VmAnalyzer#removeVmsFromCache: 1. Rename to removeVmFromCache 2. Extract the surrounding 'if' check to the caller Change-Id: I08fa5d780c85ccddaf7571a6dc1066661ad6dd39 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 40 insertions(+), 40 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08fa5d780c85ccddaf7571a6dc1066661ad6dd39 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fixed indexing on upgrade script
by rgolan＠redhat.com 17 Jan '16

17 Jan '16

Roy Golan has submitted this change and it was merged. Change subject: core: Fixed indexing on upgrade script ...................................................................... core: Fixed indexing on upgrade script Removed the explicit mentioning of "USING btree" from an upgrade script. Change-Id: I817d57833630ac386c9fbdf70139439dbfc1be07 Bug-Url: https://bugzilla.redhat.com/1143869 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0190_create_index_cpu_profiles.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I817d57833630ac386c9fbdf70139439dbfc1be07 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactoring vm-analyzer
by ahadas＠redhat.com 17 Jan '16

17 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refactoring vm-analyzer ...................................................................... core: refactoring vm-analyzer Simplify VmAnalyzer#inMigrationTo Change-Id: Ibbbc827f1c6c7bc54383f603021b127933201b3f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbbc827f1c6c7bc54383f603021b127933201b3f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: wrong usage of DomainAdminPassword instead of AdminPas...
by tnisan＠redhat.com 17 Jan '16

17 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: wrong usage of DomainAdminPassword instead of AdminPassword ...................................................................... core: wrong usage of DomainAdminPassword instead of AdminPassword These xml contains the wrong entries. Change-Id: I35d871c56b029a7d1b0cc0ddfe2fba91992177ee Bug-Url: https://bugzilla.redhat.com/1264733 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.2k8 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35d871c56b029a7d1b0cc0ddfe2fba91992177ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: wrong usage of DomainAdminPassword instead of AdminPas...
by shavivi＠redhat.com 17 Jan '16

17 Jan '16

Shahar Havivi has submitted this change and it was merged. Change subject: core: wrong usage of DomainAdminPassword instead of AdminPassword ...................................................................... core: wrong usage of DomainAdminPassword instead of AdminPassword These xml contains the wrong entries. Change-Id: I35d871c56b029a7d1b0cc0ddfe2fba91992177ee Bug-Url: https://bugzilla.redhat.com/1264733 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.2k8 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35d871c56b029a7d1b0cc0ddfe2fba91992177ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0