Change in ovirt-engine[master]: core: Move InjectorRule to VdsBroker
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Move InjectorRule to VdsBroker
......................................................................
core: Move InjectorRule to VdsBroker
Moved InjectorRule to the same package as Injector (albeit in the test
source folder) so that any class that used the Injector can have a test
that uses the InjectorRule.
Change-Id: If663d0b227a9078e8dd3df38a523fc296a2e8986
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BaseCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkConfiguratorTest.java
R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/di/InjectorRule.java
6 files changed, 12 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/65738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If663d0b227a9078e8dd3df38a523fc296a2e8986
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Correct Tooltip Text for the HE Host Icon
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Correct Tooltip Text for the HE Host Icon
......................................................................
webadmin: Correct Tooltip Text for the HE Host Icon
This patch corrects the tooltip description for the hosted engine host
icon displayed in the Hosts main tab. The previous description was
incorrectly set to "Action Item".
Wiki page: http://www.ovirt.org/develop/release-management/features/hosted-engine-in...
Change-Id: I590d62f41b75cbaad3e5a51ad45ed034a756a101
Bug-Url: https://bugzilla.redhat.com/1363951
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
3 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Phillip Bailey: Verified
--
To view, visit https://gerrit.ovirt.org/65726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I590d62f41b75cbaad3e5a51ad45ed034a756a101
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix incorrect VM status icon in NUMA menu
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix incorrect VM status icon in NUMA menu
......................................................................
webadmin: Fix incorrect VM status icon in NUMA menu
This patch fixes an error wherein the status icon of a VM could be
out of sync with the actual status of the VM in the NUMA pinning menu.
Cause:
The instance of the VM model pulled from the database was being discarded
and the version currently stored in memory was being used to back the
VmNumaSupportModel instead.
Fix:
Use the model instance being returned from the database to back the
VmNumaSupportModel instead of the current model stored in memory.
Change-Id: Idd5ed3807d90dbd0ed6b76a31d6a1673e52eb988
Bug-Url: https://bugzilla.redhat.com/1147858
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VmNumaSupportModel.java
1 file changed, 1 insertion(+), 10 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Phillip Bailey: Verified
--
To view, visit https://gerrit.ovirt.org/65734
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd5ed3807d90dbd0ed6b76a31d6a1673e52eb988
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: userportal, webadmin: fix prune aspect
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal,webadmin: fix prune aspect
......................................................................
userportal,webadmin: fix prune aspect
- The DontPrune aspect had a bug that would cause
GWT compiler exceptions in certain situations. This
patch fixes that.
Change-Id: I08653b84f517c315599b05cbcb2f711265fbbcf9
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/gwtextension/DontPrune.java
1 file changed, 49 insertions(+), 49 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08653b84f517c315599b05cbcb2f711265fbbcf9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: webadmin, userportal: Overhaul UiCommonEditorDriver cleanup()...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Overhaul UiCommonEditorDriver cleanup() impl.
......................................................................
webadmin,userportal: Overhaul UiCommonEditorDriver cleanup() impl.
1. when cleaning up the edited Model object:
- emit `if (getObject() != null) { .. }` block only if we have
at least one statement to put in that block
2. when cleaning up the Editor instance:
- scan supertype hierarchy to find all fields (inherited too)
eligible for cleanup
3. refactor code by splitting into smaller methods
With this patch, there is no need for "supertype field cleanup",
the generated driver.cleanup() impl. takes care of that already.
Change-Id: Ia2aa2c259e97c623c81aed23fad892a11e4f28cb
Bug-Url: https://bugzilla.redhat.com/1368101
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/permissions/PermissionsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/PermissionsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java
7 files changed, 71 insertions(+), 40 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/65733
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2aa2c259e97c623c81aed23fad892a11e4f28cb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: random rng source implicit - configvalue
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: core: random rng source implicit - configvalue
......................................................................
core: random rng source implicit - configvalue
/dev/random rng source is automatically required from all hosts. Thus
"RANDOM" was removed from config list of possible values of ConfigValue
option "ClusterRequiredRngSourcesDefault".
Change-Id: I9081516d1827281429ff924467631151189ba9c3
Bug-Url: https://bugzilla.redhat.com/1337101
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
A packaging/dbscripts/upgrade/04_01_0350_update_ClusterRequiredRngSourcesDefault_random_removed.sql
M packaging/etc/engine-config/engine-config.properties
3 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65145
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9081516d1827281429ff924467631151189ba9c3
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in gerrit-admin[master]: Disable bug status change for draft patches
by sbendavi＠redhat.com
Shlomo Ben David has submitted this change and it was merged.
Change subject: Disable bug status change for draft patches
......................................................................
Disable bug status change for draft patches
We shouldn't change bug status (to POST) for drafts patches.
Change-Id: I3a28bafe1525a8f23dc11ef8a915490729ef64a3
Fixes: OVIRT-788
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/custom_hooks/update_tracker
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved
Gil Shinar: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a28bafe1525a8f23dc11ef8a915490729ef64a3
Gerrit-PatchSet: 1
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Require Ruby 2
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Require Ruby 2
......................................................................
Require Ruby 2
The SDK is no longer built or tested with Ruby 1.9, as it is now
unsupported and no longer available in the platforms supported by oVirt.
To make that explicit this patch changes the .gemspec file to indicate
that Ruby 2 is required.
Change-Id: Ia0f00ddae5acb26f053c72a3c3f12f8e2e776a5f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 38639f341c0c6690a61d07bb342907ee8cc1d75b)
---
M sdk/ovirt-engine-sdk.gemspec
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65718
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0f00ddae5acb26f053c72a3c3f12f8e2e776a5f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: restapi: Separate DNS server addresses with spaces
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Separate DNS server addresses with spaces
......................................................................
restapi: Separate DNS server addresses with spaces
Currently when a set of DNS servers is provided as the initialization
data for a virtual machine the result is concatenated and saved to the
database, without spaces. For example, if the following data passed to
the API:
<vm>
<initialization>
<cloud_init>
<network_configuration>
<dns>
<servers>
<host>
<address>192.168.0.1</address>
</host>
<host>
<address>192.168.0.2</address>
</host>
<host>
<address>192.168.0.3</address>
</host>
</servers>
</dns>
...
</network_configuration>
...
</cloud_init>
</initialization>
...
</vm>
Then the following is stored in the database (note that there are no
spaces separating the addresses):
192.168.0.1192.168.0.2192.168.0.3
And the following is added to the generated cloud-init configuration
file:
dns-nameservers 192.168.0.1192.168.0.2192.168.0.3
This way to provide the cloud-init configuration is deprecated, the
preferred way is to use directly the 'initialization' element:
<vm>
<initialization>
<dns_servers>192.168.0.1 192.168.0.2 192.168.0.3</dns_servers>
...
</initialization>
...
</vm>
But we should fix the issue anyhow. That is what this patch does.
Change-Id: I417bd7b1da69bda0d3b2879ee519ea4744fd35a9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65639
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I417bd7b1da69bda0d3b2879ee519ea4744fd35a9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Sven Kieske <svenkieskemittwald(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin, userportal: Fix JqueryUtils.getTextFromHtml
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix JqueryUtils.getTextFromHtml
......................................................................
webadmin,userportal: Fix JqueryUtils.getTextFromHtml
oVirt GWT UI currently uses jQuery version 1.11.3
Quote from jQuery upgrade guide [1]:
"
As of 1.9, a string is only considered to be HTML if it starts
with a less-than ("<") character.
..
If a string is known to be HTML but may start with arbitrary text
that is not an HTML tag, pass it to jQuery.parseHTML() which will
return an array of DOM nodes representing the markup.
"
[1] http://stage.jquery.com/upgrade-guide/1.9/#jquery-htmlstring-versus-jquer...
The problem was that jQuery treated `html` argument as selector
if the string didn't start with `<` character. Because of this,
the string failed to parse as selector, resulting in error like:
Syntax error, unrecognized expression: Dev. Size
This patch fixes the problem.
Change-Id: Ic939c09f3cb2e2a80b6ef2dd15cb759cbc27f946
Bug-Url: https://bugzilla.redhat.com/1386765
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/JqueryUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/65692
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic939c09f3cb2e2a80b6ef2dd15cb759cbc27f946
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
7 years, 6 months