Change in ovirt-engine[master]: webadmin: Restore SAN storage device size column header in n...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Restore SAN storage device size column header in new disk popup
......................................................................
webadmin: Restore SAN storage device size column header in new disk popup
Commit 96025168 fixed the JQuery error when creating a new disk among
other errors, it's not safe to restore the original column header
Change-Id: I7a779c7aa23e0014ae70a9928f6df89a60eefab9
Bug-Url: https://bugzilla.redhat.com/1383220
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a779c7aa23e0014ae70a9928f6df89a60eefab9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: backend: Migrate StoragePoolDomainHelper to CDI
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: backend: Migrate StoragePoolDomainHelper to CDI
......................................................................
backend: Migrate StoragePoolDomainHelper to CDI
Change-Id: I30d8bf4382dc1378cee673693b687c968a73ee57
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SetStoragePoolStatusCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java
3 files changed, 28 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63416
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30d8bf4382dc1378cee673693b687c968a73ee57
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[master]: Require Ruby 2
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Require Ruby 2
......................................................................
Require Ruby 2
The SDK is no longer built or tested with Ruby 1.9, as it is now
unsupported and no longer available in the platforms supported by oVirt.
To make that explicit this patch changes the .gemspec file to indicate
that Ruby 2 is required.
Change-Id: Ia0f00ddae5acb26f053c72a3c3f12f8e2e776a5f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/ovirt-engine-sdk.gemspec
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0f00ddae5acb26f053c72a3c3f12f8e2e776a5f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Remove InternalMigrateVmCommand
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Remove InternalMigrateVmCommand
......................................................................
core: Remove InternalMigrateVmCommand
The same functionality was merged to MigrateVmCommand,
which checks if it is run as an internal command.
Change-Id: I5c7dcdf4d2b6e1dc441bd7be9b8ddf4e00c795c4
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/InternalMigrateVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/async_tasks_map.py
9 files changed, 7 insertions(+), 85 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64962
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c7dcdf4d2b6e1dc441bd7be9b8ddf4e00c795c4
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Add migration reason to the audit log
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Add migration reason to the audit log
......................................................................
core: Add migration reason to the audit log
Change-Id: I053272b08ce6492a7cd062125b8692af588fa816
Bug-Url: https://bugzilla.redhat.com/1377632
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/BasicMigrationHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/MigrationHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/InternalMigrateVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
12 files changed, 60 insertions(+), 15 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/64277
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I053272b08ce6492a7cd062125b8692af588fa816
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: packaging: setup: Do not suggest to use password 'engine'
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Do not suggest to use password 'engine'
......................................................................
packaging: setup: Do not suggest to use password 'engine'
Change-Id: I344f0c3f5b78a25270c5ed6f5342a31e9ad8c0b9
Related-To: https://bugzilla.redhat.com/1384417
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/database.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I344f0c3f5b78a25270c5ed6f5342a31e9ad8c0b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Run Rubocop as part of the 'test' task
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Run Rubocop as part of the 'test' task
......................................................................
Run Rubocop as part of the 'test' task
This patch fixes most of the Rubocop complaints, and disables the cops
that can't be easily addressed, so that we can actually run Rubocop on
the source as part of the 'test' task.
Note that the generated code has also been improved to generate less
Rubocop complaints (1.9 hash syntax, no return, etc), but it isn't
actually checked because it takes too long, and some complaints (long
lines, for example) are hard to avoid.
Change-Id: Ia7268ae79cc55609b92c7cd17c71cfdcf9be9563
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 4f25dd3f80efca0954984e13e41a9608a5b3fb29)
---
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/VersionGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java
A sdk/.rubocop.yml
M sdk/Gemfile
M sdk/README.adoc
M sdk/Rakefile
M sdk/examples/add_cluster.rb
M sdk/examples/add_data_center.rb
M sdk/examples/add_group.rb
M sdk/examples/add_host.rb
M sdk/examples/add_independent_vm.rb
A sdk/examples/add_mac_pool.rb
M sdk/examples/add_nfs_data_storage_domain.rb
M sdk/examples/add_nfs_iso_storage_domain.rb
M sdk/examples/add_openstack_image_provider.rb
M sdk/examples/add_vm.rb
M sdk/examples/add_vm_disk.rb
M sdk/examples/add_vm_nic.rb
M sdk/examples/add_vm_snapshot.rb
M sdk/examples/attach_nfs_data_storage_domain.rb
M sdk/examples/attach_nfs_iso_storage_domain.rb
M sdk/examples/change_vm_cd.rb
M sdk/examples/enable_compression.rb
M sdk/examples/follow_vm_links.rb
M sdk/examples/import_external_vm.rb
M sdk/examples/kerberos_authentication.rb
M sdk/examples/list_vm_disks.rb
M sdk/examples/list_vms.rb
M sdk/examples/page_vms.rb
M sdk/examples/remove_host.rb
M sdk/examples/remove_vm.rb
M sdk/examples/search_vms.rb
M sdk/examples/set_vm_serial_number.rb
M sdk/examples/show_summary.rb
M sdk/examples/start_vm.rb
M sdk/examples/stop_vm.rb
M sdk/examples/update_data_center.rb
M sdk/lib/ovirtsdk4/connection.rb
M sdk/lib/ovirtsdk4/probe.rb
M sdk/lib/ovirtsdk4/reader.rb
M sdk/lib/ovirtsdk4/service.rb
M sdk/lib/ovirtsdk4/type.rb
M sdk/lib/ovirtsdk4/writer.rb
M sdk/ovirt-engine-sdk.gemspec
M sdk/spec/action_reader_spec.rb
M sdk/spec/cluster_reader_spec.rb
M sdk/spec/clusters_service_spec.rb
M sdk/spec/connection_create_spec.rb
M sdk/spec/connection_timeout_spec.rb
M sdk/spec/connection_use_spec.rb
M sdk/spec/data_centers_service_spec.rb
M sdk/spec/enum_spec.rb
M sdk/spec/fault_reader_spec.rb
M sdk/spec/network_reader_spec.rb
M sdk/spec/network_writer_spec.rb
M sdk/spec/openstack_image_provider_writer_spec.rb
M sdk/spec/probe_spec.rb
M sdk/spec/reader_spec.rb
M sdk/spec/service_spec.rb
M sdk/spec/spec_helper.rb
M sdk/spec/storage_domain_service_spec.rb
M sdk/spec/storage_domains_service_spec.rb
M sdk/spec/type_spec.rb
M sdk/spec/vm_reader_spec.rb
M sdk/spec/vm_service_spec.rb
M sdk/spec/vm_spec.rb
M sdk/spec/vm_writer_spec.rb
M sdk/spec/vms_service_spec.rb
M sdk/spec/writer_spec.rb
M sdk/spec/xml_reader_spec.rb
M sdk/spec/xml_writer_spec.rb
74 files changed, 1,521 insertions(+), 1,852 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65708
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7268ae79cc55609b92c7cd17c71cfdcf9be9563
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[master]: Run Rubocop as part of the 'test' task
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Run Rubocop as part of the 'test' task
......................................................................
Run Rubocop as part of the 'test' task
This patch fixes most of the Rubocop complaints, and disables the cops
that can't be easily addressed, so that we can actually run Rubocop on
the source as part of the 'test' task.
Note that the generated code has also been improved to generate less
Rubocop complaints (1.9 hash syntax, no return, etc), but it isn't
actually checked because it takes too long, and some complaints (long
lines, for example) are hard to avoid.
Change-Id: Ia7268ae79cc55609b92c7cd17c71cfdcf9be9563
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/VersionGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java
A sdk/.rubocop.yml
M sdk/Gemfile
M sdk/README.adoc
M sdk/Rakefile
M sdk/examples/add_cluster.rb
M sdk/examples/add_data_center.rb
M sdk/examples/add_group.rb
M sdk/examples/add_host.rb
M sdk/examples/add_independent_vm.rb
M sdk/examples/add_mac_pool.rb
M sdk/examples/add_nfs_data_storage_domain.rb
M sdk/examples/add_nfs_iso_storage_domain.rb
M sdk/examples/add_openstack_image_provider.rb
M sdk/examples/add_vm.rb
M sdk/examples/add_vm_disk.rb
M sdk/examples/add_vm_nic.rb
M sdk/examples/add_vm_snapshot.rb
M sdk/examples/attach_nfs_data_storage_domain.rb
M sdk/examples/attach_nfs_iso_storage_domain.rb
M sdk/examples/change_vm_cd.rb
M sdk/examples/enable_compression.rb
M sdk/examples/follow_vm_links.rb
M sdk/examples/import_external_vm.rb
M sdk/examples/kerberos_authentication.rb
M sdk/examples/list_vm_disks.rb
M sdk/examples/list_vms.rb
M sdk/examples/page_vms.rb
M sdk/examples/remove_host.rb
M sdk/examples/remove_vm.rb
M sdk/examples/search_vms.rb
M sdk/examples/set_vm_serial_number.rb
M sdk/examples/show_summary.rb
M sdk/examples/start_vm.rb
M sdk/examples/stop_vm.rb
M sdk/examples/update_data_center.rb
M sdk/lib/ovirtsdk4/connection.rb
M sdk/lib/ovirtsdk4/probe.rb
M sdk/lib/ovirtsdk4/reader.rb
M sdk/lib/ovirtsdk4/service.rb
M sdk/lib/ovirtsdk4/type.rb
M sdk/lib/ovirtsdk4/writer.rb
M sdk/ovirt-engine-sdk.gemspec
M sdk/spec/action_reader_spec.rb
M sdk/spec/cluster_reader_spec.rb
M sdk/spec/clusters_service_spec.rb
M sdk/spec/connection_create_spec.rb
M sdk/spec/connection_timeout_spec.rb
M sdk/spec/connection_use_spec.rb
M sdk/spec/data_centers_service_spec.rb
M sdk/spec/enum_spec.rb
M sdk/spec/fault_reader_spec.rb
M sdk/spec/network_reader_spec.rb
M sdk/spec/network_writer_spec.rb
M sdk/spec/openstack_image_provider_writer_spec.rb
M sdk/spec/probe_spec.rb
M sdk/spec/reader_spec.rb
M sdk/spec/service_spec.rb
M sdk/spec/spec_helper.rb
M sdk/spec/storage_domain_service_spec.rb
M sdk/spec/storage_domains_service_spec.rb
M sdk/spec/type_spec.rb
M sdk/spec/vm_reader_spec.rb
M sdk/spec/vm_service_spec.rb
M sdk/spec/vm_spec.rb
M sdk/spec/vm_writer_spec.rb
M sdk/spec/vms_service_spec.rb
M sdk/spec/writer_spec.rb
M sdk/spec/xml_reader_spec.rb
M sdk/spec/xml_writer_spec.rb
74 files changed, 1,467 insertions(+), 1,870 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65630
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7268ae79cc55609b92c7cd17c71cfdcf9be9563
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: webadmin, userportal: Fix JqueryUtils.getTextFromHtml
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix JqueryUtils.getTextFromHtml
......................................................................
webadmin,userportal: Fix JqueryUtils.getTextFromHtml
oVirt GWT UI currently uses jQuery version 1.11.3
Quote from jQuery upgrade guide [1]:
"
As of 1.9, a string is only considered to be HTML if it starts
with a less-than ("<") character.
..
If a string is known to be HTML but may start with arbitrary text
that is not an HTML tag, pass it to jQuery.parseHTML() which will
return an array of DOM nodes representing the markup.
"
[1] http://stage.jquery.com/upgrade-guide/1.9/#jquery-htmlstring-versus-jquer...
The problem was that jQuery treated `html` argument as selector
if the string didn't start with `<` character. Because of this,
the string failed to parse as selector, resulting in error like:
Syntax error, unrecognized expression: Dev. Size
This patch fixes the problem.
Change-Id: Ic939c09f3cb2e2a80b6ef2dd15cb759cbc27f946
Bug-Url: https://bugzilla.redhat.com/1386765
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/JqueryUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/65690
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic939c09f3cb2e2a80b6ef2dd15cb759cbc27f946
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: RunVmCommand - init spID in init()
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RunVmCommand - init spID in init()
......................................................................
core: RunVmCommand - init spID in init()
Move the initialization of the storage pool id, which potentially
accesses the database from the constructor to the init() method where it
belongs.
Change-Id: I3e2cdbea79842431ee2d26da6f5a153a625d0960
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65705
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e2cdbea79842431ee2d26da6f5a153a625d0960
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months