Change in ovirt-engine[master]: scheduling: Add missing parameters to Power saving balance p...
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: scheduling: Add missing parameters to Power saving balance policy
......................................................................
scheduling: Add missing parameters to Power saving balance policy
The Enable automatic PM and Hosts in reserve options were not
visible from the webadmin.
Change-Id: Ide045be1b54a6a579abe118440f0dbf1d41ed44d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1384563
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Artyom Lukianov: Looks good to me, but someone else must approve
Yanir Quinn: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/65710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide045be1b54a6a579abe118440f0dbf1d41ed44d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: scheduling: Use Optional.empty() instead of null in schedule...
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: scheduling: Use Optional.empty() instead of null in schedule call
......................................................................
scheduling: Use Optional.empty() instead of null in schedule call
A small cleanup of the scheduling API that should be a bit more
NPE safe and removes some obsolete Guid.Empty checks.
Change-Id: I281345ee566bbc944351fc4a362ed068e4a32cc6
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
3 files changed, 17 insertions(+), 12 deletions(-)
Approvals:
Martin Sivák: Verified
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
Yanir Quinn: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63606
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I281345ee566bbc944351fc4a362ed068e4a32cc6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: restapi, core: add force member to StorageServerConnectionPar...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: restapi,core: add force member to StorageServerConnectionParametersBase
......................................................................
restapi,core: add force member to StorageServerConnectionParametersBase
* Added 'force' member to StorageServerConnectionParametersBase.
* Used in order to enable updating a storage connection regardless
to storage domain's status (i.e. also when the domain is not in
status Maintenance).
Change-Id: I8986e9f62096f3dadf57fca6a01bda622a9557d8
Bug-Url: https://bugzilla.redhat.com/1379771
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/BaseFsStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetUnregisteredBlockStorageDomainsQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageServerConnectionParametersBase.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
14 files changed, 42 insertions(+), 30 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64420
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8986e9f62096f3dadf57fca6a01bda622a9557d8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: engine: Adding bond_active_slave to vds_interface
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: engine: Adding bond_active_slave to vds_interface
......................................................................
engine: Adding bond_active_slave to vds_interface
To prepare exposing the information of the active slave in a "bonded"
interface, a column is added to the table vds_interface in the
database.
Bug-Url: https://bugzilla.redhat.com/1038550
Change-Id: Ib710d7da480629411f81e4328559de30d06c202a
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_01_0360_add_bond_active_slave_to_vds_interface.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Dominik Holler: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib710d7da480629411f81e4328559de30d06c202a
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: remove GetCpuStatisticsByVdsId
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove GetCpuStatisticsByVdsId
......................................................................
core: remove GetCpuStatisticsByVdsId
Remove the unused query GetCpuStatisticsByVdsId.
Change-Id: I7bd92acee4bb77898788e1158e9e1df1a4317e96
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/host/GetCpuStatisticsByVdsIdQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 0 insertions(+), 23 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/65732
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bd92acee4bb77898788e1158e9e1df1a4317e96
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: Inject members for ALB with VdsName
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Inject members for ALB with VdsName
......................................................................
core: Inject members for ALB with VdsName
getVdsName() apparently performs a DAO call even if its vds member is
set.
This patch fixes a gap from patch 2d9dc8 and injects the DAOs to those
AuditLoggableBases too.
Change-Id: I9f4c589307f7dd3907289f82fe62b2b8add59e13
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/65754
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f4c589307f7dd3907289f82fe62b2b8add59e13
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: webadmin, core: random renamed to urandom in VM dialog
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: webadmin, core: random renamed to urandom in VM dialog
......................................................................
webadmin, core: random renamed to urandom in VM dialog
Up to version 4.0 there were two random generator sources:
/dev/random and /dev/hwrng in the engine. Since engine 4.1 /dev/random
is going to be replaced by /dev/urandom. Set of random generators
available for VM depends purely on set of generators currently selected
on Cluster, not on effective VM compatibility level.
This patch
* adds new VmRngDevice.Source#URANDOM enum item.
* introduces conditional labels VM dialogs for urandom/random based on
selected cluster version.
* value of urandom/random radiobutton in VM dialog depends on currently
selected cluster; is 'urandom' for non-cluster entities (Blank
template and instance types).
Change-Id: I6c17dc780310020567e5f8b40938765f4dc9a5a2
Bug-Url: https://bugzilla.redhat.com/1374227
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NonClusterModelBehaviorBase.java
9 files changed, 86 insertions(+), 29 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65442
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c17dc780310020567e5f8b40938765f4dc9a5a2
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-4.0.5]: build: post ovirt-engine-4.0.5.3
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: build: post ovirt-engine-4.0.5.3
......................................................................
build: post ovirt-engine-4.0.5.3
Change-Id: I609adf5687a8aa1aaf66a59722b39f8eb6201226
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M automation/build-artifacts.sh
M backend/manager/dependencies/common/pom.xml
M backend/manager/dependencies/pom.xml
M backend/manager/dependencies/tools/pom.xml
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/auth-plugin/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/enginesso/pom.xml
M backend/manager/modules/extensions-api-root/extensions-api/pom.xml
M backend/manager/modules/extensions-api-root/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/ovirt-findbugs-filters/pom.xml
M build-tools-root/pom.xml
M build/validations/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend-symbols/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M pom.xml
M version.mak
59 files changed, 67 insertions(+), 64 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved; Passed CI tests
Sandro Bonazzola: Verified
--
To view, visit https://gerrit.ovirt.org/65744
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I609adf5687a8aa1aaf66a59722b39f8eb6201226
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-4.0.5]: build: ovirt-engine-4.0.5.3
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: build: ovirt-engine-4.0.5.3
......................................................................
build: ovirt-engine-4.0.5.3
Change-Id: I3ceb36ffb8c7d925e3af236e4b6a3628c01e6fea
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M automation/build-artifacts.sh
M backend/manager/dependencies/common/pom.xml
M backend/manager/dependencies/pom.xml
M backend/manager/dependencies/tools/pom.xml
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/auth-plugin/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/enginesso/pom.xml
M backend/manager/modules/extensions-api-root/extensions-api/pom.xml
M backend/manager/modules/extensions-api-root/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/ovirt-findbugs-filters/pom.xml
M build-tools-root/pom.xml
M build/validations/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend-symbols/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M ovirt-engine.spec.in
M pom.xml
M version.mak
60 files changed, 66 insertions(+), 66 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Sandro Bonazzola: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65743
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ceb36ffb8c7d925e3af236e4b6a3628c01e6fea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: report SwitchType also on bonds
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: report SwitchType also on bonds
......................................................................
core: report SwitchType also on bonds
• all networks get same switch type, so it need not be specified per
HostNetwork. It should be sufficient to have it specified only once in
paramaters class.
• onces that's done, we need not to update CreateOrUpdateBond class
with SwitchType just as HostNetwork used to contain it
(which would be totally incorrect(*)), and use SwitchType from
parameters class.
(*) it's problematic to share TO to pass data between more than 2 app
layers. It can work, until all its data makes sense everywhere, but
here we need only to pass switch type of CreateOrUpdateBond from bll
to vdsm. It's totally meaningless for UI and thus it must not be added
into this class.
Change-Id: Id5a8d2ebc70eb50a73d9c379beb0ea18e5a50ef1
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostSetupNetworksVdsCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java
4 files changed, 35 insertions(+), 27 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/65416
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5a8d2ebc70eb50a73d9c379beb0ea18e5a50ef1
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months