October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: RemoveDiskCommandTest @Rule
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveDiskCommandTest @Rule ...................................................................... core: RemoveDiskCommandTest @Rule Removed redundant @Rule. Change-Id: I4d952ffa00a5ce20c3a72ae6d6bd4f35f23f6371 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommandTest.java 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d952ffa00a5ce20c3a72ae6d6bd4f35f23f6371 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateStorageDomainCommandTest @Spy annotation
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: UpdateStorageDomainCommandTest @Spy annotation ...................................................................... core: UpdateStorageDomainCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: Iddb63237592e75d1121f0345d202c0059ca449ba Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommandTest.java 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddb63237592e75d1121f0345d202c0059ca449ba Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateStorageDomainCommonTest local variable
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: UpdateStorageDomainCommonTest local variable ...................................................................... core: UpdateStorageDomainCommonTest local variable Converted vds to a local variable to make the code cleaner and more concise. Change-Id: I905e65173158c00696ae3bc60769ece74225ee30 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommandTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I905e65173158c00696ae3bc60769ece74225ee30 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest @Spy annotation
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest @Spy annotation ...................................................................... core: RemoveStorageDomainCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: I3786f09687c10539c0b34069bdc0e9f9e4d6131e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/RemoveStorageDomainCommandTest.java 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3786f09687c10539c0b34069bdc0e9f9e4d6131e Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DeactivateStorageDomainCommandTest rules
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: DeactivateStorageDomainCommandTest rules ...................................................................... core: DeactivateStorageDomainCommandTest rules Remove the duplicate MockEJBStrategyRule. Change-Id: Ie4483d99f85999d52d6dafc32742d4e1d23e8245 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4483d99f85999d52d6dafc32742d4e1d23e8245 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DeactivateStorageDomainCommandTest Backend mock
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: DeactivateStorageDomainCommandTest Backend mock ...................................................................... core: DeactivateStorageDomainCommandTest Backend mock Remove the redundant mocking of Backend. Change-Id: Ibdfdee909802e4fa221bb28ff9721a24124aeacf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64744 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdfdee909802e4fa221bb28ff9721a24124aeacf Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DeactivateStorageDomainCommandTest @Spy annotation
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: DeactivateStorageDomainCommandTest @Spy annotation ...................................................................... core: DeactivateStorageDomainCommandTest @Spy annotation Spy the command with the @Spy and @InjectMocks annotations instead of explicitly calling Mockito.spy in order to save some boiler plate injection code. Change-Id: Ie5574a2db4750774788b281be3dbbc051a93e2f7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5574a2db4750774788b281be3dbbc051a93e2f7 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DeactivateStorageDomainCommandTest type inference
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: DeactivateStorageDomainCommandTest type inference ...................................................................... core: DeactivateStorageDomainCommandTest type inference Change-Id: Id7f4224d19e869138a1be7392bfc49fb25912ee2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7f4224d19e869138a1be7392bfc49fb25912ee2 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AttachStorageDomainToPoolCommandTest @Spy annotation
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AttachStorageDomainToPoolCommandTest @Spy annotation ...................................................................... core: AttachStorageDomainToPoolCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: I65270198183905ef60602ec4966650c544be16e8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommandTest.java 1 file changed, 12 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65270198183905ef60602ec4966650c544be16e8 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddExistingFileStorageDomainCommandTest @Spy annotation
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AddExistingFileStorageDomainCommandTest @Spy annotation ...................................................................... core: AddExistingFileStorageDomainCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: I7188ab64f35dbfc84e355e59460b52bb5b35234e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommandTest.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7188ab64f35dbfc84e355e59460b52bb5b35234e Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0