Change in ovirt-engine[master]: webadmin: Cluster random checkbox removed
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: webadmin: Cluster random checkbox removed
......................................................................
webadmin: Cluster random checkbox removed
'/dev/random' checkbox in Cluster dialog was removed since random rng
source will be automatically required. This patch is intended for 4.1
but the checkbox was removed from all cluster versions. It shouldn't
affect existing hosts since all of them are expected to already support
/dev/random.
Change-Id: I6fe829f871d44143e78c8bf847adb643fc5c25ff
Bug-Url: https://bugzilla.redhat.com/1337101
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
8 files changed, 5 insertions(+), 38 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65142
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fe829f871d44143e78c8bf847adb643fc5c25ff
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Fix move and copy disk commands
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix move and copy disk commands
......................................................................
core: Fix move and copy disk commands
Change I4bddbcc changed the initialization of the storage pool in
BaseImagesCommand and in case the storage pool from the parameters is not
null it will be taken from the parameters, however this change ignored
the case in which the storage pool from the parameters is an empty and it
that case skipping the part of getting the storage pool id from the image
fetched from the DB, this patch adds the check for the empty guid.
Since the original patch also changed the static mocking of the commands
to do nothing when invoking initContainerDetails(params) due to the fact
it issues a DAO call from the ctor the tests are breaking since the DAO
mocks are not populated upon the ctor call to initContainerDetails was
moved to the init() method of the command where it belonged to in the first
place as issuing DAO calls from the ctor is a bad practice.
Bug-Url: https://bugzilla.redhat.com/1385533
Change-Id: Ibe620a55fbfd509689a081e5c658a9e25819dd26
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65610
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe620a55fbfd509689a081e5c658a9e25819dd26
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-java[sdk_4.0]: Convert 'all_content' parameter to 'All-Content' header
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Convert 'all_content' parameter to 'All-Content' header
......................................................................
Convert 'all_content' parameter to 'All-Content' header
Older versions of the engine (before 4.1) only accepted the
'all_content' parameter as an HTTP header. To better support those
versions of the engine this patch changes the SDK so that when the
'all_content' parameter is specified its value is copied to the
'All-Content' request header. So a request like this:
GET /ovirt-engine/api/vms/123?all_content=true
Will be translated into this:
GET /ovirt-engine/api/vms/123?all_content=true
All-Content: true
Change-Id: I2b7be557957456cc834e2f22468bb8e8485e54f7
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java
M sdk/src/test/java/org/ovirt/engine/sdk4/ServerTest.java
M sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java
3 files changed, 37 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b7be557957456cc834e2f22468bb8e8485e54f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-java[sdk_4.0]: Update to model 4.0.37 and metamodel 1.0.21
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to model 4.0.37 and metamodel 1.0.21
......................................................................
Update to model 4.0.37 and metamodel 1.0.21
The more relevant changes in the new version of the model are the
following:
* Add missing `template` and `storage_domain` parameters to the
operation that imports an image.
* Add the `next_run` parameter to the operation that updates a virtual
machine.
* Add the `all_content` parameters to the operations that list and
retrieve virtual machines.
Change-Id: I9735f47b7cb79612d8065d6f0d7b5de9877e0442
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65602
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9735f47b7cb79612d8065d6f0d7b5de9877e0442
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-java[master]: Convert 'all_content' parameter to 'All-Content' header
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Convert 'all_content' parameter to 'All-Content' header
......................................................................
Convert 'all_content' parameter to 'All-Content' header
Older versions of the engine (before 4.1) only accepted the
'all_content' parameter as an HTTP header. To better support those
versions of the engine this patch changes the SDK so that when the
'all_content' parameter is specified its value is copied to the
'All-Content' request header. So a request like this:
GET /ovirt-engine/api/vms/123?all_content=true
Will be translated into this:
GET /ovirt-engine/api/vms/123?all_content=true
All-Content: true
Change-Id: I2b7be557957456cc834e2f22468bb8e8485e54f7
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java
M sdk/src/test/java/org/ovirt/engine/sdk4/ServerTest.java
M sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java
3 files changed, 36 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65597
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b7be557957456cc834e2f22468bb8e8485e54f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-java[master]: Update to model 4.1.15 and metamodel 1.1.7
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to model 4.1.15 and metamodel 1.1.7
......................................................................
Update to model 4.1.15 and metamodel 1.1.7
The more relevant changes in the new version of the model are the
following:
* Add missing `template` and `storage_domain` parameters to the
operation that imports an image.
* Add the `next_run` parameter to the operation that updates a virtual
machine.
* Add the `all_content` parameters to the operations that list and
retrieve virtual machines.
Change-Id: I9735f47b7cb79612d8065d6f0d7b5de9877e0442
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65600
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9735f47b7cb79612d8065d6f0d7b5de9877e0442
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[master]: Update to model 4.1.15 and metamodel 1.1.7
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to model 4.1.15 and metamodel 1.1.7
......................................................................
Update to model 4.1.15 and metamodel 1.1.7
The more relevant changes in the new version of the model are the
following:
* Add missing `template` and `storage_domain` parameters to the
operation that imports an image.
* Add the `next_run` parameter to the operation that updates a virtual
machine.
* Add the `all_content` parameters to the operations that list and
retrieve virtual machines.
Change-Id: Ib8628580b0e6cadf8efff315b72e319bdb3cb9c2
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8628580b0e6cadf8efff315b72e319bdb3cb9c2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update to model 4.0.37 and metamodel 1.0.21
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Update to model 4.0.37 and metamodel 1.0.21
......................................................................
restapi: Update to model 4.0.37 and metamodel 1.0.21
The more relevant changes in the new version of the model are the
following:
* Add missing `template` and `storage_domain` parameters to the
operation that imports an image.
* Add the `next_run` parameter to the operation that updates a virtual
machine.
* Add the `all_content` parameters to the operations that list and
retrieve virtual machines.
Change-Id: Icc5f45c72d091057008589418dcfe759bf09375f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc5f45c72d091057008589418dcfe759bf09375f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[master]: core, webadmin: RNG validator message more explanatory
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: core, webadmin: RNG validator message more explanatory
......................................................................
core, webadmin: RNG validator message more explanatory
Error message changed to match its actual usage.
Change-Id: I14fea653496ea4ae3fbbe472bbea8087a3aaed5b
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VirtIoRngValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
Marek Libra: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14fea653496ea4ae3fbbe472bbea8087a3aaed5b
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix NPE on new instance image creation
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix NPE on new instance image creation
......................................................................
webadmin: Fix NPE on new instance image creation
Change-Id: I40ceec10d297f44071f919b4e2dfd05728d64943
Bug-Url: https://bugzilla.redhat.com/1382357
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Alexander Wels: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65464
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40ceec10d297f44071f919b4e2dfd05728d64943
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months