Change in ovirt-engine[master]: core: BaseImagesCommand init SP id
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: BaseImagesCommand init SP id
......................................................................
core: BaseImagesCommand init SP id
As all of the image commands happen in the scope of a single storage
pool, it makes sense to allow setting its ID directly on the parameter
object instead of querying it from the passed disk object.
Besides a slight performance improvement, this change also allows
cleaning up some testing flows by allowing us to forgo some stubbing of
these commands.
Change-Id: I4bddbcc64fcaecff1aaf172575a53d430b6caf5f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommandTest.java
3 files changed, 5 insertions(+), 17 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64689
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bddbcc64fcaecff1aaf172575a53d430b6caf5f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: RemoveDiskSnapshotsCommandTest stubbing
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RemoveDiskSnapshotsCommandTest stubbing
......................................................................
core: RemoveDiskSnapshotsCommandTest stubbing
Remove stubbing from the test. This stubbing is no longer needed since
the dao calls were moved from the constructor to the init() which is
called in the postConstruct phase.
Change-Id: Id8d2285f4dd05ef63eee53908c1ae7ec9dd46b47
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandTest.java
1 file changed, 1 insertion(+), 19 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64692
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8d2285f4dd05ef63eee53908c1ae7ec9dd46b47
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: StorageHandlingCommandBase#init
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageHandlingCommandBase#init
......................................................................
core: StorageHandlingCommandBase#init
Remove the init(parameters) call from the constructor and use the
standard init() instead. This method is already called by the command's
postConstruct phase, so on the one hand it's part of the framework, and
on the other it's a safe place to use dao calls.
Change-Id: I9c4f9a8243ea7c5a4053602f69a9fcdf9e4da523
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ScanStorageForUnregisteredDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ActivateStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommonTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/RemoveStorageDomainCommandTest.java
12 files changed, 19 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64690
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c4f9a8243ea7c5a4053602f69a9fcdf9e4da523
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: ImportVmCommandStub ImportValidator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVmCommandStub ImportValidator
......................................................................
core: ImportVmCommandStub ImportValidator
The validator can easily be spied onto the command, so there's no
reason to reimplement the same logic explicitly by saving it and then
checking if it was saved.
Change-Id: I722c75bf29c4b1c7bb7434083dd50c2fdadb7276
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java
1 file changed, 2 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64675
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I722c75bf29c4b1c7bb7434083dd50c2fdadb7276
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: UpdateStorageServerConnectionCommandTest#createDomain
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: UpdateStorageServerConnectionCommandTest#createDomain
......................................................................
core: UpdateStorageServerConnectionCommandTest#createDomain
Removed unused StorageDomainDynamic argument.
Change-Id: I422db7ac351c0d68c9c8309163220123d50b0c54
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64708
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I422db7ac351c0d68c9c8309163220123d50b0c54
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: UpdateStorageServerConnectionCommandTest rules
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: UpdateStorageServerConnectionCommandTest rules
......................................................................
core: UpdateStorageServerConnectionCommandTest rules
Remove unneeded EJBStrategyRule.
Change-Id: Ib702fcce2e9366bab399bf1353467617a5f5c531
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib702fcce2e9366bab399bf1353467617a5f5c531
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: ImportVMFromConfigurationCommandTest command initializ...
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVMFromConfigurationCommandTest command initialization
......................................................................
core: ImportVMFromConfigurationCommandTest command initialization
Moved the initialization of the tested command to the @Before method
in preparation of moving it to be initialized by a @Spy annotation.
Note that the SimpleDependencyInjector is used to initialize the
command's data members so it must be mocked before the command instance
is created. Hence, this patch moves its handling to a @BeforeClass
method in order to be on the safe side.
Change-Id: I2cc73afe0167d1618e5ff76fae1db2d3a3c563b7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVMFromConfigurationCommandTest.java
1 file changed, 21 insertions(+), 26 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64669
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cc73afe0167d1618e5ff76fae1db2d3a3c563b7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: AddStorageServerConnectionCommandTest unused mocking
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: AddStorageServerConnectionCommandTest unused mocking
......................................................................
core: AddStorageServerConnectionCommandTest unused mocking
Removed mocking of unused dependencies.
Change-Id: I6f163b34f6fac9889bd98ef0b1aa17fda15dd3b7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AddStorageServerConnectionCommandTest.java
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64706
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f163b34f6fac9889bd98ef0b1aa17fda15dd3b7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: RemoveSnapshotCommandTest @Spy annotation
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RemoveSnapshotCommandTest @Spy annotation
......................................................................
core: RemoveSnapshotCommandTest @Spy annotation
Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy. This change has two advantages - first, it's a tad more
elegant, as it saves the duplicate Mockito.spy calls. Second, and more
importantly, it sets the ground for using injected mocks in these tests
in the future.
Change-Id: Ic9f18e6a3b0836045724ad728263141197345ca1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandTest.java
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64705
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9f18e6a3b0836045724ad728263141197345ca1
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: RemoveSnapshotCommandTest local vars
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RemoveSnapshotCommandTest local vars
......................................................................
core: RemoveSnapshotCommandTest local vars
Convert an unneeded data member to a local variable to make the code
more concise.
Change-Id: I84cf013f3e728a7c16796c8e23fa41afff17658a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandTest.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84cf013f3e728a7c16796c8e23fa41afff17658a
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months