October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[cli_3.6]: cli: Release 3.6.9.2
by juan.hernandez＠redhat.com 13 Oct '16

13 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Release 3.6.9.2 ...................................................................... cli: Release 3.6.9.2 Change-Id: I3e86a5f75ab0364fb711cfa3c84aeb3bfa38f3d6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e86a5f75ab0364fb711cfa3c84aeb3bfa38f3d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[refs/meta/config]: Update permissions to be inherited from All-Projects
by sbendavi＠redhat.com 13 Oct '16

13 Oct '16

Shlomo Ben David has submitted this change and it was merged. Change subject: Update permissions to be inherited from All-Projects ...................................................................... Update permissions to be inherited from All-Projects Change-Id: Ib1e68d5f817bc2407619fcdd1766fa8043a903ad --- M groups M project.config 2 files changed, 1 insertion(+), 13 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1e68d5f817bc2407619fcdd1766fa8043a903ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: refs/meta/config Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Base should be None when there is no base
by juan.hernandez＠redhat.com 13 Oct '16

13 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Base should be None when there is no base ...................................................................... cli: Base should be None when there is no base Currently when a base object can't be found the 'resolve_base' method returns the starting point for the search, the 'connection' object. This is wrong, it should return 'None', as that is what callers expect. This patch fixes that issue. Change-Id: I971624874935ef7342cd7fb193783893fc7cdc84 Bug-Url: https://bugzilla.redhat.com/1383735 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 42080df2d9405e3f9577106b588c8a93b2220008) --- M src/ovirtcli/command/command.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I971624874935ef7342cd7fb193783893fc7cdc84 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[master]: cli: Base should be None when there is no base
by juan.hernandez＠redhat.com 13 Oct '16

13 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Base should be None when there is no base ...................................................................... cli: Base should be None when there is no base Currently when a base object can't be found the 'resolve_base' method returns the starting point for the search, the 'connection' object. This is wrong, it should return 'None', as that is what callers expect. This patch fixes that issue. Change-Id: I971624874935ef7342cd7fb193783893fc7cdc84 Bug-Url: https://bugzilla.redhat.com/1383735 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I971624874935ef7342cd7fb193783893fc7cdc84 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: setup: plugins: add constant duplication check
by sbonazzo＠redhat.com 13 Oct '16

13 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: plugins: add constant duplication check ...................................................................... setup: plugins: add constant duplication check Check for constants duplication in all constants.py files Change-Id: I5c7a1d419b658bb712e135b3e5c5a94341b8ac51 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1263785 --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/base/core/duplicated_constants_check.py 3 files changed, 125 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c7a1d419b658bb712e135b3e5c5a94341b8ac51 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix get_bug_url function in check_product hook
by sbendavi＠redhat.com 13 Oct '16

13 Oct '16

Shlomo Ben David has submitted this change and it was merged. Change subject: Fix get_bug_url function in check_product hook ...................................................................... Fix get_bug_url function in check_product hook - Add hard coded bz_server for the new regex search in get_bug_url function - Replace old links with new ones Change-Id: Ia8878f3f45763bb7a6f17f2372099cfe61975a0c Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/check_product A hooks/custom_hooks/patchset-created.bz.2.correct_product R hooks/custom_hooks/patchset-created.bz.2.correct_product-not-used R hooks/custom_hooks/patchset-created.bz.2.correct_product.py 4 files changed, 7 insertions(+), 3 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8878f3f45763bb7a6f17f2372099cfe61975a0c Gerrit-PatchSet: 2 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add 'diskattachments' link to storage domain VM
by tnisan＠redhat.com 13 Oct '16

13 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add 'diskattachments' link to storage domain VM ...................................................................... restapi: Add 'diskattachments' link to storage domain VM Starting with version 4.1 of the engine the links to sub-collections are inferred from the model, and automatically added. But in the 4.0 branch they still need to be added manually. The 'diskattachments' link for virtual machines that can be imported from a storage domain was missing, this patch adds it. Change-Id: I1239e4f5a8e73cd1ec213f47b1e899fe692bd21f Bug-Url: https://bugzilla.redhat.com/1383264 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1239e4f5a8e73cd1ec213f47b1e899fe692bd21f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: delegating validation, which will fail only if all...
by tjelinek＠redhat.com 13 Oct '16

13 Oct '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: delegating validation, which will fail only if all given …Validation fails. ...................................................................... webadmin: delegating validation, which will fail only if all given …Validation fails. If no …Validation was given or some succeed, AlternativeValidation will succeed. Change-Id: Ia3ee4db89a6bee2c61e87c23e1e991477bd3af67 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/AlternativeValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/RegexValidation.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/AlternativeValidationTest.java 3 files changed, 95 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3ee4db89a6bee2c61e87c23e1e991477bd3af67 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: removed pointless template method, broken overgrow...
by tjelinek＠redhat.com 13 Oct '16

13 Oct '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: removed pointless template method, broken overgrown method ...................................................................... webadmin: removed pointless template method, broken overgrown method • removed template method: protected abstract String composeMessage(); which can be easily replaced with constructor parameter, relieving from having to do subclasses only to change produced message • fixed all locations creating unnecessary subclases, using simplest code possible (ie. lost of duplicates were removed in process as well). • method BaseI18NValidation.allUtfLetters was overgrown. Despite of it's rather small body - composing two string literals - it's still too much, since subclasses requires method, which returns only latter literal. This was solved inadequately, by overriding method producing first literal, instead of simply having method to produce latter string literal. This was fixed, so now we do not need to override method asciiLetters to produce "", to get String B (utf letters minus ascii letters). Change-Id: I2dd36bc5111473ce66e289aabdfa4394506032b0 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/AsciiNameValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/AsciiOrNoneValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/BaseI18NValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/BrickMountPointValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/HostAddressValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/HostWithProtocolAndPortAddressValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/I18NExtraNameOrNoneValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/I18NNameValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LinuxMountPointValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LocalfsLinuxMountPointValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NameAndOptionalDomainValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NonUtfValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/PoolNameValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/SpecialAsciiI18NOrNoneValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UriHostAddressValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/VmInitNetworkNameValidation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/HostAddressValidationTest.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/HostWithProtocolAndPortAddressValidationTest.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/PoolNameValidationTest.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/UriHostAddressValidationTest.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidationTest.java 22 files changed, 134 insertions(+), 183 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dd36bc5111473ce66e289aabdfa4394506032b0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.5]: engine: Add extra debug information in AsyncTaskManager
by piotr.kliczewski＠gmail.com 13 Oct '16

13 Oct '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Add extra debug information in AsyncTaskManager ...................................................................... engine: Add extra debug information in AsyncTaskManager Add extra debug information in AsyncTaskManager that logs polling and updating task statuses. Change-Id: Id3a84f280c24e8bd47096a0a7929223a4033d2ff Bug-Url: https://bugzilla.redhat.com/1374171 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java 2 files changed, 31 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3a84f280c24e8bd47096a0a7929223a4033d2ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0