Change in ovirt-dwh[refs/meta/config]: Update permissions to be inherited from All-Projects
by sbendavi@redhat.com
Shlomo Ben David has submitted this change and it was merged.
Change subject: Update permissions to be inherited from All-Projects
......................................................................
Update permissions to be inherited from All-Projects
Change-Id: I416b2b7c7c20993aa643845a3b377016ccd29fbc
---
M groups
M project.config
2 files changed, 1 insertion(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shlomo Ben David: Verified; Looks good to me, approved; Passed CI tests
Gil Shinar: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/65320
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I416b2b7c7c20993aa643845a3b377016ccd29fbc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in gerrit-admin[master]: Recreate check_target_milestone hook
by sbendavi@redhat.com
Shlomo Ben David has submitted this change and it was merged.
Change subject: Recreate check_target_milestone hook
......................................................................
Recreate check_target_milestone hook
- The new hook is replacing the old
patchset-created.bz.3.correct_target_milestone hook and it based
on the bz.py module.
- It checks only u/s bugs (oVirt classification)
- It checks that the current patch branch major version is the same
as the bug target milestone major version.
Example 1:
tm: '---'
branch_maj_version: any
result: WARN
Example 2:
tm_maj_version: 3.6
branch_maj_version: 3.6
result: OK
Example 3:
tm_maj_version: 3.6
branch_maj_version: 4.0
result: checks for clone flags
Example 4:
tm_maj_version: 4.0
branch_maj_version: 3.6
result: WARN
- All the previous links are pointing to the new hook.
Change-Id: Iefe1ab1fe6c34e6754ed498cfc440691cce88e6e
Fixes: OVIRT-588
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
A hooks/custom_hooks/check_target_milestone
A hooks/custom_hooks/patchset-created.bz.3.correct_target_milestone
R hooks/custom_hooks/patchset-created.bz.3.correct_target_milestone-not-used
D hooks/custom_hooks/patchset-created.bz.3.correct_target_milestone.sh
4 files changed, 422 insertions(+), 1 deletion(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved
Gil Shinar: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64538
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefe1ab1fe6c34e6754ed498cfc440691cce88e6e
Gerrit-PatchSet: 4
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in gerrit-admin[master]: Recreate check_bug_url hook
by sbendavi@redhat.com
Shlomo Ben David has submitted this change and it was merged.
Change subject: Recreate check_bug_url hook
......................................................................
Recreate check_bug_url hook
- The new hook is replacing the old
patchset-created.bz.0.has_bug_url hook and it based on the bz.py module.
- It checks that the bug url exist
- It checks only u/s bug urls (oVirt classification)
- It checks that the bug url is match bugzilla server (bugzilla.redhat.com)
- It checks that the bug id is correct and available
Example 1:
classification: oVirt
bug url: https://other-bugzilla.redhat.com/1234567
result: WARN, wrong/misspelled bug url
Example 2:
classification: other
bug url: https://bugzilla.redhat.com/1234567
result: IGNORE, not relevant for 'other' classification
Example 3:
classification: oVirt
bug url: https://bugzilla.redhat.com/1234567890
result: WARN, unavailable bug id
- All the previous links are pointing to the new hook.
Change-Id: I200131dce12e986fd56cd4faaea5bd6cecb1cb11
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
A hooks/custom_hooks/check_bug_url
A hooks/custom_hooks/patchset-created.bz.0.has_bug_url
R hooks/custom_hooks/patchset-created.bz.0.has_bug_url-not-used
D hooks/custom_hooks/patchset-created.bz.0.has_bug_url.sh
4 files changed, 349 insertions(+), 1 deletion(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved
Gil Shinar: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I200131dce12e986fd56cd4faaea5bd6cecb1cb11
Gerrit-PatchSet: 6
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in gerrit-admin[master]: Recreate update_tracker hook
by sbendavi@redhat.com
Shlomo Ben David has submitted this change and it was merged.
Change subject: Recreate update_tracker hook
......................................................................
Recreate update_tracker hook
The new hook is replacing the old update_tracker hook.
- It updates only u/s bugs (oVirt classification)
- It updates the following info in the bugzilla external tracker section:
Tracker ==> tracker_id (81 --> oVirt gerrit)
ID ==> change id
Priority ==> patch branch
Status ==> NEW --> POST, MERGED --> MERGED
Summary ==> commit subject
Fixes: OVIRT-623
Change-Id: I1dd56360e80417486f75214da24986f7df9c0653
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/custom_hooks/update_tracker
A hooks/custom_hooks/update_tracker-not-used
2 files changed, 409 insertions(+), 57 deletions(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved
Gil Shinar: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65184
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dd56360e80417486f75214da24986f7df9c0653
Gerrit-PatchSet: 4
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in gerrit-admin[master]: Fix regex search for bug urls
by sbendavi@redhat.com
Shlomo Ben David has submitted this change and it was merged.
Change subject: Fix regex search for bug urls
......................................................................
Fix regex search for bug urls
Fixing regex search for bug urls in get_bug_urls function
by adding hard coded bz_server parameter
(default value: https://bugzilla.redhat.com)
Fixes: OVIRT-765
Change-Id: I10c9f029556f141f51cce64f9de4861a39ff03ce
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/lib/bz.py
1 file changed, 5 insertions(+), 10 deletions(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved
Gil Shinar: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65318
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10c9f029556f141f51cce64f9de4861a39ff03ce
Gerrit-PatchSet: 2
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: packaging: setup: fix constants deduplication for dev-env
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fix constants deduplication for dev-env
......................................................................
packaging: setup: fix constants deduplication for dev-env
Patch https://gerrit.ovirt.org/#/c/65129 removed constant
duplication but it broke the dev-env since DWH detup code
is generally not installed on dev-env.
Reintroducing the bare minimum constant duplication till
we found a valid alternative.
Change-Id: Ia5914da794bb36bec00ff78dba5be7d63de3f6bd
Bug-Url: https://bugzilla.redhat.com/1263785
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A packaging/setup/ovirt_engine_setup/engine_common/dwh_shared_constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/dwh_database.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py
3 files changed, 176 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65409
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5914da794bb36bec00ff78dba5be7d63de3f6bd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: aaa: Assign unique id to each logged in user
by mperina@redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: Assign unique id to each logged in user
......................................................................
aaa: Assign unique id to each logged in user
On user login if the user is not found in
the database a default user id was assigned
to the all users (all zeros). Now when two
users logged in to the system they got the
union of permissions for each user.
This can be resolved by assigning a unique id
to each logged in user if the user is not
found in the database
Change-Id: Ie79a1d0b9b5da4fa338e166510b678212e8e137f
Bug-Url: https://bugzilla.redhat.com/1380780
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/65405
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie79a1d0b9b5da4fa338e166510b678212e8e137f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: do not reconnect to policy reset
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: do not reconnect to policy reset
......................................................................
do not reconnect to policy reset
We do not want to reconnect when policy is reset during setupNetworks.
Change-Id: I932bc95723660874b29c96181bcbbe469f6b0cab
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M ovirt-engine.spec.in
M pom.xml
3 files changed, 2 insertions(+), 37 deletions(-)
Approvals:
Piotr Kliczewski: Verified; Passed CI tests
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65063
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I932bc95723660874b29c96181bcbbe469f6b0cab
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-live[ovirt-live-4.0]: oVirt Live 4.0.5 RC2
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: oVirt Live 4.0.5 RC2
......................................................................
oVirt Live 4.0.5 RC2
Change-Id: I613cb8d1c348da51d057000f91d9610ae8111e45
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I613cb8d1c348da51d057000f91d9610ae8111e45
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: cleanup_slave: Drop all leftover libvirt domains
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: cleanup_slave: Drop all leftover libvirt domains
......................................................................
cleanup_slave: Drop all leftover libvirt domains
Bug-Url: https://ovirt-jira.atlassian.net/browse/OVIRT-707
Change-Id: Ief88c2850759124c1e989dc46d38d22a48687c38
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M jobs/confs/shell-scripts/cleanup_slave.sh
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64511
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief88c2850759124c1e989dc46d38d22a48687c38
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months