Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix Number format exception
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Fix Number format exception
......................................................................
webadmin: Fix Number format exception
- In certain circumstances it is possible to get port=<not a number>
into the options field of the fencing agent.
- Added validation that port must be a number in options before
allowing the user to save the fence agent.
Change-Id: Icec06cea173b582e654eeb023e78eb5353970df0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1375646
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/KeyValuePairValidation.java
2 files changed, 33 insertions(+), 18 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65330
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icec06cea173b582e654eeb023e78eb5353970df0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0.5]: webadmin: Automatic openstack host deploy warning
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Automatic openstack host deploy warning
......................................................................
webadmin: Automatic openstack host deploy warning
Choosing to deploy Neutron provider on host should warn user, this is may not work and it is recommended to manually deploy the OVS agent on the host.
Change-Id: I414100a6902a1374c9cc5a74c2c9487bee67aba9
Bug-Url: https://bugzilla.redhat.com/1377783
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/HostNetworkProviderWidget.ui.xml
3 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Marcin Mirecki: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65360
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I414100a6902a1374c9cc5a74c2c9487bee67aba9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Automatic openstack host deploy warning
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Automatic openstack host deploy warning
......................................................................
webadmin: Automatic openstack host deploy warning
Choosing to deploy Neutron provider on host should warn user, this is may not work and it is recommended to manually deploy the OVS agent on the host.
Change-Id: I414100a6902a1374c9cc5a74c2c9487bee67aba9
Bug-Url: https://bugzilla.redhat.com/1377783
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/HostNetworkProviderWidget.ui.xml
3 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Marcin Mirecki: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65359
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I414100a6902a1374c9cc5a74c2c9487bee67aba9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0.5]: restapi: Move Quota from Vm to VmBase
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: restapi: Move Quota from Vm to VmBase
......................................................................
restapi: Move Quota from Vm to VmBase
Moving Quota from Vm to VmBase in the REST API model
adds quota parameter to the Template in the API.
Change-Id: I82a207be205e0e4f6c5740b7c9eaa54caafbc838
Bug-Url: https://bugzilla.redhat.com/1379802
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
(cherry picked from commit e80a746a743c64970df9fa078002621777f9019e)
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
2 files changed, 12 insertions(+), 9 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/65351
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82a207be205e0e4f6c5740b7c9eaa54caafbc838
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0]: aaa: desktopLogin sends empty password, impacts desktop SSO ...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: desktopLogin sends empty password, impacts desktop SSO feature
......................................................................
aaa: desktopLogin sends empty password, impacts desktop SSO feature
The session password is not saved
on engine and is only saved on SSO
end. Engine should make a call to
retrieve the encryped password from
SSO and use its private key to decrypt
the password.
Change-Id: If3048210dcc71a6eb4a732b347e57398213b9f72
Bug-Url: https://bugzilla.redhat.com/1381606
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
(cherry picked from commit 39b2133fbf683840af70028725774dbf2caf6d94)
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/IsPasswordDelegationPossibleQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
4 files changed, 58 insertions(+), 36 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3048210dcc71a6eb4a732b347e57398213b9f72
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[master]: Accept 200 code for 'Add' methods
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Accept 200 code for 'Add' methods
......................................................................
Accept 200 code for 'Add' methods
Currently the SDK doesn't accept the HTTP 200 code as a valid result of
'Add' methods, but some methods in the server return this code, for
example the method that adds a cluster quota limit. This patch changes
the SDK so that accepts it.
Change-Id: I88cb176b0ec53c77aac3edb11cecd24b2b93f9e8
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M sdk/spec/vms_service_spec.rb
2 files changed, 31 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65341
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88cb176b0ec53c77aac3edb11cecd24b2b93f9e8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Move Quota from Vm to VmBase
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: restapi: Move Quota from Vm to VmBase
......................................................................
restapi: Move Quota from Vm to VmBase
Moving Quota from Vm to VmBase in the REST API model
adds quota parameter to the Template in the API.
Change-Id: I82a207be205e0e4f6c5740b7c9eaa54caafbc838
Bug-Url: https://bugzilla.redhat.com/1379802
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
2 files changed, 12 insertions(+), 9 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/65168
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82a207be205e0e4f6c5740b7c9eaa54caafbc838
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: webadmin: Automatic openstack host deploy warning
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Automatic openstack host deploy warning
......................................................................
webadmin: Automatic openstack host deploy warning
Choosing to deploy Neutron provider on host should warn user, this is may not work and it is recommended to manually deploy the OVS agent on the host.
Change-Id: I414100a6902a1374c9cc5a74c2c9487bee67aba9
Bug-Url: https://bugzilla.redhat.com/1377783
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/HostNetworkProviderWidget.ui.xml
3 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Jakub Niedermertl: Looks good to me, but someone else must approve
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65315
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I414100a6902a1374c9cc5a74c2c9487bee67aba9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-java[sdk_4.0]: Accept 202 code for 'Add' methods
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Accept 202 code for 'Add' methods
......................................................................
Accept 202 code for 'Add' methods
Currently the SDK doesn't accept the HTTP 202 code as a valid result of
'Add' methods, it is valid return code, so SDK needs to accept it.
Change-Id: I8b9054848f47e29fe71d645025f047d13de93c39
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java
A sdk/src/test/java/org/ovirt/engine/sdk4/ResponseCodeTest.java
2 files changed, 72 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b9054848f47e29fe71d645025f047d13de93c39
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-java[master]: Accept 202 code for 'Add' methods
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Accept 202 code for 'Add' methods
......................................................................
Accept 202 code for 'Add' methods
Currently the SDK doesn't accept the HTTP 202 code as a valid result of
'Add' methods, it is valid return code, so SDK needs to accept it.
Change-Id: I8b9054848f47e29fe71d645025f047d13de93c39
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java
A sdk/src/test/java/org/ovirt/engine/sdk4/ResponseCodeTest.java
M sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java
3 files changed, 72 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65345
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b9054848f47e29fe71d645025f047d13de93c39
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months