Change in ovirt-engine[ovirt-engine-4.0]: jsonrpc: version bump
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: jsonrpc: version bump
......................................................................
jsonrpc: version bump
ovirt-engine-4.0 only
Change-Id: I2460b42318500472a325801c68532bba04977f6f
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1362193
Bug-Url: https://bugzilla.redhat.com/1383831
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65391
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2460b42318500472a325801c68532bba04977f6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
7 years, 7 months
Change in ovirt-engine[master]: core: AddClusterCommandTest @Spy
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: AddClusterCommandTest @Spy
......................................................................
core: AddClusterCommandTest @Spy
Use the @Spy annotation to spy the command being tested in
order to allow injecting mocks.
This patch includes:
- Changing the command being tested to be initialized and
annotated with @Spy and @InjectMocks.
- Now that the command has an @InjectMock annotation on it, the
InjectorRule could be removed.
- Manual spying is replaced with just returning the injected mocks
where possible.
Change-Id: I37d2f60838e47534b2abda9b459583a782729ab7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddClusterCommandTest.java
1 file changed, 19 insertions(+), 39 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64624
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37d2f60838e47534b2abda9b459583a782729ab7
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: UpdateClusterCommandTest @Spy
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: UpdateClusterCommandTest @Spy
......................................................................
core: UpdateClusterCommandTest @Spy
Use the @Spy annotation to spy the command being tested in
order to allow injecting mocks in subsequent patches.
This patch includes:
- Changing the command being tested to be initialized once and
annotated with @Spy and @InjectMocks.
- Thus, there is only only command object per test, so all the
methods receiving commands as parameters were redone to use the
member.
- Now that the command has an @InjectMock annotation on it, the
InjectorRule could be removed.
- Explicit doReturn(someDependency).when(cmd).getSomeDependency()
statements were removed for dependencies that are already injected.
- Setters were added to some parameter classes to allow changing its
properties after the command has been created.
Change-Id: I3a33bd8106306c9bcc80d7c83e1e19a1c4cd0495
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ClusterOperationParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ManagementNetworkOnClusterOperationParameters.java
3 files changed, 17 insertions(+), 13 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64623
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a33bd8106306c9bcc80d7c83e1e19a1c4cd0495
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-hosted-engine-ha[master]: jsonrpc: removing vdsClient
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: jsonrpc: removing vdsClient
......................................................................
jsonrpc: removing vdsClient
Removing the usage of vdsClient and moving every call to jsonrpc.
In this patch every vdsClient command is replaced opening a
vdscli connection, sending the command and letting the
connection close itself when not needed.
Another patch will address the use of a persistent connection for
performance issues.
Change-Id: Ic01450d7a5c421235b5b9d0bde79b869a6861c64
Bug-Url: https://bugzilla.redhat.com/1101554
Depends-On: https://gerrit.ovirt.org/#/c/64324
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/agent/states.py
M ovirt_hosted_engine_ha/broker/submonitors/cpu_load_no_engine.py
M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py
M ovirt_hosted_engine_ha/broker/submonitors/mem_free.py
M ovirt_hosted_engine_ha/broker/submonitors/mem_load.py
M ovirt_hosted_engine_ha/broker/submonitors/mgmt_bridge.py
M ovirt_hosted_engine_ha/lib/Makefile.am
M ovirt_hosted_engine_ha/lib/util.py
D ovirt_hosted_engine_ha/lib/vds_client.py
10 files changed, 191 insertions(+), 269 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62729
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic01450d7a5c421235b5b9d0bde79b869a6861c64
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0.5]: core: autoconverge and compression taken from legacy policy
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: autoconverge and compression taken from legacy policy
......................................................................
core: autoconverge and compression taken from legacy policy
When the "legacy" policy is used, the configuration from cluster/vm was
supposed to be taken.
Change-Id: Ia78428fbfd5f2e6e812caf19eaaf2c8fca0dc46e
Bug-Url: https://bugzilla.redhat.com/1383738
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia78428fbfd5f2e6e812caf19eaaf2c8fca0dc46e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0]: core: autoconverge and compression taken from legacy policy
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: autoconverge and compression taken from legacy policy
......................................................................
core: autoconverge and compression taken from legacy policy
When the "legacy" policy is used, the configuration from cluster/vm was
supposed to be taken.
Change-Id: Ia78428fbfd5f2e6e812caf19eaaf2c8fca0dc46e
Bug-Url: https://bugzilla.redhat.com/1383738
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65383
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia78428fbfd5f2e6e812caf19eaaf2c8fca0dc46e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: autoconverge and compression taken from legacy policy
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: autoconverge and compression taken from legacy policy
......................................................................
core: autoconverge and compression taken from legacy policy
When the "legacy" policy is used, the configuration from cluster/vm was
supposed to be taken.
Change-Id: Ia78428fbfd5f2e6e812caf19eaaf2c8fca0dc46e
Bug-Url: https://bugzilla.redhat.com/1383738
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65381
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia78428fbfd5f2e6e812caf19eaaf2c8fca0dc46e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0.5]: aaa: desktopLogin sends empty password, impacts desktop SSO ...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: desktopLogin sends empty password, impacts desktop SSO feature
......................................................................
aaa: desktopLogin sends empty password, impacts desktop SSO feature
The session password is not saved
on engine and is only saved on SSO
end. Engine should make a call to
retrieve the encryped password from
SSO and use its private key to decrypt
the password.
Change-Id: If3048210dcc71a6eb4a732b347e57398213b9f72
Bug-Url: https://bugzilla.redhat.com/1381606
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
(cherry picked from commit 39b2133fbf683840af70028725774dbf2caf6d94)
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/IsPasswordDelegationPossibleQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
4 files changed, 58 insertions(+), 36 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65370
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3048210dcc71a6eb4a732b347e57398213b9f72
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Don't clean upload model on dialog closing.
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Don't clean upload model on dialog closing.
......................................................................
webadmin: Don't clean upload model on dialog closing.
Patch I363d06219af83bd21e6384840bf9a969331a9959 introduced a better
handling of model objects, which makes the dialogs in the system to
clean up their related models.
In UploadImageModel, the model is still alive as it is used to upload
the user's file- so it shouldn't be cleaned while the upload dialog is
closed.
This patch removes the cleaning of the model in UploadImagePopupView.
Change-Id: I91b40d5a78d190c16d78e950c892638ea839580e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368101
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65365
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91b40d5a78d190c16d78e950c892638ea839580e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-release[ovirt-4.0.5]: build: 4.0.5-2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: 4.0.5-2
......................................................................
build: 4.0.5-2
Change-Id: I42e36d24aad75d2e6ef8ba17a161f23e2d279153
---
M configure.ac
M ovirt-release40.spec.in
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65385
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42e36d24aad75d2e6ef8ba17a161f23e2d279153
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months