Change in ovirt-engine[master]: webadmin: Sort VM instance images by disk alias
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Sort VM instance images by disk alias
......................................................................
webadmin: Sort VM instance images by disk alias
Change-Id: Ida7f52c843c46d94b6a6e23530b483f098ed41b6
Bug-Url: https://bugzilla.redhat.com/1381322
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Verified; Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/65266
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida7f52c843c46d94b6a6e23530b483f098ed41b6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: spec: move engine/constants.py to engine-common package
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: spec: move engine/constants.py to engine-common package
......................................................................
spec: move engine/constants.py to engine-common package
Keep the file in the same place in both source and installation target,
but package it in ovirt-engine-setup-plugin-ovirt-engine-common, as
it turns out that some external packages require constants from it.
Change-Id: Ie389d11e9e2ea52a620b5ef23fefd8bca3bd8e12
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1263785
Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Ido Rosenzwig: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64489
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie389d11e9e2ea52a620b5ef23fefd8bca3bd8e12
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[master]: Add extern keyword to variables declared in headers
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Add extern keyword to variables declared in headers
......................................................................
Add extern keyword to variables declared in headers
Otherwise the XCode compiler used in Mac OS isn't able to complete the link.
Change-Id: I17ddbb216b3952a6e25794982340d8aa4fa085b3
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/ext/ovirtsdk4c/ov_http_client.c
M sdk/ext/ovirtsdk4c/ov_http_client.h
M sdk/ext/ovirtsdk4c/ov_http_request.c
M sdk/ext/ovirtsdk4c/ov_http_request.h
M sdk/ext/ovirtsdk4c/ov_http_response.c
M sdk/ext/ovirtsdk4c/ov_http_response.h
6 files changed, 23 insertions(+), 8 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65222
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17ddbb216b3952a6e25794982340d8aa4fa085b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Gluster role for network
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Gluster role for network
......................................................................
restapi: Gluster role for network
Support adding gluster role for network
Bug-Url: https://bugzilla.redhat.com/1379225
Change-Id: I891cf5a26f6724a5665a7db9b6b3766b1be664e4
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Sahina Bose: Verified
--
To view, visit https://gerrit.ovirt.org/65218
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I891cf5a26f6724a5665a7db9b6b3766b1be664e4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: Fix NPE on new instance image creation
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix NPE on new instance image creation
......................................................................
webadmin: Fix NPE on new instance image creation
Change-Id: I40ceec10d297f44071f919b4e2dfd05728d64943
Bug-Url: https://bugzilla.redhat.com/1382357
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65172
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40ceec10d297f44071f919b4e2dfd05728d64943
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: aaa: desktopLogin sends empty password, impacts desktop SSO ...
by mperina@redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: desktopLogin sends empty password, impacts desktop SSO feature
......................................................................
aaa: desktopLogin sends empty password, impacts desktop SSO feature
The session password is not saved
on engine and is only saved on SSO
end. Engine should make a call to
retrieve the encryped password from
SSO and use its private key to decrypt
the password.
Change-Id: If3048210dcc71a6eb4a732b347e57398213b9f72
Bug-Url: https://bugzilla.redhat.com/1381606
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/IsPasswordDelegationPossibleQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
4 files changed, 58 insertions(+), 36 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65136
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3048210dcc71a6eb4a732b347e57398213b9f72
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: Fix memory leak in Permission popup
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Fix memory leak in Permission popup
......................................................................
webadmin: Fix memory leak in Permission popup
- Fixed memory leak in the permissions and add user dialog
Change-Id: I661a0f3da1588836fe17a47e825143483b6af993
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368101
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/PermissionsPopupView.java
2 files changed, 10 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Verified; Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64539
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I661a0f3da1588836fe17a47e825143483b6af993
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[sdk_4.0]: Include examples direcotry in source tarball file
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Include examples direcotry in source tarball file
......................................................................
Include examples direcotry in source tarball file
This patch add examples directory as directory which,
should be included in tarball file build by setuptools.
Change-Id: I04666b2761c3a856fc11ac49cfec40dc36762fae
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/MANIFEST.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65243
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04666b2761c3a856fc11ac49cfec40dc36762fae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-live[master]: repos: move from Virt SIG oVirt 4.0 to 4.1
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: repos: move from Virt SIG oVirt 4.0 to 4.1
......................................................................
repos: move from Virt SIG oVirt 4.0 to 4.1
Change-Id: I0cec0d855facc090078bb8430ebf29c349b7de34
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65241
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0cec0d855facc090078bb8430ebf29c349b7de34
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[sdk_4.0]: Add examples to the RPM packages
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Add examples to the RPM packages
......................................................................
Add examples to the RPM packages
This patch changes the RPM .spec files so that the examples are pacaked and
marked as documentation.
Change-Id: Ide04a1be04172494f0e1b97c17e554a700eb60ae
Bug-Url: https://bugzilla.redhat.com/1382644
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/spec.el7.in
M packaging/spec.fc23.in
M packaging/spec.fc24.in
3 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65221
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide04a1be04172494f0e1b97c17e554a700eb60ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months