Change in ovirt-engine[ovirt-engine-4.0.6]: core: show full vm history graphs
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: show full vm history graphs
......................................................................
core: show full vm history graphs
Recent changes related to VM usage histories lead to a bug in
which only the latest value of cpu/memory/network usage is
presented instead of the last 40 values. This bug provides
the minimal change that can fix this.
Note that this is a 4.0 only fix.
Change-Id: Ieb1a54d80af20c500fb4a8491b618a50d9a35dcd
Bug-Url: https://bugzilla.redhat.com/1397279
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67405
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb1a54d80af20c500fb4a8491b618a50d9a35dcd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.6
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0.6]: core: improving vms_with_tags view performance
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: improving vms_with_tags view performance
......................................................................
core: improving vms_with_tags view performance
1) Adding "DISTINCT" to the view to eliminate duplications
2) Changing the "WHERE" condition to include VMs once and include also
VMs that have no disks
Patch was tested on the customer DB reported in the BZ and showed
significant performance
Change-Id: Ib5a6637b7c890e445940c8d0a770c2bd7e11e72b
Bug-Url: https://bugzilla.redhat.com/1398550
Signed-off-by: emesika <emesika(a)redhat.com>
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67324
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5a6637b7c890e445940c8d0a770c2bd7e11e72b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.6
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk[master]: Update to model 4.1.21 and metamodel 1.1.9
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to model 4.1.21 and metamodel 1.1.9
......................................................................
Update to model 4.1.21 and metamodel 1.1.9
The more relevant changes in this version of the model are the
following:
* Add `seal` operation to the service that manages templates.
* Add `progress` attribute to the `Disk` and `Step` types.
* Add `allow_partial_import` parameter to the operations that import
virtual machines and templates.
* Add `ticket` operation to the service that manages the graphics
console of a virtual machine.
Change-Id: I8b84c1610d4dddb662f9caf99121b2121c8fdaf1
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved; Passed CI tests
Juan Hernandez: Verified
--
To view, visit https://gerrit.ovirt.org/67402
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b84c1610d4dddb662f9caf99121b2121c8fdaf1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: core: show full vm history graphs
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: show full vm history graphs
......................................................................
core: show full vm history graphs
Recent changes related to VM usage histories lead to a bug in
which only the latest value of cpu/memory/network usage is
presented instead of the last 40 values. This bug provides
the minimal change that can fix this.
Note that this is a 4.0 only fix.
Change-Id: Ieb1a54d80af20c500fb4a8491b618a50d9a35dcd
Bug-Url: https://bugzilla.redhat.com/1397279
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/67368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb1a54d80af20c500fb4a8491b618a50d9a35dcd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: core: improving vms_with_tags view performance
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: improving vms_with_tags view performance
......................................................................
core: improving vms_with_tags view performance
1) Adding "DISTINCT" to the view to eliminate duplications
2) Changing the "WHERE" condition to include VMs once and include also
VMs that have no disks
Patch was tested on the customer DB reported in the BZ and showed
significant performance
Change-Id: Ib5a6637b7c890e445940c8d0a770c2bd7e11e72b
Bug-Url: https://bugzilla.redhat.com/1398550
Signed-off-by: emesika <emesika(a)redhat.com>
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67323
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5a6637b7c890e445940c8d0a770c2bd7e11e72b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk-java[master]: Add example that lists VM snapshots
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add example that lists VM snapshots
......................................................................
Add example that lists VM snapshots
This patch adds an example that lists all the snapshots that exist in
the system, and where the disks are stored.
Change-Id: Ie71c8582135784d67650cbd1be341e6e2364c2db
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListVmSnapshots.java
1 file changed, 109 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67299
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie71c8582135784d67650cbd1be341e6e2364c2db
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: Insufficient thread synchronization
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: Insufficient thread synchronization
......................................................................
core: Insufficient thread synchronization
Usage of ConcurrentHashMap is insufficient here, there still could be
race.
Change-Id: Ia993af9be9c7d15cec7e9c7deddc8e6d8866fac7
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactory.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67101
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia993af9be9c7d15cec7e9c7deddc8e6d8866fac7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: webadmin: Sort exported entities by export or creation dates...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Sort exported entities by export or creation dates correctly
......................................................................
webadmin: Sort exported entities by export or creation dates correctly
The sorting of the creation and export dates in the exported VMs and
templates subtabs in an export domain was done alphabetically causing
a wrong order in most time (i.e. April comes before January), this patch
fixes it by doing the comparison by dates as it should be
Change-Id: I49794a9611f402aca23725f2442e78c516af4e82
Bug-Url: https://bugzilla.redhat.com/1398579
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java
2 files changed, 26 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67377
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49794a9611f402aca23725f2442e78c516af4e82
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: reconstruct never succeeds when the master is v4
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: core: reconstruct never succeeds when the master is v4
......................................................................
core: reconstruct never succeeds when the master is v4
Currently we use the DisconnectPoolOnReconstruct config value to
determine whether its needed to disconnect from the storage pool
or not during reconstruct.
When V4 was added, it wasn't added to this config value. While we
should change the disconnect to be true by default - this patch adds it
to the config value in the meanwhile.
Change-Id: I64e24cf7f31926415170085a8ca79696796c93e6
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67376
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64e24cf7f31926415170085a8ca79696796c93e6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: restapi: Update to model 4.1.21 and metamodel 1.1.9
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Update to model 4.1.21 and metamodel 1.1.9
......................................................................
restapi: Update to model 4.1.21 and metamodel 1.1.9
The more relevant changes in this version of the model are the
following:
* Deprecate the `legacy` USB type.
* Add `remoteviewerconnectionfile` action to the `GraphicsConsole`
service.
* Add `max` attribute to the `MemoryPolicy` type.
* Add `seal` operation to the service that manages templates.
* Add `progress` attribute to the `Disk` and `Step` types.
* Add `allow_partial_import` parameter to the operations that import
virtual machines and templates.
* Add `ticket` operation to the service that manages the graphics
console of a virtual machine.
The more relevant changes in this version of the metamodel are the
following:
* Add `MemoryPolicy.max` to the list of exceptions of integer
attributes that are represented using `xs:long` instead of `xs:int`.
* Remove the document title from the generated AsciiDoc documentation.
* Don't add to the title of tables of attributes and parameters the
number of elements.
* Fix the width of the enum summary column.
* Adjust table column widths so that the resultin HTML generated by
Publican is correctly rendered.
Change-Id: I4cf90a5cb9b7d6ca3ef60770b2fcc0fe32b1295b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Shmuel Leib Melamud: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67239
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cf90a5cb9b7d6ca3ef60770b2fcc0fe32b1295b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months