November 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: change ost jobs chroot from fc23 to el7
by Code Review 10 Nov '16

10 Nov '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: change ost jobs chroot from fc23 to el7 ...................................................................... change ost jobs chroot from fc23 to el7 - moving to el7 will allow us to keep config longer and not replace it every 6 months Change-Id: I141e5e3aab3efefc48cf1520eec16ed3f206c17c Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml M jobs/confs/projects/ovirt/test-experimental-latest-repo.yaml 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I141e5e3aab3efefc48cf1520eec16ed3f206c17c Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <sharonaftaly(a)gmail.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Update OVF in storage domains for HE VM edit
by Code Review 10 Nov '16

10 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Update OVF in storage domains for HE VM edit ...................................................................... core: Update OVF in storage domains for HE VM edit Updating hosted engine VM saves OVF to storage domain as well as to the DB. This patch is complementary to: https://gerrit.ovirt.org/#/c/51842 Change-Id: Ib02d41136458677399428c62c8e475b4cb2fcb79 Bug-Url: https://bugzilla.redhat.com/1343991 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 2 files changed, 21 insertions(+), 22 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/66259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib02d41136458677399428c62c8e475b4cb2fcb79 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: allow empty target vnic profile in the mapping
by Code Review 10 Nov '16

10 Nov '16

>From Oved Ourfali <oourfali(a)redhat.com>: Oved Ourfali has submitted this change and it was merged. Change subject: restapi: allow empty target vnic profile in the mapping ...................................................................... restapi: allow empty target vnic profile in the mapping Allow empty vnic profile as the target mapping. Change-Id: I8034126b0b0139a73183ea49f80d6e6dd2022726 Bug-Url: https://bugzilla.redhat.com/1277675 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ExternalVnicProfileMappingMapper.java 2 files changed, 10 insertions(+), 7 deletions(-) Approvals: Oved Ourfali: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8034126b0b0139a73183ea49f80d6e6dd2022726 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: map vNic profiles according to the supplied mapping
by Code Review 10 Nov '16

10 Nov '16

>From Oved Ourfali <oourfali(a)redhat.com>: Oved Ourfali has submitted this change and it was merged. Change subject: engine: map vNic profiles according to the supplied mapping ...................................................................... engine: map vNic profiles according to the supplied mapping Map vNics according to the supplied mapping in ImportVmFromConfigurationCommand. Change-Id: I42827607fb03d66ba725288ddbe49f21d1436e3c Bug-Url: https://bugzilla.redhat.com/1277675 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromConfigurationCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportedNetworkInfoUpdater.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/TargetVnicProfileFinder.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportedNetworkInfoUpdaterTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/TargetVnicProfileFinderTest.java 5 files changed, 276 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42827607fb03d66ba725288ddbe49f21d1436e3c Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: add validation for vNic profile mappings
by Code Review 10 Nov '16

10 Nov '16

>From Oved Ourfali <oourfali(a)redhat.com>: Oved Ourfali has submitted this change and it was merged. Change subject: engine: add validation for vNic profile mappings ...................................................................... engine: add validation for vNic profile mappings Add validation for vNic profile mappings in ImportVmFromConfigurationCommand. Change-Id: I1d66cde99a0182bfde31031a8b0b5ddc034fe8be Bug-Url: https://bugzilla.redhat.com/1277675 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExternalVnicProfileMappingValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromConfigurationCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/VnicProfileValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ExternalVnicProfileMappingValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVMFromConfigurationCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/VnicProfileValidatorTest.java 6 files changed, 268 insertions(+), 5 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d66cde99a0182bfde31031a8b0b5ddc034fe8be Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: support vnic_profile_mappings in register VM
by Code Review 10 Nov '16

10 Nov '16

>From Oved Ourfali <oourfali(a)redhat.com>: Oved Ourfali has submitted this change and it was merged. Change subject: restapi: support vnic_profile_mappings in register VM ...................................................................... restapi: support vnic_profile_mappings in register VM Support vnic_profile_mappings and reassign_bad_macs in BackendStorageDomainVmResource.register. Change-Id: Ifcd09c7f8d5b11332d3d9e60bd59aaa636da7974 Bug-Url: https://bugzilla.redhat.com/1277675 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ExternalVnicProfileMappingMapper.java 3 files changed, 88 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Martin Mucha: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcd09c7f8d5b11332d3d9e60bd59aaa636da7974 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: remove fc22 from config files and mock
by Code Review 10 Nov '16

10 Nov '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: remove fc22 from config files and mock ...................................................................... remove fc22 from config files and mock Change-Id: I737f88e95803bab8334cb5b86c4f388a95a0959a Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ioprocess/ioprocess.yaml D mock_configs/fedora-22-x86_64.cfg D mock_configs/fedora-22-x86_64_proxied.cfg M mock_configs/mock_runner.sh 4 files changed, 7 insertions(+), 143 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests Evgheni Dereveanchin: Looks good to me -- To view, visit https://gerrit.ovirt.org/66374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I737f88e95803bab8334cb5b86c4f388a95a0959a Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Revert to JNDI lookup in EngineLock#close
by Code Review 10 Nov '16

10 Nov '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: backend: Revert to JNDI lookup in EngineLock#close ...................................................................... backend: Revert to JNDI lookup in EngineLock#close Change-Id: I5e12276ca36a23cdbbadd370f4ffff22ab435abe Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/EngineLock.java 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved; Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/66377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e12276ca36a23cdbbadd370f4ffff22ab435abe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Extended Correlation ID capability and logging
by Code Review 10 Nov '16

10 Nov '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: Extended Correlation ID capability and logging ...................................................................... Extended Correlation ID capability and logging This patch introduces the correlation id (CID) tracking for queries. All incoming Rest API and Gwt RPC Api endpoints are now equipped with the Correlation-Id header feature which allows an API user to assign a CID in the request headers. If the header is not present, the engine will generate for each request a new CID. The used CID is passed back in the response as the Correlation-Id header in the response. Additionally to the header, the CID can now be also passed in as correlation_id query parameter, which might be most interesting to the REST Api All queries are now logging the time spent and print the configured CID. This feature has been added with the intend to allow better analysis of slow tasks which come in through the REST API and/or the GWT RPC API. Bug-Url: https://bugzilla.redhat.com/1347631 Change-Id: I67b45c14649bec21b2772f545bfde75aec9349b0 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/HasCorrelationId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/CurrentFilter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 12 files changed, 173 insertions(+), 23 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified -- To view, visit https://gerrit.ovirt.org/61986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67b45c14649bec21b2772f545bfde75aec9349b0 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobCallback - unreported job when entity pollin...
by Code Review 10 Nov '16

10 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCallback - unreported job when entity polling isn't supported ...................................................................... core: StorageJobCallback - unreported job when entity polling isn't supported This patch adds modifies StorageJobCallback to support handling of commands that doesn't support entity polling (for example: Storage Domain commands) when the executed job isn't reported by the performing host. That scenario might happen as job are cleared randomally from the host report. When a job isn't reported, we can determine the job status by using entity polling if it is supported (as the result will be determined by the entity). If entity polling isn't supported - the callback will now assume the job has failed so that the command will end. There is no point in continue polling as the status isn't reflected on the entity and the job status was cleared from the host report. Change-Id: I6a79ef2ac1c531c97e2d5dc169c785b5567d773f Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java 1 file changed, 32 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/65863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a79ef2ac1c531c97e2d5dc169c785b5567d773f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0