November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: StorageJobCallback - moving code out of try block
by Code Review 10 Nov '16

10 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCallback - moving code out of try block ...................................................................... core: StorageJobCallback - moving code out of try block moving code out of the try block, exception while executing the moved code (which should never happen) will be cought wrongfully. Change-Id: I83166f37be7d7bb8a6114cd43657efc8ad8573f8 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83166f37be7d7bb8a6114cd43657efc8ad8573f8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: el7: Add CentOS oVirt common candidate repo
by Code Review 10 Nov '16

10 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: el7: Add CentOS oVirt common candidate repo ...................................................................... el7: Add CentOS oVirt common candidate repo Needed for ansible. Change-Id: I0071fc73a9ddd241cd2591f4ed2c98d53e57fb6e Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-el7-deps.repo.in 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/66372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0071fc73a9ddd241cd2591f4ed2c98d53e57fb6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: nsis-simple-service-plugin: Remove 3.6
by Code Review 10 Nov '16

10 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: nsis-simple-service-plugin: Remove 3.6 ...................................................................... nsis-simple-service-plugin: Remove 3.6 Change-Id: I3e2e98fc8029c07010c3561018d69da6069b4d3d Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/confs/projects/nsis-simple-service-plugin/nsis-simple-service-plugin.yaml 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e2e98fc8029c07010c3561018d69da6069b4d3d Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: fix the upgrade script that converts memory volumes to...
by Code Review 10 Nov '16

10 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: fix the upgrade script that converts memory volumes to disks ...................................................................... core: fix the upgrade script that converts memory volumes to disks This patch fixes yet another problem that was found in the upgrade script that converts snapshot's memory volumes to disks in the database. This time the problem is with using 'NOT IN <set>' where the set could have NULL values (therefore the fix is to filter the NULL values from the set). Change-Id: I48103802395e58afb155a4501e36c256dbf65084 Bug-Url: https://bugzilla.redhat.com/1390254 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/66313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48103802395e58afb155a4501e36c256dbf65084 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetCpuProfilesByClusterIdQuery Daos
by Code Review 10 Nov '16

10 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: @Inject GetCpuProfilesByClusterIdQuery Daos ...................................................................... core: @Inject GetCpuProfilesByClusterIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I84a6bcbb93b20e6ffb5a40f15c4b26de32fb432c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetCpuProfilesByClusterIdQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84a6bcbb93b20e6ffb5a40f15c4b26de32fb432c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetDiskProfilesByStorageDomainIdQuery Daos
by Code Review 10 Nov '16

10 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: @Inject GetDiskProfilesByStorageDomainIdQuery Daos ...................................................................... core: @Inject GetDiskProfilesByStorageDomainIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I979d1c2e65757d6abef9a82fd7a8e5416a0602d6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetDiskProfilesByStorageDomainIdQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I979d1c2e65757d6abef9a82fd7a8e5416a0602d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetDiskProfileByIdQuery Daos
by Code Review 10 Nov '16

10 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: @Inject GetDiskProfileByIdQuery Daos ...................................................................... core: @Inject GetDiskProfileByIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I6017502d79fedf45ecbb271a2862a27f73047bc4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetDiskProfileByIdQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6017502d79fedf45ecbb271a2862a27f73047bc4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetCpuProfileByIdQuery Daos
by Code Review 10 Nov '16

10 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: @Inject GetCpuProfileByIdQuery Daos ...................................................................... core: @Inject GetCpuProfileByIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I319e9b6de0dce68aebb3ee25d577ebcd2bea7084 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetCpuProfileByIdQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I319e9b6de0dce68aebb3ee25d577ebcd2bea7084 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllDiskProfilesQuery Daos
by Code Review 10 Nov '16

10 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: @Inject GetAllDiskProfilesQuery Daos ...................................................................... core: @Inject GetAllDiskProfilesQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ib2069747751f18cb5e10fba218fb44a0bd5fb43c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetAllDiskProfilesQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2069747751f18cb5e10fba218fb44a0bd5fb43c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllCpuProfilesQuery Daos
by Code Review 10 Nov '16

10 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: @Inject GetAllCpuProfilesQuery Daos ...................................................................... core: @Inject GetAllCpuProfilesQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I5d786fef572bfc9a981adc1923aa84388662b0cc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetAllCpuProfilesQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d786fef572bfc9a981adc1923aa84388662b0cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0