November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: upload: Support supplied image for an image transfer.
by Code Review 03 Nov '16

03 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: upload: Support supplied image for an image transfer. ...................................................................... upload: Support supplied image for an image transfer. For REST API support, we want to be able to execute the upload command with a supplied image. Currently when executing the command, the image is created. This patch will create the image only if no image was supplied, otherwise, set needed parameters for the command according to the supplied image. Add tests for the upload command, verifying this change. Change-Id: I41066d1b8d2d7b18e4ceb12e1754b99189b3b258 Bug-Url: https://bugzilla.redhat.com/1337077 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageParameters.java 5 files changed, 392 insertions(+), 31 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/65959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41066d1b8d2d7b18e4ceb12e1754b99189b3b258 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: upload: Add queries for image transfer entity
by Code Review 03 Nov '16

03 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: upload: Add queries for image transfer entity ...................................................................... upload: Add queries for image transfer entity Add: * GetImageTransferByIdQuery * GetAllImageTransfersQuery Change-Id: I96752e1b6caa19d45a40561c2455dd90a4010f07 Bug-Url: https://bugzilla.redhat.com/1337077 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetAllImageTransfersQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetImageTransferByIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageTransfer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/SearchType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDaoImpl.java 8 files changed, 68 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/65960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96752e1b6caa19d45a40561c2455dd90a4010f07 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Present the name of the active slave in a "bonded"...
by Code Review 02 Nov '16

02 Nov '16

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Present the name of the active slave in a "bonded" interface ...................................................................... webadmin: Present the name of the active slave in a "bonded" interface The information of the active slave in a "bonded" interface is presented to the user. The already existing tooltip of the bond icon in the BondPanel currently shows properties, like the status, of the bond. This patch extends the tooltip by an additional line, which contains the name of the active slave interface. This is done in the BondPanel, because the active slave is handled as a read-only property of the bond. Change-Id: I8ac5e308eba8774388372a60c4fccaef99f04385 Bug-Url: https://bugzilla.redhat.com/1038550 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages.properties 3 files changed, 6 insertions(+), 0 deletions(-) Approvals: Dominik Holler: Verified Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ac5e308eba8774388372a60c4fccaef99f04385 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Updating the engine data from Vdsm
by Code Review 02 Nov '16

02 Nov '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Updating the engine data from Vdsm ...................................................................... engine: Updating the engine data from Vdsm To prepare exposing the information of the active slave in a "bonded" interface, the information is consumed from Vdsm and stored in the data model of the engine. Change-Id: Ifee9c0f5526b4bd81ba3ce0f01da028b9aeaee08 Bug-Url: https://bugzilla.redhat.com/1038550 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Dominik Holler: Verified Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifee9c0f5526b4bd81ba3ce0f01da028b9aeaee08 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Replace 'detach to' with 'detach from'
by Code Review 02 Nov '16

02 Nov '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: Replace 'detach to' with 'detach from' ...................................................................... core: Replace 'detach to' with 'detach from' Change-Id: I7b7494e7ee09481f674f51158d41c525a9d350c7 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/65980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b7494e7ee09481f674f51158d41c525a9d350c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add Travis CI configuration
by Code Review 02 Nov '16

02 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add Travis CI configuration ...................................................................... Add Travis CI configuration This patch adds the .travis.yml file in order to configure builds in the Travis CI environment, in particular to configure builds for Mac OS X. Change-Id: I8e046d0ccac3512ea269c4397365a4d9e43d0281 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A .travis.yml 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e046d0ccac3512ea269c4397365a4d9e43d0281 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove vm usage related histories from the database
by Code Review 02 Nov '16

02 Nov '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove vm usage related histories from the database ...................................................................... core: remove vm usage related histories from the database Now that VmStatistics are cached in VmManager, there is no need to dump several things they contain to the database. However, since we currently focus on easy and non-risky things, this patch addresses specifically the memory/cpu/network usage histories - these are really redundant being the database as they are only used by the webadmin that gathers the information using a (search) query that takes this information from VmManager. Unfortunately, we can neither drop the whole statistics from the database nor reduce the frequency of the updates at this stage. This kind of changes can improve performance on large-scale setups significantely since they reduce the amount of data dump into the database substantially. Change-Id: If72063205907c21d9bd80610a1c1ea1356a9c5e6 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_01_0390_remove_vm_related_usage_histories.sql M packaging/dbscripts/vms_sp.sql 6 files changed, 3 insertions(+), 78 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65787 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72063205907c21d9bd80610a1c1ea1356a9c5e6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: add new column displaying clusters switch type.
by Code Review 02 Nov '16

02 Nov '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: add new column displaying clusters switch type. ...................................................................... webadmin: add new column displaying clusters switch type. Change-Id: I4ddc91aa1ccd0e086479a779a7ca3a2ad52ddbc3 Bug-Url: https://bugzilla.redhat.com/1362401 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ClusterConditionFieldAutoCompleter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 4 files changed, 19 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ddc91aa1ccd0e086479a779a7ca3a2ad52ddbc3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fixes of ipv6 annotations
by Code Review 02 Nov '16

02 Nov '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: fixes of ipv6 annotations ...................................................................... core: fixes of ipv6 annotations Change-Id: I6748188add092dbbed6c5e9bea00c7a96ec8c605 Bug-Url: https://bugzilla.redhat.com/1160667 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/IpV6Address.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/Ipv6Constraint.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/Ipv6.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/Ipv6ConstraintTest.java 4 files changed, 32 insertions(+), 42 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6748188add092dbbed6c5e9bea00c7a96ec8c605 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: report SwitchType also on bonds
by Code Review 02 Nov '16

02 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: report SwitchType also on bonds ...................................................................... core: report SwitchType also on bonds • all networks get same switch type, so it need not be specified per HostNetwork. It should be sufficient to have it specified only once in paramaters class. • onces that's done, we need not to update CreateOrUpdateBond class with SwitchType just as HostNetwork used to contain it (which would be totally incorrect(*)), and use SwitchType from parameters class. (*) it's problematic to share TO to pass data between more than 2 app layers. It can work, until all its data makes sense everywhere, but here we need only to pass switch type of CreateOrUpdateBond from bll to vdsm. It's totally meaningless for UI and thus it must not be added into this class. Change-Id: Id5a8d2ebc70eb50a73d9c379beb0ea18e5a50ef1 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostSetupNetworksVdsCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java 4 files changed, 35 insertions(+), 27 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Oved Ourfali: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5a8d2ebc70eb50a73d9c379beb0ea18e5a50ef1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0