Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: better checking maintenance mode at engine level
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: better checking maintenance mode at engine level
......................................................................
upgrade: better checking maintenance mode at engine level
The auto-import of the hosted-engine storage domain from the
engine will change its SP so simply checking the list of
connected storage pool is safer.
vsdcli.list() returns a list of dictionaries, fixing it
to avoid 'unhashable type: 'dict''.
Bug-Url: https://bugzilla.redhat.com/1295427
Change-Id: I0d0389594c96c54653640b72d9acf4faf71e802a
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit f30e1c09f6f6d1f520c4408c179321a60ec052d2)
---
M ovirt_hosted_engine_ha/lib/upgrade.py
1 file changed, 20 insertions(+), 19 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53755
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d0389594c96c54653640b72d9acf4faf71e802a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: packaging: engine-backup: Allow branding of help url
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: engine-backup: Allow branding of help url
......................................................................
packaging: engine-backup: Allow branding of help url
Bug-Url: https://bugzilla.redhat.com/1217405
Change-Id: I48f1da61d97a38211788d912aac11af00f6e2acb
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 56f9a97ede71255771a36e7ba959994c6c62e845)
---
M packaging/bin/engine-backup.sh
1 file changed, 29 insertions(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/53765
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48f1da61d97a38211788d912aac11af00f6e2acb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: packaging: engine-backup: Allow branding of help url
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: engine-backup: Allow branding of help url
......................................................................
packaging: engine-backup: Allow branding of help url
Bug-Url: https://bugzilla.redhat.com/1217405
Change-Id: I48f1da61d97a38211788d912aac11af00f6e2acb
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 56f9a97ede71255771a36e7ba959994c6c62e845)
---
M packaging/bin/engine-backup.sh
1 file changed, 29 insertions(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/53764
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48f1da61d97a38211788d912aac11af00f6e2acb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: No validation for 'passthrough' profile DCs less th...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: No validation for 'passthrough' profile DCs less than 3.6
......................................................................
engine: No validation for 'passthrough' profile DCs less than 3.6
Change-Id: I1fd16737724ff2d9cf40df17b6b3bc87ede61e51
Bug-Url: https://bugzilla.redhat.com/1297454
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 107 insertions(+), 27 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53767
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fd16737724ff2d9cf40df17b6b3bc87ede61e51
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Fixing updating of HostNicVfsConfig table
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Fixing updating of HostNicVfsConfig table
......................................................................
engine: Fixing updating of HostNicVfsConfig table
Change-Id: I10ecad6c2f03e336e2d5adcb9a3a2300583eeba2
Bug-Url: https://bugzilla.redhat.com/1303640
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNicVfsConfig.java
2 files changed, 50 insertions(+), 46 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53766
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10ecad6c2f03e336e2d5adcb9a3a2300583eeba2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: engine: fix typo - 'returned' rather than 'returend'
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: fix typo - 'returned' rather than 'returend'
......................................................................
engine: fix typo - 'returned' rather than 'returend'
Change-Id: If171e75b42c27682abc0f0712203c68ca2df568d
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/53778
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If171e75b42c27682abc0f0712203c68ca2df568d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: engine: No validation for 'passthrough' profile DCs less th...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: No validation for 'passthrough' profile DCs less than 3.6
......................................................................
engine: No validation for 'passthrough' profile DCs less than 3.6
Change-Id: I1fd16737724ff2d9cf40df17b6b3bc87ede61e51
Bug-Url: https://bugzilla.redhat.com/1297454
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 107 insertions(+), 27 deletions(-)
Approvals:
Alona Kaplan: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/53429
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fd16737724ff2d9cf40df17b6b3bc87ede61e51
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: engine: Fixing updating of HostNicVfsConfig table
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Fixing updating of HostNicVfsConfig table
......................................................................
engine: Fixing updating of HostNicVfsConfig table
Change-Id: I10ecad6c2f03e336e2d5adcb9a3a2300583eeba2
Bug-Url: https://bugzilla.redhat.com/1303640
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNicVfsConfig.java
2 files changed, 50 insertions(+), 46 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/53393
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10ecad6c2f03e336e2d5adcb9a3a2300583eeba2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: refactoring in vms-monitoring
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: refactoring in vms-monitoring
......................................................................
core: refactoring in vms-monitoring
1. Rename VmsMonitoring#tryLockVmForUpdate to shouldAnalyzeVm since
this method does more than just locking the VM in order to validate
that the VM can be updated according to the data received.
2. Remove the misleading comment for that method. It is private mehtod
and its name describes its responsibility so no need a new comment.
3. Move that method so that the order of the methods in VmsMonitoring
will be more similar to the control flow.
Change-Id: Icc7c43b0ade57a775ecc3b3ab52bc84289e35de2
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
1 file changed, 28 insertions(+), 32 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/53716
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc7c43b0ade57a775ecc3b3ab52bc84289e35de2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: frontend: Only warn on timezone difference for Windows VMs
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: frontend: Only warn on timezone difference for Windows VMs
......................................................................
frontend: Only warn on timezone difference for Windows VMs
Due to the fact that Linux systems are recommended to use UTC as timezone
for the RTC clock, the check is only useful for Windows VMs due to the fact
that normally the local timezone is stored in the RTC clock for windows.
The warning basically will indicate a discrepancy between what's configured
in the VM dialog as RTC time offset and what's actually configured in the OS.
Since the value will be reset to what's set in the VM Dialog that is a good
thing to warn the users about.
Change-Id: I5b77a412f2a5b3929e7a8dface0e9273fdec8fdb
Bug-Url: https://bugzilla.redhat.com/1281871
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VmStatusCell.java
1 file changed, 17 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
Vinzenz Feenstra: Verified
--
To view, visit https://gerrit.ovirt.org/53754
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b77a412f2a5b3929e7a8dface0e9273fdec8fdb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months