February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Add link to browser compatibility warning
by piotr.kliczewski＠gmail.com 19 Feb '16

19 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Add link to browser compatibility warning ...................................................................... webadmin: Add link to browser compatibility warning - Added a link to webadmin log in page compatibility warning to point to www.ovirt.org/Download that contains more info on the supported browsers. Change-Id: Icdecc98a4e04d357c560eefb332dfa404bbcd91a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1188229 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.java M packaging/branding/ovirt.brand/external_resources.properties 6 files changed, 22 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdecc98a4e04d357c560eefb332dfa404bbcd91a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in jenkins[master]: build_mock_srcrpm_releng: fix archiving
by sbonazzo＠redhat.com 19 Feb '16

19 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build_mock_srcrpm_releng: fix archiving ...................................................................... build_mock_srcrpm_releng: fix archiving fixed archiving of the first stage src.rpm it was wrongly added to exported-artifacts. Change-Id: Ia73100c863db52cff8b7f0b8490c6fce1dbed9aa Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/shell-scripts/build_mock_srcrpm_releng.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Anton Marchukov: Looks good to me Jenkins CI: Passed CI tests David Caro: Looks good to me -- To view, visit https://gerrit.ovirt.org/53752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia73100c863db52cff8b7f0b8490c6fce1dbed9aa Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Add link to browser compatibility warning
by piotr.kliczewski＠gmail.com 19 Feb '16

19 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Add link to browser compatibility warning ...................................................................... webadmin: Add link to browser compatibility warning - Added a link to webadmin log in page compatibility warning to point to www.ovirt.org/Download that contains more info on the supported browsers. Change-Id: Icdecc98a4e04d357c560eefb332dfa404bbcd91a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1188229 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.java M packaging/branding/ovirt.brand/external_resources.properties 6 files changed, 22 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdecc98a4e04d357c560eefb332dfa404bbcd91a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Show browser support alert
by oourfali＠redhat.com 19 Feb '16

19 Feb '16

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Show browser support alert ...................................................................... webadmin: Show browser support alert - Show alert message when the browser the user is using is not fully supported. - Added configuration value to allow the admin of the engine to turn off the warning message. - Auto close the message after 5 seconds to not be too obtrusive. - Added external_resources entry for the documentation URL. Change-Id: Ia2403913451db4be659948951e60a0e0324362ca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1188229 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/DisplayBrowserCompatibilityWarning.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java M packaging/branding/ovirt.brand/external_resources.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 17 files changed, 115 insertions(+), 7 deletions(-) Approvals: Alexander Wels: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2403913451db4be659948951e60a0e0324362ca Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: aaa: prevent of recursion loop in flat groups
by oourfali＠redhat.com 19 Feb '16

19 Feb '16

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: prevent of recursion loop in flat groups ...................................................................... aaa: prevent of recursion loop in flat groups Change-Id: I6fc143c62d67febf010cbd0ec71d5f87bea4b25e Bug-Url: https://bugzilla.redhat.com/1301345 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java 1 file changed, 18 insertions(+), 6 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fc143c62d67febf010cbd0ec71d5f87bea4b25e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: aaa: prevent of recursion loop in flat groups
by oourfali＠redhat.com 19 Feb '16

19 Feb '16

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: prevent of recursion loop in flat groups ...................................................................... aaa: prevent of recursion loop in flat groups Change-Id: I6fc143c62d67febf010cbd0ec71d5f87bea4b25e Bug-Url: https://bugzilla.redhat.com/1301345 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java 1 file changed, 18 insertions(+), 6 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fc143c62d67febf010cbd0ec71d5f87bea4b25e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[master]: upgrade: better checking maintenance mode at engine level
by msivak＠redhat.com 19 Feb '16

19 Feb '16

Martin Sivák has submitted this change and it was merged. Change subject: upgrade: better checking maintenance mode at engine level ...................................................................... upgrade: better checking maintenance mode at engine level The auto-import of the hosted-engine storage domain from the engine will change its SP so simply checking the list of connected storage pool is safer. vsdcli.list() returns a list of dictionaries, fixing it to avoid 'unhashable type: 'dict''. Bug-Url: https://bugzilla.redhat.com/1295427 Change-Id: I0d0389594c96c54653640b72d9acf4faf71e802a Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 20 insertions(+), 19 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d0389594c96c54653640b72d9acf4faf71e802a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: exttool: aaa: fix recursive loop print
by piotr.kliczewski＠gmail.com 19 Feb '16

19 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: exttool: aaa: fix recursive loop print ...................................................................... exttool: aaa: fix recursive loop print Change-Id: I1dc28137c59480b92ac302aae8357c59ad771eb4 Bug-Url: https://bugzilla.redhat.com/1301345 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 7c45c1cbcb71fc0f888c5fcb060d4336c8c101ad) --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java 1 file changed, 16 insertions(+), 8 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53705 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dc28137c59480b92ac302aae8357c59ad771eb4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal, webadmin: disable uncaught exception popup.
by piotr.kliczewski＠gmail.com 19 Feb '16

19 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: userportal, webadmin: disable uncaught exception popup. ...................................................................... userportal, webadmin: disable uncaught exception popup. - Added the ability to disable the uncaught exception popup. Change-Id: Iad7f6888229e09ed9588e449e925ba14cfb4a387 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1309562 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/UserPortalHostPageServletTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/DisplayUncaughtUIExceptions.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 10 files changed, 50 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53702 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad7f6888229e09ed9588e449e925ba14cfb4a387 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: cleanups
by sbonazzo＠redhat.com 19 Feb '16

19 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: cleanups ...................................................................... packaging: spec: cleanups - reordered BuildRequire and added an empty line Change-Id: I597d99a08bba7eeb0174ad9dda2686eba3d14081 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53737 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I597d99a08bba7eeb0174ad9dda2686eba3d14081 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0