Change in ovirt-engine[master]: Fix the race between committed memory and pending memory upd...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: Fix the race between committed memory and pending memory updates
......................................................................
Fix the race between committed memory and pending memory updates
The pending values are cleared once the VM monitor get the asynchronous
message announcing the state change to Powering Up (via
RunVmCommnand#OnPowerringUp, SchedulingManager#clearVm and
VdsManager#updatePendingData methods). But the committed memory of host
is not recomputed here.
The committed memory is recomputed in
HostMonitoring#refreshCommitedMemory which gets called when the polling
returns new host data. But that can take up to 15 seconds.
So we have at max a 15 second window between when we clear the pending
values and when we update the committed memory information.
The solution calls refreshCommitedMemory from the updatePendingData,
and provides the list of all VMs from the DB that should already contain
the newly received VM.
Change-Id: I6aa63edbaddcca30c9898af07316facdbee01b4e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1289468
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java
2 files changed, 23 insertions(+), 15 deletions(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53063
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6aa63edbaddcca30c9898af07316facdbee01b4e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: bll: Hosted Engine editing validator
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: bll: Hosted Engine editing validator
......................................................................
bll: Hosted Engine editing validator
Adding a validator for the update Vm flow. Specifically for Hosted
Engine. Currently following the below bug we want to block that by
default.
Future hosted engine validation can go strictly into that validator or
to additional composeable constraints.
Change-Id: I7f4fc729a262de3e853d1fb51afaa235572e537e
Bug-Url: https://bugzilla.redhat.com/1305484
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/HostedEngineUpdateValidator.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/HostedEngineUpdate.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
12 files changed, 110 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/53425
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f4fc729a262de3e853d1fb51afaa235572e537e
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: scheduling: Use the right memory value for pending memory ch...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: scheduling: Use the right memory value for pending memory checks
......................................................................
scheduling: Use the right memory value for pending memory checks
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1289468
Change-Id: I41493dfbcfa7d4e1710aa0cb7619c35c24e10e7b
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManager.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified
Roy Golan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53520
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41493dfbcfa7d4e1710aa0cb7619c35c24e10e7b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: scheduling: Initialize pending resource manager after all be...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: scheduling: Initialize pending resource manager after all beans are injected
......................................................................
scheduling: Initialize pending resource manager after all beans are injected
Change-Id: I718545f3eb90c782d259f635481fc76d4d55f871
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53519
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I718545f3eb90c782d259f635481fc76d4d55f871
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Add a scroll panel to SetupNetworks networks list
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Add a scroll panel to SetupNetworks networks list
......................................................................
webadmin: Add a scroll panel to SetupNetworks networks list
When a data center contains more then 6 logical networks, the entire
contents of the Setup Host Networks popup dialog would scroll. Local
scrolling on the logical networks list is required to allow both every
logical network and every interface to be in scrolled into view.
This change will allow every logical network to be able to be assigned
to any interface by scrolling both lists as necessary.
Note: VerticalPanels have been replaced with FlowPanels to reduce the
complexity of the generated HTML.
Change-Id: I6466dace1f389ec2a0ecf5789a4ee0ecbd0eeed5
Bug-Url: https://bugzilla.redhat.com/1249895
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
2 files changed, 31 insertions(+), 19 deletions(-)
Approvals:
Vojtech Szocs: Looks good to me, approved
Oved Ourfali: Passed CI tests
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/53392
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6466dace1f389ec2a0ecf5789a4ee0ecbd0eeed5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Add a scroll panel to SetupNetworks networks list
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Add a scroll panel to SetupNetworks networks list
......................................................................
webadmin: Add a scroll panel to SetupNetworks networks list
When a data center contains more then 6 logical networks, the entire
contents of the Setup Host Networks popup dialog would scroll. Local
scrolling on the logical networks list is required to allow both every
logical network and every interface to be in scrolled into view.
This change will allow every logical network to be able to be assigned
to any interface by scrolling both lists as necessary.
Note: VerticalPanels have been replaced with FlowPanels to reduce the
complexity of the generated HTML.
Change-Id: I6466dace1f389ec2a0ecf5789a4ee0ecbd0eeed5
Bug-Url: https://bugzilla.redhat.com/1249895
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
2 files changed, 31 insertions(+), 19 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/53390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6466dace1f389ec2a0ecf5789a4ee0ecbd0eeed5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: restapi: V3 compatibility support for scheduling policies
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: V3 compatibility support for scheduling policies
......................................................................
restapi: V3 compatibility support for scheduling policies
In version 4 of the API the support for specifying the scheduling policy
name and parameters as part of the cluster was removed. Instead of that
now it is necessary to specify the identifier of a previously created
scheduling policy. Now that the API supports multiple versions this
support can be rea-added without modifying the V4 implementation. If the
identifier of the scheduling policy isn't provided, the server will
automatically select a scheduling policy that is compatible with the
parameters given by the caller. If no such scheduling policy exists an
error response will be generated.
Change-Id: Ied469fb1b00130c5a2ea21409d3d4157bb844a73
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ClusterOutAdapter.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3ClusterHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3ClusterServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3ClustersServer.java
4 files changed, 230 insertions(+), 7 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53490
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied469fb1b00130c5a2ea21409d3d4157bb844a73
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: restapi: V3 compatibility for "vm.guest_info"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: V3 compatibility for "vm.guest_info"
......................................................................
restapi: V3 compatibility for "vm.guest_info"
In version 4 of the API the "vm.guest_info" element has been removed and
replaced by the a "vm.fqdn" and the NIC reported configurations
collection. Now that the API supports multiple versions this support can
be rea-added without modifying the V4 implementation.
Change-Id: Ie4736e8ecdc917e78ee97b1cf1cbef9104f56031
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java
1 file changed, 58 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53480
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4736e8ecdc917e78ee97b1cf1cbef9104f56031
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: restapi: Make supported and default versions configurable
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Make supported and default versions configurable
......................................................................
restapi: Make supported and default versions configurable
This patch adds two new parameters to the engine local configuration
file:
ENGINE_API_DEFAULT_VERSION
Comma separated list of supported versions of the API. When the user
selects a version of the API that isn't in this list the server will
return an HTTP error response.
The default value will be "4".
ENGINE_API_SUPPORTED_VERSIONS
Default version of the API, which will be used when the caller
doesn't explicitly select a specific version.
The default value will be "3, 4".
These parameters, specially the one that sets the default version, will
be useful for environments where keeping backwards compatibility is
paramount. For example, if there are many API clients in the environment
that use version 3 of the API it is simpler to change the default used
by the server than to change all the clients to explicitly request
version 3 (using the "Version" header or the "/v3" URL prefix).
Change-Id: I876e5c1c1c9b626e5ce1e173a3c0b5555561121b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/LocalConfig.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/VersionFilter.java
M packaging/services/ovirt-engine/ovirt-engine.conf.in
3 files changed, 114 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53459
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I876e5c1c1c9b626e5ce1e173a3c0b5555561121b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Block adding host with XML-RPC protocol to 3.6 cluster
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Block adding host with XML-RPC protocol to 3.6 cluster
......................................................................
core: Block adding host with XML-RPC protocol to 3.6 cluster
Cluster levels 3.6 and above support only JSON-RPC protocol.
Attempt to add a host which is configured to work with XML-RPC
to 3.6 cluster and above, should be blocked.
Change-Id: I7a6582113ba323b54361ddf4e49cceb0ee52da00
Bug-Url: https://bugzilla.redhat.com/1289868
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsProtocol.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
8 files changed, 29 insertions(+), 23 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53381
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a6582113ba323b54361ddf4e49cceb0ee52da00
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months