Change in ovirt-engine[ovirt-engine-3.6.3]: core: adding CreateAllCinderSnapshotsCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: adding CreateAllCinderSnapshotsCommand
......................................................................
core: adding CreateAllCinderSnapshotsCommand
Adding CreateAllCinderSnapshots aggregator command.
The aggregator is needed in order to create a snapshot with
DiskImages and CinderDisks using CreateAllSnapshotsFromVmCommand.
ovirt-engine-3.6 branch only patch
Change-Id: I2cdbee8dd88b338af70cd51932842513b3a0d65c
Bug-Url: https://bugzilla.redhat.com/1304007
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllCinderSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllCinderSnapshotsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
4 files changed, 154 insertions(+), 35 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53526
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cdbee8dd88b338af70cd51932842513b3a0d65c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: core: Set parent command for child comamnd.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Set parent command for child comamnd.
......................................................................
core: Set parent command for child comamnd.
CreateAllSnapshotsFromVmCommand should initialize its child commands
with parent action type and parameters of CreateAllSnapshotsFromVmCommand.
Change-Id: I0d38dd9904a3baad487114302dd75da87bb8122f
Bug-Url: https://bugzilla.redhat.com/1305809
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/53538
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d38dd9904a3baad487114302dd75da87bb8122f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: core: RunVmCommand using callbacks
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: RunVmCommand using callbacks
......................................................................
core: RunVmCommand using callbacks
Set the commnad id and the shouldBeEndedByParent with false.
RunVmCommand is calling its only child command,
CreateAllSnapshotsFromVmCommand, form the execute command
and at the endAction phase.
Once the command is used with a callback we need to change the command
to be set with ShouldBeEndedByParent as false so the snapshot and the
disk will be unlocked.
Change-Id: I6a5889eb4ab378347baa46672afaf2edf48cd738
Bug-Url: https://bugzilla.redhat.com/1305809
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/53537
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a5889eb4ab378347baa46672afaf2edf48cd738
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: core: Validate steps using CoCo on RunVmCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Validate steps using CoCo on RunVmCommand
......................................................................
core: Validate steps using CoCo on RunVmCommand
When RunVmCommand calls CreateAllsnapshotsFromVmCommand with
execution context it should use getContext instead of cloneContext
so the executionContext of RunVmcommand should also get updated with the
relevant steps.
The reason why this should be changed is because CoCo is using the
executionContext of the command itself while the AsyncTaskManager sets
the executionContext of the child, CreateAllsnapshotsFromVmCommand, once
RunVmCommand is being called.
Once the engine also sets the context of the existing command, RunVmCommand,
the engine will not throw an NPE that the step does not exists.
Change-Id: I6dfed690d8a15684beda506808e788a2be805aa6
Bug-Url: https://bugzilla.redhat.com/1305809
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/53536
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dfed690d8a15684beda506808e788a2be805aa6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: core: Use Callback for RunVmCommand.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Use Callback for RunVmCommand.
......................................................................
core: Use Callback for RunVmCommand.
As part of the the use of ConcurrentChildCommandsExecutionCallback with
Cinder disks.
RunVmCommand should also use it since this command also running a
stateles VM.
Also fixing a dead lock when calling RestoreAllCinderSnapshotsCommand,
This only occurs in ovirt-engine-3.6 since the infrastructure in master
behaves differently.
Change-Id: I7b86461dd394aab9cd790397be21ac4d6801baa2
Bug-Url: https://bugzilla.redhat.com/1305809
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreAllCinderSnapshotsCommand.java
2 files changed, 16 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/53535
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b86461dd394aab9cd790397be21ac4d6801baa2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: core: adding CreateAllCinderSnapshotsCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: adding CreateAllCinderSnapshotsCommand
......................................................................
core: adding CreateAllCinderSnapshotsCommand
Adding CreateAllCinderSnapshots aggregator command.
The aggregator is needed in order to create a snapshot with
DiskImages and CinderDisks using CreateAllSnapshotsFromVmCommand.
ovirt-engine-3.6 branch only patch
Change-Id: I2cdbee8dd88b338af70cd51932842513b3a0d65c
Bug-Url: https://bugzilla.redhat.com/1304007
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllCinderSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllCinderSnapshotsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
4 files changed, 154 insertions(+), 35 deletions(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cdbee8dd88b338af70cd51932842513b3a0d65c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin, userportal: Pass isAdmin flag to UI
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin,userportal: Pass isAdmin flag to UI
......................................................................
webadmin,userportal: Pass isAdmin flag to UI
This patch ensures that `isAdmin` flag for the
currently logged-in user is passed to UI code.
Change-Id: I35b01de65bf25380249202a32cb6080ff08c0c70
Bug-Url: https://bugzilla.redhat.com/1304755
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/AutoLoginData.java
2 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/53530
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35b01de65bf25380249202a32cb6080ff08c0c70
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: webadmin: Add a scroll panel to SetupNetworks networks list
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Add a scroll panel to SetupNetworks networks list
......................................................................
webadmin: Add a scroll panel to SetupNetworks networks list
When a data center contains more then 6 logical networks, the entire
contents of the Setup Host Networks popup dialog would scroll. Local
scrolling on the logical networks list is required to allow both every
logical network and every interface to be in scrolled into view.
This change will allow every logical network to be able to be assigned
to any interface by scrolling both lists as necessary.
Note: VerticalPanels have been replaced with FlowPanels to reduce the
complexity of the generated HTML.
Change-Id: I6466dace1f389ec2a0ecf5789a4ee0ecbd0eeed5
Bug-Url: https://bugzilla.redhat.com/1249895
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
2 files changed, 31 insertions(+), 19 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Scott Dickerson: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/53389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6466dace1f389ec2a0ecf5789a4ee0ecbd0eeed5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: restapi: Fix typo - 'gateway' rather than 'gateawy'
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Fix typo - 'gateway' rather than 'gateawy'
......................................................................
restapi: Fix typo - 'gateway' rather than 'gateawy'
Change-Id: Ic6c1ca21a3539b1a095eb5dbd21e6c9754935444
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved; Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/53527
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6c1ca21a3539b1a095eb5dbd21e6c9754935444
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: webadmin, userportal: Pass isAdmin flag to UI
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Pass isAdmin flag to UI
......................................................................
webadmin,userportal: Pass isAdmin flag to UI
This patch ensures that `isAdmin` flag for the
currently logged-in user is passed to UI code.
Change-Id: I35b01de65bf25380249202a32cb6080ff08c0c70
Bug-Url: https://bugzilla.redhat.com/1304755
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/AutoLoginData.java
2 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/53136
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35b01de65bf25380249202a32cb6080ff08c0c70
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months