February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Block adding host with XML-RPC protocol to 3.6 cluster
by oourfali＠redhat.com 15 Feb '16

15 Feb '16

Oved Ourfali has submitted this change and it was merged. Change subject: core: Block adding host with XML-RPC protocol to 3.6 cluster ...................................................................... core: Block adding host with XML-RPC protocol to 3.6 cluster Cluster levels 3.6 and above support only JSON-RPC protocol. Attempt to add a host which is configured to work with XML-RPC to 3.6 cluster and above, should be blocked. Change-Id: I7a6582113ba323b54361ddf4e49cceb0ee52da00 Bug-Url: https://bugzilla.redhat.com/1289868 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsProtocol.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 8 files changed, 29 insertions(+), 23 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a6582113ba323b54361ddf4e49cceb0ee52da00 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: logging: remove debug message with no value
by tnisan＠redhat.com 15 Feb '16

15 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: logging: remove debug message with no value ...................................................................... logging: remove debug message with no value Whenever I set debug level I can see the same stack traces which has no value and they make it harder to spot real issues. Bug-Url: https://bugzilla.redhat.com/1306406 Change-Id: I07e85e1023ba5df20eaf49a3f29ff73a8ac1fe34 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07e85e1023ba5df20eaf49a3f29ff73a8ac1fe34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Set parent command for child comamnd.
by tnisan＠redhat.com 15 Feb '16

15 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Set parent command for child comamnd. ...................................................................... core: Set parent command for child comamnd. CreateAllSnapshotsFromVmCommand should initialize its child commands with parent action type and parameters of CreateAllSnapshotsFromVmCommand. Change-Id: I0d38dd9904a3baad487114302dd75da87bb8122f Bug-Url: https://bugzilla.redhat.com/1305809 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/53514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d38dd9904a3baad487114302dd75da87bb8122f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: RunVmCommand using callbacks
by tnisan＠redhat.com 15 Feb '16

15 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: RunVmCommand using callbacks ...................................................................... core: RunVmCommand using callbacks Set the commnad id and the shouldBeEndedByParent with false. RunVmCommand is calling its only child command, CreateAllSnapshotsFromVmCommand, form the execute command and at the endAction phase. Once the command is used with a callback we need to change the command to be set with ShouldBeEndedByParent as false so the snapshot and the disk will be unlocked. Change-Id: I6a5889eb4ab378347baa46672afaf2edf48cd738 Bug-Url: https://bugzilla.redhat.com/1305809 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/53513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a5889eb4ab378347baa46672afaf2edf48cd738 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Validate steps using CoCo on RunVmCommand
by tnisan＠redhat.com 15 Feb '16

15 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Validate steps using CoCo on RunVmCommand ...................................................................... core: Validate steps using CoCo on RunVmCommand When RunVmCommand calls CreateAllsnapshotsFromVmCommand with execution context it should use getContext instead of cloneContext so the executionContext of RunVmcommand should also get updated with the relevant steps. The reason why this should be changed is because CoCo is using the executionContext of the command itself while the AsyncTaskManager sets the executionContext of the child, CreateAllsnapshotsFromVmCommand, once RunVmCommand is being called. Once the engine also sets the context of the existing command, RunVmCommand, the engine will not throw an NPE that the step does not exists. Change-Id: I6dfed690d8a15684beda506808e788a2be805aa6 Bug-Url: https://bugzilla.redhat.com/1305809 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/53512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6dfed690d8a15684beda506808e788a2be805aa6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Use Callback for RunVmCommand.
by tnisan＠redhat.com 15 Feb '16

15 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Use Callback for RunVmCommand. ...................................................................... core: Use Callback for RunVmCommand. As part of the the use of ConcurrentChildCommandsExecutionCallback with Cinder disks. RunVmCommand should also use it since this command also running a stateles VM. Also fixing a dead lock when calling RestoreAllCinderSnapshotsCommand, This only occurs in ovirt-engine-3.6 since the infrastructure in master behaves differently. Change-Id: I7b86461dd394aab9cd790397be21ac4d6801baa2 Bug-Url: https://bugzilla.redhat.com/1305809 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreAllCinderSnapshotsCommand.java 2 files changed, 16 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/53511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b86461dd394aab9cd790397be21ac4d6801baa2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: logging: remove debug message with no value
by tnisan＠redhat.com 15 Feb '16

15 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: logging: remove debug message with no value ...................................................................... logging: remove debug message with no value Whenever I set debug level I can see the same stack traces which has no value and they make it harder to spot real issues. Bug-Url: https://bugzilla.redhat.com/1306406 Change-Id: I07e85e1023ba5df20eaf49a3f29ff73a8ac1fe34 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07e85e1023ba5df20eaf49a3f29ff73a8ac1fe34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant command line
by mlipchuk＠redhat.com 15 Feb '16

15 Feb '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant command line ...................................................................... core: Remove redundant command line Remove duplicate command line Change-Id: Ifae70fd942497f94c3979c416475e8fa4fa263c2 Bug-Url: https://bugzilla.redhat.com/1305809 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/53509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifae70fd942497f94c3979c416475e8fa4fa263c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: spec: update dependencies
by sbonazzo＠redhat.com 15 Feb '16

15 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: spec: update dependencies ...................................................................... spec: update dependencies Update dependencies to current master Change-Id: Ic20f365a2c4c300b006b37afc89abda16806f6de Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20f365a2c4c300b006b37afc89abda16806f6de Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: pythonlib: added python3 support
by sbonazzo＠redhat.com 15 Feb '16

15 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: pythonlib: added python3 support ...................................................................... packaging: pythonlib: added python3 support python3 support is incomplete. two files are removed from final packages, because they rely on packages that are python2-only: - ovirt_engine.service: relies on python-daemon - ovirt_engine.ticket: relies on m2crypto Change-Id: If0cf0ad55d1cbaba11c78583fc68b7a491edf3a2 Bug-Url: https://bugzilla.redhat.com/1254654 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M Makefile M ovirt-engine.spec.in 2 files changed, 42 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/53071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0cf0ad55d1cbaba11c78583fc68b7a491edf3a2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0