February 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: otopi: add 3.6 branch support
by sbonazzo＠redhat.com 15 Feb '16

15 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: otopi: add 3.6 branch support ...................................................................... otopi: add 3.6 branch support Change-Id: Ia440a14374ce7616ea99610d0afd9bec795aba76 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/otopi/otopi_create-rpms.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia440a14374ce7616ea99610d0afd9bec795aba76 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: mock build: avoid duplicate src.rpm
by dcaro＠redhat.com 15 Feb '16

15 Feb '16

David Caro has submitted this change and it was merged. Change subject: mock build: avoid duplicate src.rpm ...................................................................... mock build: avoid duplicate src.rpm avoid to save locally built src.rpm in exported-artifacts so there won't be duplicate src.rpm. Change-Id: I99941b4532b39c6a281c9e4ee5bf60b8ded6b392 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/shell-scripts/build_local_srcrpm.sh M jobs/confs/shell-scripts/build_local_srcrpm_releng.sh M jobs/confs/shell-scripts/build_mock_srcrpm.sh M jobs/confs/shell-scripts/mock_build_onlyrpm.sh 4 files changed, 6 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/47866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99941b4532b39c6a281c9e4ee5bf60b8ded6b392 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in mom[master]: Fix momd.service file syntax
by msivak＠redhat.com 15 Feb '16

15 Feb '16

Martin Sivák has submitted this change and it was merged. Change subject: Fix momd.service file syntax ...................................................................... Fix momd.service file syntax Renamed Timeout parameter to TimeoutSec according to the systemd documentation at https://www.freedesktop.org/software/systemd/man/systemd.service.html Bug-Url: https://bugzilla.redhat.com/1263983 Change-Id: I287423f065d5dfe45140050678be2163e231c83d Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/53468 Continuous-Integration: Jenkins CI Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- M contrib/momd.service 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/53468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I287423f065d5dfe45140050678be2163e231c83d Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: vdsbroker: Add prepare and teardown images vds commands
by mlipchuk＠redhat.com 15 Feb '16

15 Feb '16

Maor Lipchuk has submitted this change and it was merged. Change subject: vdsbroker: Add prepare and teardown images vds commands ...................................................................... vdsbroker: Add prepare and teardown images vds commands Adding support for VDS preparing and tearing down images. Change-Id: I8d36e8f4e56e6b763224b3b9421f3d013450731f Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ImageActionsVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ImageActionsVDSCommandBase.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PrepareImageReturnForXmlRpc.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PrepareImageVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TeardownImageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 10 files changed, 204 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Amit Aviram: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d36e8f4e56e6b763224b3b9421f3d013450731f Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveVmTemplateFromImportExport - ctor exception
by laravot＠redhat.com 15 Feb '16

15 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: core: RemoveVmTemplateFromImportExport - ctor exception ...................................................................... core: RemoveVmTemplateFromImportExport - ctor exception This patch fixes two issues: 1. When executing RemoveVmTemplate during the ctor run the template is queried and is used to set the storage pool id. When removing a template from an export domain this operation will cause to exception as the template info is queried from the export domain and the backend object used to run vds command isn't injected yet. As the pool info is available to us there's no need to query the template on that phase when removing a template from an export domain. 2. It's being inspected whether the template contains cinder disks and if it is the command uses a callback. When a template with cinder disks is exported to an export domain and exists on the engine as well, a callback will be returned mistakenly because the one persisted on the engine db will be checked for the existense of cinder disks. This patches exports the logic from the ctor to the init() method and overrides it in the RemoveVmTemplateFromImportExport command to solve those two issues. Change-Id: I3a7f8958fba2aa28b23682e3252ba4766523f6f4 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/RemoveVmTemplateFromImportExportCommand.java 2 files changed, 11 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a7f8958fba2aa28b23682e3252ba4766523f6f4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: profiles: make AddUserProfile update the key
by ahadas＠redhat.com 15 Feb '16

15 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: profiles: make AddUserProfile update the key ...................................................................... core: profiles: make AddUserProfile update the key To accomodate the need of REST API, we make AddUserProfileCommand detect when the client wants just to update the SSH Public key parameters, and we handle this case inside the command as special case of Update, trasparently. During the verification of this patch it was discovered that the update command was not refreshing the SSHPublicKeyID after each change. This is harmless for {UserPortal,Webadmin} UI, but incorrect for the REST API. So this patch also make sure that each succesfully update changes the key ID. Change-Id: Ia197bddb74186fa7c696f7e7f28e8fbe5e487e08 Bug-Url: https://bugzilla.redhat.com/1283499 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java 3 files changed, 49 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia197bddb74186fa7c696f7e7f28e8fbe5e487e08 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: change how filter error message in pool monitoring
by ahadas＠redhat.com 15 Feb '16

15 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: change how filter error message in pool monitoring ...................................................................... core: change how filter error message in pool monitoring Instead of removing the irrelevant elements (that are not messages), keep the relevant ones (the messages in EngineMessages). Change-Id: Ibbf37ad4070ca98ebdfe5f106f315174426126e1 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ErrorMessageUtils.java 3 files changed, 13 insertions(+), 19 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbf37ad4070ca98ebdfe5f106f315174426126e1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: publisher 3.5: dropping node jobs
by sbonazzo＠redhat.com 15 Feb '16

15 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: publisher 3.5: dropping node jobs ...................................................................... publisher 3.5: dropping node jobs node jobs have been disabled last week. Change-Id: Iaee875241c83301fd3f5e2fcad935588dc633fac Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.5.yaml 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaee875241c83301fd3f5e2fcad935588dc633fac Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RunVmCommand using callbacks
by mlipchuk＠redhat.com 14 Feb '16

14 Feb '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: RunVmCommand using callbacks ...................................................................... core: RunVmCommand using callbacks Set the commnad id and the shouldBeEndedByParent with false. RunVmCommand is calling its only child command, CreateAllSnapshotsFromVmCommand, form the execute command and at the endAction phase. Once the command is used with a callback we need to change the command to be set with ShouldBeEndedByParent as false so the snapshot and the disk will be unlocked. Change-Id: I6a5889eb4ab378347baa46672afaf2edf48cd738 Bug-Url: https://bugzilla.redhat.com/1305809 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/53494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a5889eb4ab378347baa46672afaf2edf48cd738 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Support mixed disk types for stateless VM.
by mlipchuk＠redhat.com 14 Feb '16

14 Feb '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support mixed disk types for stateless VM. ...................................................................... core: Support mixed disk types for stateless VM. Change-Id: I81a39f42aa20810df2e339cc475f9206abbdcd06 Bug-Url: https://bugzilla.redhat.com/1305809 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/53501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81a39f42aa20810df2e339cc475f9206abbdcd06 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0