February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Make multiselect bheaviour of list model consistent
by awels＠redhat.com 12 Feb '16

12 Feb '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Make multiselect bheaviour of list model consistent ...................................................................... webadmin: Make multiselect bheaviour of list model consistent Currently in the preferred host list it sometimes happens that when listening on a multi select event and then accessing the single select value of the list box, it still contains the old value. This patch makes sure that the values for single and multi select are always synchronized. Change-Id: I28feceb6a4c2d163e8edb2ea37b712bd82335a9c Bug-Url: https://bugzilla.redhat.com/1265953 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Roman Mohr: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28feceb6a4c2d163e8edb2ea37b712bd82335a9c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Move AbstractPercentColumn to common
by awels＠redhat.com 12 Feb '16

12 Feb '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin, userportal: Move AbstractPercentColumn to common ...................................................................... webadmin, userportal: Move AbstractPercentColumn to common The AbstractPercentColumn will be used in the DisksViewColumns to display Image Transfer progress. DisksViewColumns in in common, requiring AbstractPercentColumn to be there as well. Change-Id: I0e067f67e328253d05e3cf412aa9b69da6b3ec0d Related-To: https://bugzilla.redhat.com/1091377 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractProgressBarColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/AbstractPercentColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/AbstractQuotaPercentColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/MigrationProgressColumn.java 6 files changed, 21 insertions(+), 18 deletions(-) Approvals: Greg Padgett: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e067f67e328253d05e3cf412aa9b69da6b3ec0d Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: fix mixed-use-of-spaces-and-tabs
by sbonazzo＠redhat.com 12 Feb '16

12 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: fix mixed-use-of-spaces-and-tabs ...................................................................... packaging: spec: fix mixed-use-of-spaces-and-tabs Change-Id: I1b5f692bf7dac6bf5ded653a84c1e0873996fd82 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b5f692bf7dac6bf5ded653a84c1e0873996fd82 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: escaped macro in comment
by sbonazzo＠redhat.com 12 Feb '16

12 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: escaped macro in comment ...................................................................... packaging: spec: escaped macro in comment escaped the macro within comments adding another leading % avoiding them to be expanded. Change-Id: If6a655b0c60669b46c425355e225aa8be36dfa53 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6a655b0c60669b46c425355e225aa8be36dfa53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: V3 compatibility for "vm.permissions.clone"
by juan.hernandez＠redhat.com 12 Feb '16

12 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: V3 compatibility for "vm.permissions.clone" ...................................................................... restapi: V3 compatibility for "vm.permissions.clone" In version 4 of the API the "vm.permissions.clone" element has been removed and replaced by the a "clone_permissions" matrix parameter. Now that the API supports multiple versions this support can be rea-added without modifying the V4 implementation. Change-Id: I1966f124f849f3e2e48744ecb9670bac349b13f7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplatesServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 2 files changed, 33 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1966f124f849f3e2e48744ecb9670bac349b13f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: V3 compatibility for "collapse_snapshots"
by juan.hernandez＠redhat.com 12 Feb '16

12 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: V3 compatibility for "collapse_snapshots" ...................................................................... restapi: V3 compatibility for "collapse_snapshots" In version 4 of the API the "action.vm.snapshots.collaspe_snahospts" element has been removed and replaced by the a "collapse_snapshots" matrix parameter. Now that the API supports multiple versions this support can be rea-added without modifying the V4 implementation. Change-Id: I3d6782ac15f4cfdf7606e5601e1d0601ec9be3d1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageDomainVmServer.java 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d6782ac15f4cfdf7606e5601e1d0601ec9be3d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: broker: Do not autogenerate numatune node pinnings
by piotr.kliczewski＠gmail.com 12 Feb '16

12 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: broker: Do not autogenerate numatune node pinnings ...................................................................... broker: Do not autogenerate numatune node pinnings Only pin virtual NUMA nodes to the memory of specific host NUMA nodes when it is explicitly requested. Otherwise VM NUMA nodes are implicitliy pinned to specific host NUMA nodes (with a specific NUMA node architecture). Then the VM can't be migrated when the host architecture of the target host differs, although no specific NUMA configuration was requested by the user. Change-Id: If0d737618a692833d0162ac09303864d651b3ead Bug-Url: https://bugzilla.redhat.com/1303842 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java 3 files changed, 20 insertions(+), 17 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0d737618a692833d0162ac09303864d651b3ead Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: broker: Do not autogenerate numatune node pinnings
by piotr.kliczewski＠gmail.com 12 Feb '16

12 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: broker: Do not autogenerate numatune node pinnings ...................................................................... broker: Do not autogenerate numatune node pinnings Only pin virtual NUMA nodes to the memory of specific host NUMA nodes when it is explicitly requested. Otherwise VM NUMA nodes are implicitliy pinned to specific host NUMA nodes (with a specific NUMA node architecture). Then the VM can't be migrated when the host architecture of the target host differs, although no specific NUMA configuration was requested by the user. Change-Id: If0d737618a692833d0162ac09303864d651b3ead Bug-Url: https://bugzilla.redhat.com/1303842 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java 3 files changed, 20 insertions(+), 17 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0d737618a692833d0162ac09303864d651b3ead Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Disk edit dialogs are all enbabled when they shoul...
by tnisan＠redhat.com 12 Feb '16

12 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Disk edit dialogs are all enbabled when they should not ...................................................................... webadmin: Disk edit dialogs are all enbabled when they should not Change-Id: I92e7c532910d15ac16cbf2bf0a495fd009e9471d Bug-Url: https://bugzilla.redhat.com/1305945 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 2 files changed, 31 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92e7c532910d15ac16cbf2bf0a495fd009e9471d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: spec: update to fedora guidelines
by msivak＠redhat.com 12 Feb '16

12 Feb '16

Martin Sivák has submitted this change and it was merged. Change subject: spec: update to fedora guidelines ...................................................................... spec: update to fedora guidelines misc updates to comply with fedora guidelines Change-Id: Iee15217cbddea5449ae67afa4a0c4fa6ceaf5c7e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M ovirt-hosted-engine-ha.spec.in 2 files changed, 11 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee15217cbddea5449ae67afa4a0c4fa6ceaf5c7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0